> Hi,
>
> I would like to propose an implementation to support AES CBC with Ciphertext
> Stealing (CTS) in SunPKCS11, according to what has been specified in
> [JDK-8330843 CSR](https://bugs.openjdk.org/browse/JDK-8330843).
>
> What follows are implementation notes that describe the most releva
On Mon, 27 May 2024 14:22:51 GMT, Francisco Ferrari Bihurriet
wrote:
>> Francisco Ferrari Bihurriet has updated the pull request with a new target
>> base due to a merge or a rebase. The incremental webrev excludes the
>> unrelated changes brought in by the merge/rebase. The pull request conta
On Wed, 29 May 2024 15:45:12 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-4966250
src/java.base/share/classes/javax/net/ssl/SSLSessionContext.java line 92:
> 90: * When the timeout limit is exceeded for a session, the
> 91: * SSLSession object is marked so that future
On Wed, 29 May 2024 15:45:12 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-4966250
This needs a CSR before pushing.
-
PR Comment: https://git.openjdk.org/jdk/pull/19458#issuecomment-2138078036
On Wed, 29 May 2024 15:50:05 GMT, Pavel Rappo wrote:
>> @cl4es, here are some results from my machine (macosx-aarch64):
>>
>> Name (size) Cnt BaseError TestError
>> Unit Change
>> ArraysHashCode.bytes1 150.715 ± 0.004 0.725 ± 0.029
On Wed, 29 May 2024 12:53:42 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/jdk/internal/util/ArraysSupport.java line 252:
>>
>>> 250: return switch (length) {
>>> 251: case 0 -> initialValue;
>>> 252: case 1 -> 31 * initialValue + (int) a[fromIndex];
>>
On Wed, 29 May 2024 12:44:45 GMT, Pavel Rappo wrote:
>> I don't care as long as microbenchmarks don't get a hiccup.
>
> @cl4es, here are some results from my machine (macosx-aarch64):
>
> Name (size) Cnt BaseError TestError
> Unit Change
> ArraysHashCode
https://bugs.openjdk.org/browse/JDK-4966250
-
Commit messages:
- first iteration
Changes: https://git.openjdk.org/jdk/pull/19458/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19458&range=00
Issue: https://bugs.openjdk.org/browse/JDK-4966250
Stats: 7 lines in 1 file ch
> Please review this PR, which supersedes a now withdrawn
> https://github.com/openjdk/jdk/pull/14831.
>
> This PR replaces `ArraysSupport.vectorizedHashCode` with a set of more
> user-friendly methods. Here's a summary:
>
> - Made the operand constants (i.e. `T_BOOLEAN` and friends) and the
>
On Tue, 28 May 2024 19:13:50 GMT, Jorn Vernee wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix incorrect utf16 hashCode adaptation
>
> src/java.base/share/classes/jdk/internal/util/ArraysSupport.java line 252:
>
On Tue, 28 May 2024 20:40:30 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/jdk/internal/util/ArraysSupport.java line 275:
>>
>>> 273: return switch (length) {
>>> 274: case 0 -> initialValue;
>>> 275: case 1 -> 31 * initialValue + (a[fromIndex] & 0xff)
On Mon, 27 May 2024 20:55:29 GMT, Pavel Rappo wrote:
>> Please review this PR, which supersedes a now withdrawn
>> https://github.com/openjdk/jdk/pull/14831.
>>
>> This PR replaces `ArraysSupport.vectorizedHashCode` with a set of more
>> user-friendly methods. Here's a summary:
>>
>> - Made t
On Thu, 4 Apr 2024 19:37:56 GMT, Matthew Donovan wrote:
> In this PR, I updated the version of the NSS libraries used in PKCS11Test to
> 3.96.
This pull request has now been integrated.
Changeset: 6cda4c59
Author:Matthew Donovan
URL:
https://git.openjdk.org/jdk/commit/6cda4c59851d7
On Wed, 29 May 2024 03:21:27 GMT, Chen Liang wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix incorrect utf16 hashCode adaptation
>
> src/java.base/share/classes/jdk/internal/util/ArraysSupport.java line 320:
>
On Tue, 28 May 2024 20:21:34 GMT, Claes Redestad wrote:
>> test/hotspot/jtreg/compiler/intrinsics/TestArraysHashCode.java line 88:
>>
>>> 86: private static int testIntrinsic(byte[] bytes, int type)
>>> 87: throws InvocationTargetException, IllegalAccessException {
>>> 88:
On Mon, 27 May 2024 20:55:29 GMT, Pavel Rappo wrote:
>> Please review this PR, which supersedes a now withdrawn
>> https://github.com/openjdk/jdk/pull/14831.
>>
>> This PR replaces `ArraysSupport.vectorizedHashCode` with a set of more
>> user-friendly methods. Here's a summary:
>>
>> - Made t
On Wed, 29 May 2024 03:16:02 GMT, Chen Liang wrote:
>> In fact, if I change it to `2`, the following tests will fail:
>>
>> - `jdk/jdk/classfile/Utf8EntryTest.java`
>> - `jdk/java/util/zip/ZipCoding.java`
>> - `jdk/java/text/Format/MessageFormat/MessageRegression.java`
>
> Indeed, the actu
On Tue, 16 Apr 2024 22:30:57 GMT, Valerie Peng wrote:
>> What about testing?
>
> @mcpowers I am about to leave for vacation. Will wait for your review and
> resume on this PR after I return. Thanks!
UP @valeriepeng possible to backport PKCS11 configuration attribute part on
JDK 17 or 21 ?
--
18 matches
Mail list logo
