Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v77]

2024-05-15 Thread Alan Bateman
On Wed, 15 May 2024 19:59:59 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pu

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v77]

2024-05-15 Thread Alan Bateman
On Wed, 15 May 2024 19:59:59 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pu

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v77]

2024-05-15 Thread Alan Bateman
On Wed, 15 May 2024 19:59:59 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pu

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v77]

2024-05-15 Thread Alan Bateman
On Wed, 15 May 2024 19:59:59 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pu

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v75]

2024-05-15 Thread Alan Bateman
On Wed, 15 May 2024 17:14:55 GMT, Kevin Driver wrote: > An empty ikm and/or salt list is a supported scenario, so this should be > fine. I have added the documentation comment about the order of elements. The context for asking is that HKDFParameterSpec.ofExtract has wording to say that the ad

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v77]

2024-05-15 Thread Alan Bateman
On Wed, 15 May 2024 19:59:59 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pu

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v75]

2024-05-15 Thread Alan Bateman
On Wed, 15 May 2024 17:14:55 GMT, Kevin Driver wrote: > I'm a bit confused by this question. HKDFParameterSpec.Extract does not > contain an info. Maybe I am missing something. A typo in my comment, I meant Expand rather than Extract. Look at the description of the "info" method and you'll see

Integrated: 8316138: Add GlobalSign 2 TLS root certificates

2024-05-15 Thread Rajan Halade
On Wed, 15 May 2024 16:31:39 GMT, Rajan Halade wrote: > This PR is to add two new TLS root certificates from GlobalSign. This CA has > gone through > https://www.oracle.com/java/technologies/javase/carootcertsprogram.html > process. > > > The release-note is at > [JDK-8331979](https://bugs.

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v77]

2024-05-15 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since the

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v76]

2024-05-15 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since the

Re: RFR: 8316138: Add GlobalSign 2 TLS root certificates

2024-05-15 Thread Sean Mullan
On Wed, 15 May 2024 16:31:39 GMT, Rajan Halade wrote: > This PR is to add two new TLS root certificates from GlobalSign. This CA has > gone through > https://www.oracle.com/java/technologies/javase/carootcertsprogram.html > process. > > > The release-note is at > [JDK-8331979](https://bugs.

Re: RFR: 8325513: Export method for Cipher [v3]

2024-05-15 Thread Weijun Wang
On Fri, 10 May 2024 14:00:55 GMT, Weijun Wang wrote: >> Add `Cipher::export` API. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > change new method to non final I don't think KDF API is needed for a user of HPKE. They do ne

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v75]

2024-05-15 Thread Kevin Driver
On Wed, 15 May 2024 16:58:05 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pu

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v75]

2024-05-15 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with two additional commits since th

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v74]

2024-05-15 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since the

Re: RFR: 8325513: Export method for Cipher [v3]

2024-05-15 Thread Jamil Nimeh
On Fri, 10 May 2024 14:00:55 GMT, Weijun Wang wrote: >> Add `Cipher::export` API. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > change new method to non final That seems like a good approach. If Cipher can address all th

RFR: 8316138: Add GlobalSign 2 TLS root certificates

2024-05-15 Thread Rajan Halade
This PR is to add two new TLS root certificates from GlobalSign. This CA has gone through https://www.oracle.com/java/technologies/javase/carootcertsprogram.html process. The release-note is at [JDK-8331979](https://bugs.openjdk.org/browse/JDK-8331979) - Commit messages: - 83161

Re: RFR: 8325513: Export method for Cipher [v3]

2024-05-15 Thread Weijun Wang
On Fri, 10 May 2024 14:00:55 GMT, Weijun Wang wrote: >> Add `Cipher::export` API. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > change new method to non final As for the cart and horse order, I think you're right. Maybe I

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v65]

2024-05-15 Thread Kevin Driver
On Tue, 14 May 2024 23:17:48 GMT, Weijun Wang wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> re-enable Delayed Provider test > > src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java > line 9

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v73]

2024-05-15 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since the

Re: RFR: 8325513: Export method for Cipher [v3]

2024-05-15 Thread Weijun Wang
On Fri, 10 May 2024 14:00:55 GMT, Weijun Wang wrote: >> Add `Cipher::export` API. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > change new method to non final I haven't started JDK-8325548 yet since it requires KDF. Also,

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v72]

2024-05-15 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since the

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v71]

2024-05-15 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with two additional commits since th

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v70]

2024-05-15 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with three additional commits since

Re: RFR: 8325513: Export method for Cipher [v3]

2024-05-15 Thread Jamil Nimeh
On Fri, 10 May 2024 14:00:55 GMT, Weijun Wang wrote: >> Add `Cipher::export` API. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > change new method to non final I see that it could work that way, but have we firmly establis

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v6]

2024-05-15 Thread Maurizio Cimadamore
> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting > the use of JNI in the following ways: > > * `System::load` and `System::loadLibrary` are now restricted methods > * `Runtime::load` and `Runtime::loadLibrary` are now restricted methods > * binding a JNI `native` metho

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v69]

2024-05-15 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since the

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v5]

2024-05-15 Thread Alan Bateman
On Wed, 15 May 2024 10:40:34 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and `Runtime::loa

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v68]

2024-05-15 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with two additional commits since th

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v67]

2024-05-15 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since the

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v26]

2024-05-15 Thread Kevin Driver
On Tue, 14 May 2024 21:26:02 GMT, Sean Mullan wrote: >> First, very wrong parameters (say, null info, negative length) should not be >> create-able at all. >> >> Then, in some cases, "correct" parameters could still be "invalid". For >> example, HKDF expand key length cannot exceed HashLen * 2

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v66]

2024-05-15 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since the

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v3]

2024-05-15 Thread Alan Bateman
On Wed, 15 May 2024 10:34:01 GMT, Maurizio Cimadamore wrote: > I don't fully agree that this option is not module related (which is why I > gave it that name). The very definition of illegal native access is related > to native access occurring from a module that is outside a specific set. So

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v5]

2024-05-15 Thread Maurizio Cimadamore
> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting > the use of JNI in the following ways: > > * `System::load` and `System::loadLibrary` are now restricted methods > * `Runtime::load` and `Runtime::loadLibrary` are now restricted methods > * binding a JNI `native` metho

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v3]

2024-05-15 Thread Maurizio Cimadamore
On Wed, 15 May 2024 06:15:35 GMT, Alan Bateman wrote: >> So my recollection/understanding is that we use this mechanism to convert >> module-related `--` flags passed to the VM into system properties that the >> Java code can then read, but we set them up such that you are not allowed to >> sp

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v4]

2024-05-15 Thread Maurizio Cimadamore
On Wed, 15 May 2024 07:55:27 GMT, ExE Boss wrote: > Note that this line is still not entirely correct, as for code like: You are correct - the message is however consistent with what written in JEP 472. I'll discuss with @pron - PR Review Comment: https://git.openjdk.org/jdk/pull/

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v65]

2024-05-15 Thread Alan Bateman
On Tue, 14 May 2024 22:14:47 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pu

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v4]

2024-05-15 Thread ExE Boss
On Tue, 14 May 2024 18:10:28 GMT, Maurizio Cimadamore wrote: >> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting >> the use of JNI in the following ways: >> >> * `System::load` and `System::loadLibrary` are now restricted methods >> * `Runtime::load` and `Runtime::loa