Re: RFR: 8331008: KDF Implementation (Preview) [v28]

2024-05-12 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since the

Re: RFR: 8331008: KDF Implementation (Preview) [v27]

2024-05-12 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request incrementally with one additional commit since the

RFR: 8332102: Add `@since` to package-info of `jdk.security.jarsigner`

2024-05-12 Thread Nizar Benalla
Code cleanup. The package was added back in [8056174](https://bugs.openjdk.org/browse/JDK-8056174). Thanks to anyone reviewing this change. - Commit messages: - add an `@since` and modify Copyright header Changes: https://git.openjdk.org/jdk/pull/19191/files Webrev: https://webre

RFR: 8332100: Add missing `@since` to KeyValue::EC_TYPE in `java.xml.crypto`

2024-05-12 Thread Nizar Benalla
Simple code cleanup. This was added back in [JDK 13](https://github.com/openjdk/jdk/commit/71825293eb83d7c9ac122c11a12465c2acbec040) and should have an `@since` - Commit messages: - add an `@since` and modify Copyright header Changes: https://git.openjdk.org/jdk/pull/19190/files

Re: RFR: 8331008: KDF Implementation (Preview) [v26]

2024-05-12 Thread Weijun Wang
On Sun, 12 May 2024 14:39:40 GMT, Sean Mullan wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> commenting out until better understood -- causing failures > > src/java.base/share/classes/javax/crypto/KDF.java line 39

Re: RFR: 8331008: KDF Implementation (Preview) [v26]

2024-05-12 Thread Weijun Wang
On Sat, 11 May 2024 02:06:09 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pu

Re: RFR: 8331008: KDF Implementation (Preview) [v26]

2024-05-12 Thread Sean Mullan
On Sat, 11 May 2024 02:06:09 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pu

Re: RFR: 8321274: Rename ZipEntry.extraAttributes to ZipEntry.externalFileAttributes [v4]

2024-05-12 Thread Chen Liang
On Fri, 8 Mar 2024 09:34:05 GMT, Eirik Bjørsnøs wrote: >> Please consider this PR which suggests we rename `ZipEntry.extraAttributes` >> to `ZipEntry.externalFileAttributes`. >> >> This field was introduced in >> [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under >>