Re: Reproducer for JDK-8221218 again

2024-05-03 Thread Bradford Wetmore
Thanks Domien. First off, thank you so much for the detailed bug report, and how to reproduce.   It made creating a reproducer very easy. JDK-8221218 and friends were test bugs, but happen to have the same exceptions that you're seeing here. This is an unrelated issue.  I have filed JDK-833

Re: RFR: 8319332: Security properties files inclusion [v13]

2024-05-03 Thread Sean Mullan
On Fri, 3 May 2024 20:46:46 GMT, Martin Balao wrote: >> src/java.base/share/conf/security/java.security line 70: >> >>> 68: # an error is thrown and explicit profile selection is required. In >>> order >>> 69: # to override properties defined in this file, the include statement >>> may be >>>

Re: RFR: 8319332: Security properties files inclusion [v13]

2024-05-03 Thread Martin Balao
On Fri, 3 May 2024 20:02:29 GMT, Weijun Wang wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Profiles documentation adjustments. >> >> Co-authored-by: Francisco Ferrari >> Co-authored-by: Mar

Re: RFR: 8319332: Security properties files inclusion [v14]

2024-05-03 Thread Francisco Ferrari Bihurriet
> The implementation of this proposal is based on the requirements, > specification and design choices described in the [JDK-8319332] ticket and > its respective CSR [JDK-8319333]. What follows are implementation notes > organized per functional component, with the purpose of assisting to naviga

Re: RFR: 8319332: Security properties files inclusion [v13]

2024-05-03 Thread Martin Balao
On Fri, 3 May 2024 19:37:02 GMT, Sean Mullan wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Profiles documentation adjustments. >> >> Co-authored-by: Francisco Ferrari >> Co-authored-by: Mar

Re: RFR: 8319332: Security properties files inclusion [v13]

2024-05-03 Thread Martin Balao
On Fri, 3 May 2024 19:32:56 GMT, Sean Mullan wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Profiles documentation adjustments. >> >> Co-authored-by: Francisco Ferrari >> Co-authored-by: Mar

Re: RFR: 8319332: Security properties files inclusion [v13]

2024-05-03 Thread Weijun Wang
On Thu, 2 May 2024 21:24:19 GMT, Francisco Ferrari Bihurriet wrote: >> The implementation of this proposal is based on the requirements, >> specification and design choices described in the [JDK-8319332] ticket and >> its respective CSR [JDK-8319333]. What follows are implementation notes >>

Re: RFR: 8319332: Security properties files inclusion [v13]

2024-05-03 Thread Sean Mullan
On Thu, 2 May 2024 21:24:19 GMT, Francisco Ferrari Bihurriet wrote: >> The implementation of this proposal is based on the requirements, >> specification and design choices described in the [JDK-8319332] ticket and >> its respective CSR [JDK-8319333]. What follows are implementation notes >>

Reproducer for JDK-8221218 again

2024-05-03 Thread Domien Nowicki
Hi everyone, Recently we've started to use SSLEngine to create our own TLS server. However we sometimes got the following exception "SSLHandshakeException: Insufficient buffer remaining for AEAD cipher fragment (2)." when dealing with client disconnections at server side during the TLS hands

Integrated: 8312104: Update java man pages to include new security category in -XshowSettings

2024-05-03 Thread Sean Coffey
On Fri, 3 May 2024 09:27:28 GMT, Sean Coffey wrote: > Incorporate man page changes related to JDK-8281658 and related issues > (including JDK-8311653) This pull request has now been integrated. Changeset: 77b71222 Author:Sean Coffey URL: https://git.openjdk.org/jdk/commit/77b71222a

Re: RFR: 8312104: Update java man pages to include new security category in -XshowSettings

2024-05-03 Thread Lance Andersen
On Fri, 3 May 2024 09:27:28 GMT, Sean Coffey wrote: > Incorporate man page changes related to JDK-8281658 and related issues > (including JDK-8311653) Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19078#pullrequestreview-2038328561

RFR: 8312104: Update java man pages to include new security category in -XshowSettings

2024-05-03 Thread Sean Coffey
Incorporate man page changes related to JDK-8281658 and related issues (including JDK-8311653) - Commit messages: - minor tidy up - bullet points - Initial commit Changes: https://git.openjdk.org/jdk/pull/19078/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19078&range=

Re: RFR: 8330278: Have SSLSocketTemplate.doClientSide use loopback address

2024-05-03 Thread Sibabrata Sahoo
On Fri, 3 May 2024 11:22:51 GMT, Sean Coffey wrote: > Using the loopback address by default may prove more reliable for some test > configurations > > ran all jdk_security tests. no issues seen. Marked as reviewed by ssahoo (Committer). - PR Review: https://git.openjdk.org/jdk/pu

Re: RFR: 8330278: Have SSLSocketTemplate.doClientSide use loopback address

2024-05-03 Thread Matthew Donovan
On Fri, 3 May 2024 11:22:51 GMT, Sean Coffey wrote: > Using the loopback address by default may prove more reliable for some test > configurations > > ran all jdk_security tests. no issues seen. looks good to me. - PR Comment: https://git.openjdk.org/jdk/pull/19083#issuecomment-2

RFR: 8330278: Have SSLSocketTemplate.doClientSide use loopback address

2024-05-03 Thread Sean Coffey
Using the loopback address by default may prove more reliable for some test configurations ran all jdk_security tests. no issues seen. - Commit messages: - Initial commit Changes: https://git.openjdk.org/jdk/pull/19083/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19083