Re: RFR: 8330178: Clean up non-standard use of /** comments in `java.base` [v2]

2024-04-22 Thread Iris Clark
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote: >> Please review a set of updates to clean up use of `/**` comments in the >> vicinity of declarations. >> >> There are various categories of update: >> >> * "Box comments" beginning with `/**` >> * Misplaced doc comments before package

Re: RFR: 8330178: Clean up non-standard use of /** comments in `java.base` [v2]

2024-04-22 Thread Joe Darcy
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote: >> Please review a set of updates to clean up use of `/**` comments in the >> vicinity of declarations. >> >> There are various categories of update: >> >> * "Box comments" beginning with `/**` >> * Misplaced doc comments before package

Re: RFR: 8319332: Security properties files inclusion [v8]

2024-04-22 Thread Weijun Wang
On Mon, 22 Apr 2024 20:42:44 GMT, Francisco Ferrari Bihurriet wrote: >> The implementation of this proposal is based on the requirements, >> specification and design choices described in the [JDK-8319332] ticket and >> its respective CSR [JDK-8319333]. What follows are implementation notes >>

Re: RFR: 8319332: Security properties files inclusion [v7]

2024-04-22 Thread Martin Balao
On Fri, 19 Apr 2024 19:40:53 GMT, Weijun Wang wrote: >> Francisco Ferrari Bihurriet has updated the pull request with a new target >> base due to a merge or a rebase. The pull request now contains 11 commits: >> >> - Merge 'openjdk/master' into JDK-8319332 >> - Merge 'openjdk/master' into JDK

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-22 Thread Sean Mullan
On Fri, 19 Apr 2024 09:09:56 GMT, Oli Gillespie wrote: > Thanks :) - created release note at > https://bugs.openjdk.org/browse/JDK-8330632, please review if you can. Looks fine. You can mark it as Resolved/Delivered after the fix is integrated. - PR Comment: https://git.openjdk.or

Re: RFR: 8319332: Security properties files inclusion [v8]

2024-04-22 Thread Francisco Ferrari Bihurriet
> The implementation of this proposal is based on the requirements, > specification and design choices described in the [JDK-8319332] ticket and > its respective CSR [JDK-8319333]. What follows are implementation notes > organized per functional component, with the purpose of assisting to naviga

RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11

2024-04-22 Thread Francisco Ferrari Bihurriet
Hi, I would like to propose an implementation to support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11, according to what has been specified in [JDK-8330843 CSR](https://bugs.openjdk.org/browse/JDK-8330843). What follows are implementation notes that describe the most relevant aspects of

Re: RFR: 8330178: Clean up non-standard use of /** comments in `java.base`

2024-04-22 Thread Alexey Ivanov
On Mon, 22 Apr 2024 17:38:59 GMT, Jonathan Gibbons wrote: > The document [How to Write Doc Comments for the Javadoc > Tool](https://www.oracle.com/uk/technical-resources/articles/java/javadoc-tool.html) > is depressingly obsolete, as indicated by this text towards the end: I know. Yet there's

Re: RFR: 8330178: Clean up non-standard use of /** comments in `java.base`

2024-04-22 Thread Jonathan Gibbons
On Fri, 19 Apr 2024 19:29:31 GMT, Alexey Ivanov wrote: > > We do not have an overall style guide. The conventional wisdom for editing > > any existing file is to follow the style in that file, if such a style can > > be discerned. > > That's what I do. > > I saw either style used in JDK. Yet