Re: RFR: 8330178: Clean up non-standard use of /** comments in `java.base`

2024-04-18 Thread Iris Clark
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote: > Please review a set of updates to clean up use of `/**` comments in the > vicinity of declarations. > > There are various categories of update: > > * "Box comments" beginning with `/**` > * Misplaced doc comments before package or imp

Re: RFR: 8330178: Clean up non-standard use of /** comments in `java.base`

2024-04-18 Thread Joe Darcy
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote: > Please review a set of updates to clean up use of `/**` comments in the > vicinity of declarations. > > There are various categories of update: > > * "Box comments" beginning with `/**` > * Misplaced doc comments before package or imp

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-18 Thread Sean Mullan
On Fri, 12 Apr 2024 15:34:01 GMT, Oli Gillespie wrote: > Increase buffer size in CipherInputStream from 512 bytes to 8192 bytes. > > I have seen applications where this small buffer size significantly reduces > throughput, and I've even seen applications which use reflection to modify > the bu

Re: RFR: 8330178: Clean up non-standard use of /** comments in `java.base`

2024-04-18 Thread Mark Powers
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote: > Please review a set of updates to clean up use of `/**` comments in the > vicinity of declarations. > > There are various categories of update: > > * "Box comments" beginning with `/**` > * Misplaced doc comments before package or imp

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-18 Thread Anthony Scarpino
On Sat, 13 Apr 2024 01:25:57 GMT, David Schlosnagle wrote: > Should the buffer size be a configurable constructor parameter? This would > allow consumers to adjust the buffer size to match their tradeoffs of memory > vs throughput based on workload & available resources, and provide a bit of >

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-18 Thread Anthony Scarpino
On Fri, 12 Apr 2024 15:34:01 GMT, Oli Gillespie wrote: > Increase buffer size in CipherInputStream from 512 bytes to 8192 bytes. > > I have seen applications where this small buffer size significantly reduces > throughput, and I've even seen applications which use reflection to modify > the bu

RFR: 8330178: Clean up non-standard use of /** comments in `java.base`

2024-04-18 Thread Jonathan Gibbons
Please review a set of updates to clean up use of `/**` comments in the vicinity of declarations. There are various categories of update: * "Box comments" beginning with `/**` * Misplaced doc comments before package or import statements * Misplaced doc comments after the annotations for a declar