Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v12]

2024-04-04 Thread Julian Waters
> I regret not actually addressing the issues with the goto labels in > https://github.com/openjdk/jdk/pull/15996, where initialization of locals in > sspi were jumped over by gotos to a certain label. I changed the > initializations into split declarations and assignments in > https://github.c

Re: RFR: 8328785: IOException: Symbol not found: C_GetInterface for PKCS11 interface prior to V3.0 [v3]

2024-04-04 Thread Valerie Peng
> This PR fixes a problem regarding the usage of dlerror() where an earlier > error message causes a premature error out. Added extra code to clear out > earlier error message and made minor code refactoring. > > No regression test as this can't be reproduced using the NSS library from > artifa

Re: RFR: 8328785: IOException: Symbol not found: C_GetInterface for PKCS11 interface prior to V3.0 [v2]

2024-04-04 Thread Valerie Peng
On Thu, 4 Apr 2024 06:23:00 GMT, Daniel JeliƄski wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > src/jdk.crypto.cryptoki/unix/native/libj2pkcs11/p11_md.c line 181: > >> 179: C_GetFu

RFR: 8321543: Update NSS to version 3.96

2024-04-04 Thread Matthew Donovan
In this PR, I updated the version of the NSS libraries used in PKCS11Test to 3.96. - Commit messages: - 8321543: Update NSS to version 3.96 Changes: https://git.openjdk.org/jdk/pull/18636/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18636&range=00 Issue: https://bugs.

Integrated: 8329637: Apparent typo in java.security file property jdk.tls.keyLimits

2024-04-04 Thread Bradford Wetmore
On Thu, 4 Apr 2024 05:36:56 GMT, Bradford Wetmore wrote: > Fix a minor typo in the `java.security` file that got missed during the > original TLSv1.3 work. > > No test needed, comments only. This pull request has now been integrated. Changeset: 4276d5c0 Author:Bradford Wetmore URL:

Re: RFR: 8329637: Apparent typo in java.security file property jdk.tls.keyLimits

2024-04-04 Thread Anthony Scarpino
On Thu, 4 Apr 2024 05:36:56 GMT, Bradford Wetmore wrote: > Fix a minor typo in the `java.security` file that got missed during the > original TLSv1.3 work. > > No test needed, comments only. Marked as reviewed by ascarpino (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull

RFR: 8329637: Apparent typo in java.security file property jdk.tls.keyLimits

2024-04-04 Thread Bradford Wetmore
Fix a minor typo in the `java.security` file that got missed during the original TLSv1.3 work. No test needed, comments only. - Commit messages: - 8329637: Apparent typo in java.security file property jdk.tls.keyLimits Changes: https://git.openjdk.org/jdk/pull/18613/files Webrev

Re: RFR: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc [v2]

2024-04-04 Thread Bradford Wetmore
On Wed, 3 Apr 2024 19:06:22 GMT, Ben Perez wrote: >> Removed `PrivateKeyUsagePeriod` from method javadoc and added several >> commonly used extensions > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > Updated copyright Marked

Re: RFR: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc [v2]

2024-04-04 Thread Sean Mullan
On Wed, 3 Apr 2024 19:06:22 GMT, Ben Perez wrote: >> Removed `PrivateKeyUsagePeriod` from method javadoc and added several >> commonly used extensions > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > Updated copyright Marked