Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v2]

2024-04-01 Thread Alan Bateman
On Mon, 1 Apr 2024 23:37:21 GMT, Tim Prinzing wrote: >> Currently the JFR event FileForceEvent is generated by instrumenting the >> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer >> mirror events with static methods. >> >> Added the event at jdk.internal.event.File

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v2]

2024-04-01 Thread Alan Bateman
On Mon, 1 Apr 2024 23:37:21 GMT, Tim Prinzing wrote: >> Currently the JFR event FileForceEvent is generated by instrumenting the >> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer >> mirror events with static methods. >> >> Added the event at jdk.internal.event.File

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event [v2]

2024-04-01 Thread Tim Prinzing
> Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForceEvent, and changed > jdk.jfr.events.FileForceEvent to

RFR: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc

2024-04-01 Thread Ben Perez
Removed `PrivateKeyUsagePeriod` from method javadoc and added several commonly used extensions - Commit messages: - removed PrivateKeyUsagePeriod from table and added several other commonly used extensions Changes: https://git.openjdk.org/jdk/pull/18565/files Webrev: https://web

Integrated: 8329213: Better validation for com.sun.security.ocsp.useget option

2024-04-01 Thread Aleksey Shipilev
On Wed, 27 Mar 2024 19:31:35 GMT, Aleksey Shipilev wrote: > [JDK-8328638](https://bugs.openjdk.org/browse/JDK-8328638) introduced a new > boolean option, `com.sun.security.ocsp.useget`. We use the usual > `Boolean.parseBoolean` to convert it from String to boolean value, which > works correctl

Re: RFR: 8329213: Better validation for com.sun.security.ocsp.useget option [v5]

2024-04-01 Thread Aleksey Shipilev
On Mon, 1 Apr 2024 07:34:52 GMT, Aleksey Shipilev wrote: >> [JDK-8328638](https://bugs.openjdk.org/browse/JDK-8328638) introduced a new >> boolean option, `com.sun.security.ocsp.useget`. We use the usual >> `Boolean.parseBoolean` to convert it from String to boolean value, which >> works corre

Re: RFR: 8329213: Better validation for com.sun.security.ocsp.useget option [v5]

2024-04-01 Thread Sean Mullan
On Mon, 1 Apr 2024 08:53:35 GMT, Aleksey Shipilev wrote: > Cool. Do I need more reviewers for this area, or one review is enough? One is enough. - PR Comment: https://git.openjdk.org/jdk/pull/18525#issuecomment-2029662124

Re: RFR: 8329213: Better validation for com.sun.security.ocsp.useget option [v5]

2024-04-01 Thread Aleksey Shipilev
On Mon, 1 Apr 2024 07:34:52 GMT, Aleksey Shipilev wrote: >> [JDK-8328638](https://bugs.openjdk.org/browse/JDK-8328638) introduced a new >> boolean option, `com.sun.security.ocsp.useget`. We use the usual >> `Boolean.parseBoolean` to convert it from String to boolean value, which >> works corre

Re: RFR: 8329213: Better validation for com.sun.security.ocsp.useget option [v5]

2024-04-01 Thread Aleksey Shipilev
> [JDK-8328638](https://bugs.openjdk.org/browse/JDK-8328638) introduced a new > boolean option, `com.sun.security.ocsp.useget`. We use the usual > `Boolean.parseBoolean` to convert it from String to boolean value, which > works correctly for `false` and `true` as boolean values. However, any str