Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v11]

2024-03-28 Thread Julian Waters
> I regret not actually addressing the issues with the goto labels in > https://github.com/openjdk/jdk/pull/15996, where initialization of locals in > sspi were jumped over by gotos to a certain label. I changed the > initializations into split declarations and assignments in > https://github.c

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v10]

2024-03-28 Thread Julian Waters
> I regret not actually addressing the issues with the goto labels in > https://github.com/openjdk/jdk/pull/15996, where initialization of locals in > sspi were jumped over by gotos to a certain label. I changed the > initializations into split declarations and assignments in > https://github.c

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event

2024-03-28 Thread Alan Bateman
On Fri, 29 Mar 2024 00:52:46 GMT, Tim Prinzing wrote: > Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForc

RFR: 8329138: Convert JFR FileForceEvent to static mirror event

2024-03-28 Thread Tim Prinzing
Currently the JFR event FileForceEvent is generated by instrumenting the sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer mirror events with static methods. Added the event at jdk.internal.event.FileForceEvent, and changed jdk.jfr.events.FileForceEvent to be a mirror

Integrated: 8327779: Remove deprecated internal field sun.security.x509.X509Key.key

2024-03-28 Thread Eirik Bjørsnøs
On Mon, 11 Mar 2024 09:58:42 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which removes the protected, deprecated field > `X509Key.key` in the internal package `sun.security.x509`. > > This field and the associated field `unusedBits` have been marked > `@Deprecated` since the ini

Re: RFR: 8329213: Better validation for com.sun.security.ocsp.useget option [v4]

2024-03-28 Thread Aleksey Shipilev
> [JDK-8328638](https://bugs.openjdk.org/browse/JDK-8328638) introduced a new > boolean option, `com.sun.security.ocsp.useget`. We use the usual > `Boolean.parseBoolean` to convert it from String to boolean value, which > works correctly for `false` and `true` as boolean values. However, any str

Re: RFR: 8329213: Better validation for com.sun.security.ocsp.useget option [v2]

2024-03-28 Thread Aleksey Shipilev
On Thu, 28 Mar 2024 18:53:34 GMT, Sean Mullan wrote: >> I thought so first too, but decided that `GetPropertyAction` is a better >> place for it, because it needs the generic `privilegedGetProperty`. It is >> also adjacent to `privilegedGetTimeoutProp` that returns `int`. Makes sense? > > Right

Re: RFR: 8329213: Better validation for com.sun.security.ocsp.useget option [v2]

2024-03-28 Thread Sean Mullan
On Thu, 28 Mar 2024 18:26:05 GMT, Aleksey Shipilev wrote: >> src/java.base/share/classes/sun/security/action/GetPropertyAction.java line >> 239: >> >>> 237: * will be returned. >>> 238: */ >>> 239: public static boolean privilegedGetBooleanProp(String prop, >>> boolean def,

Re: RFR: 8329213: Better validation for com.sun.security.ocsp.useget option [v3]

2024-03-28 Thread Aleksey Shipilev
> [JDK-8328638](https://bugs.openjdk.org/browse/JDK-8328638) introduced a new > boolean option, `com.sun.security.ocsp.useget`. We use the usual > `Boolean.parseBoolean` to convert it from String to boolean value, which > works correctly for `false` and `true` as boolean values. However, any str

Re: RFR: 8329213: Better validation for com.sun.security.ocsp.useget option [v2]

2024-03-28 Thread Aleksey Shipilev
On Thu, 28 Mar 2024 18:19:44 GMT, Sean Mullan wrote: > Can you also add to the RN that any value other than "false" > (case-insensitive) defaults to "true". Amended the existing [RN](https://bugs.openjdk.org/browse/JDK-8329111). > src/java.base/share/classes/sun/security/action/GetPropertyActi

Re: RFR: 8329213: Better validation for com.sun.security.ocsp.useget option [v2]

2024-03-28 Thread Sean Mullan
On Thu, 28 Mar 2024 09:09:46 GMT, Aleksey Shipilev wrote: >> [JDK-8328638](https://bugs.openjdk.org/browse/JDK-8328638) introduced a new >> boolean option, `com.sun.security.ocsp.useget`. We use the usual >> `Boolean.parseBoolean` to convert it from String to boolean value, which >> works corr

RFR: 8329013: StackOverflowError when starting Apache Tomcat with signed jar

2024-03-28 Thread Sean Coffey
Calling extra logging calls during initialization of Logger libraries can cause recursion leading to StackOverflowError This patch adds logic to the EventHelper class to detect recursion and prevent it. - Commit messages: - 8329013 Changes: https://git.openjdk.org/jdk/pull/18534/f

Re: RFR: 8327779: Remove deprecated internal field sun.security.x509.X509Key.key

2024-03-28 Thread Sean Mullan
On Mon, 11 Mar 2024 09:58:42 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which removes the protected, deprecated field > `X509Key.key` in the internal package `sun.security.x509`. > > This field and the associated field `unusedBits` have been marked > `@Deprecated` since the ini

Re: RFR: 8323624: ProviderList.ServiceList does not need to be a list [v4]

2024-03-28 Thread Sean Mullan
On Tue, 5 Mar 2024 14:55:06 GMT, Weijun Wang wrote: >> Re-implement it as an `Iterator` to make sure it can only be iterated once >> and make debugger happy. >> >> No regression, just a refactoring. > > Weijun Wang has updated the pull request with a new target base due to a > merge or a rebas

Re: RFR: 8329213: Better validation for com.sun.security.ocsp.useget option [v2]

2024-03-28 Thread Aleksey Shipilev
> [JDK-8328638](https://bugs.openjdk.org/browse/JDK-8328638) introduced a new > boolean option, `com.sun.security.ocsp.useget`. We use the usual > `Boolean.parseBoolean` to convert it from String to boolean value, which > works correctly for `false` and `true` as boolean values. However, any str