Re: Improving logging in Krb5LoginModule

2024-03-12 Thread Wei-Jun Wang
> On Mar 12, 2024, at 5:35 PM, Horváth Péter Gergely > wrote: > > Hi Weijun, > > That is brilliant, thank you. Do we have any developer documentation for > sun.security.util.Debug (apart from the code ;) )? Probably not. The only info I know is the output of java -Djava.security.debug=h

Re: [External] : Re: New Draft of the KDF JEP for the Java Platform

2024-03-12 Thread Martin Balao
Hi Kevin, Thanks for your quick response. On 3/12/24 17:52, Kevin Driver wrote: To be brief, we will be removing the length parameter from the deriveKey arguments list. There was some thought that there may be a use-case where the caller would not want to use all the generated entropy, but at

Re: RFR: 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode [v2]

2024-03-12 Thread Valerie Peng
On Thu, 7 Mar 2024 12:40:09 GMT, Daniel Jeliński wrote: >> Currently the SunPKCS11 provider requires other providers in order to offer >> ECDHE, FFDHE and RSA-PSS in TLS handshakes: >> - FFDHE requires DiffieHellman AlgorithmParameters from SunJCE >> - ECDHE requires the SunEC provider to be ins

Re: [External] : Re: New Draft of the KDF JEP for the Java Platform

2024-03-12 Thread Kevin Driver
Hi Martin. To be brief, we will be removing the length parameter from the deriveKey arguments list. There was some thought that there may be a use-case where the caller would not want to use all the generated entropy, but at this time, we have no valid use-case for this in the current API desig

Re: Improving logging in Krb5LoginModule

2024-03-12 Thread Horváth Péter Gergely
Hi Weijun, That is brilliant, thank you. Do we have any developer documentation for sun.security.util.Debug (apart from the code ;) )? Thinking about this raises the question: wouldn't it be possible to have these components emit Flight Recorder events as well? I understand this is a dubious topi

Re: New Draft of the KDF JEP for the Java Platform

2024-03-12 Thread Martin Balao
Hi Kevin, When looking at the proposed API, I noticed that the length of a derived key or data can be potentially passed both as part of a KDFParameterSpec and as a KDF::deriveKey or KDF::deriveData parameter. This is the case for HKDF (HKDFParameterSpec) apparently. Having a length value on t

Re: RFR: 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode [v3]

2024-03-12 Thread Daniel Jeliński
> Currently the SunPKCS11 provider requires other providers in order to offer > ECDHE, FFDHE and RSA-PSS in TLS handshakes: > - FFDHE requires DiffieHellman AlgorithmParameters from SunJCE > - ECDHE requires the SunEC provider to be installed > - RSA-PSS requires RSASSA-PSS AlgorithmParameters fro

Re: RFR: 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode [v2]

2024-03-12 Thread Daniel Jeliński
On Tue, 12 Mar 2024 18:12:07 GMT, Valerie Peng wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Restore original SunEC behavior > > test/jdk/sun/security/pkcs11/Signature/SigInteropPSS2.java line 56: > >> 54:

Re: RFR: 8296244: Alternate implementation of user-based authorization Subject APIs that doesn’t depend on Security Manager APIs [v6]

2024-03-12 Thread Sean Mullan
On Tue, 5 Mar 2024 19:56:58 GMT, Weijun Wang wrote: >> This code change adds an alternative implementation of user-based >> authorization `Subject` APIs that doesn't depend on Security Manager APIs. >> Depending on if the Security Manager is allowed, the methods store the >> current subject di

Re: RFR: 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode [v2]

2024-03-12 Thread Valerie Peng
On Thu, 7 Mar 2024 12:40:09 GMT, Daniel Jeliński wrote: >> Currently the SunPKCS11 provider requires other providers in order to offer >> ECDHE, FFDHE and RSA-PSS in TLS handshakes: >> - FFDHE requires DiffieHellman AlgorithmParameters from SunJCE >> - ECDHE requires the SunEC provider to be ins

Request to review MR 17742

2024-03-12 Thread Prajwal Kumaraswamy
Hi All, Can anyone please review this MR https://github.com/openjdk/jdk/pull/17742 Thanks, Prajwal

Re: [External] : Re: PEM API github repo

2024-03-12 Thread Karl Scheibelhofer
... try again from from my subscribed mail account... Hi Tony, > > in my jdk fork, I created a branch named pem-feedback-karl. > > https://github.com/KarlScheibelhofer/jdk/tree/pem-feedback-karl > > It is based on the pem branch of your jdk fork. > In this pem-feedback-karl branch, I did some clea

Integrated: 8312444: Delete unused parameters and variables in SocketPermission

2024-03-12 Thread Korov
On Fri, 1 Mar 2024 17:35:35 GMT, Korov wrote: > Removing unused parameter `defval` in `SocketPermission.initEphemeralPorts`, > so the variable `PRIV_PORT_MAX` and `DEF_EPH_LOW` unused too. > > Removing unused parameter `cname` in `SocketPermission.authorizedIPv4` and > `SocketPermission.author