Re: RFR: 8312444: Delete unused parameters and variables in SocketPermission [v2]

2024-03-02 Thread Korov
On Sat, 2 Mar 2024 13:00:21 GMT, Andrey Turbanov wrote: >> Korov has updated the pull request incrementally with one additional commit >> since the last revision: >> >> Modiy the code accordingto the review > > src/java.base/share/classes/java/net/SocketPermission.java line 707: > >> 705:

Re: RFR: 8312444: Delete unused parameters and variables in SocketPermission

2024-03-02 Thread Korov
On Sat, 2 Mar 2024 13:02:58 GMT, Andrey Turbanov wrote: >> Removing unused parameter `defval` in `SocketPermission.initEphemeralPorts`, >> so the variable `PRIV_PORT_MAX` and `DEF_EPH_LOW` unused too. >> >> Removing unused parameter `cname` in `SocketPermission.authorizedIPv4` and >> `SocketPe

Re: RFR: 8312444: Delete unused parameters and variables in SocketPermission [v2]

2024-03-02 Thread Korov
> Removing unused parameter `defval` in `SocketPermission.initEphemeralPorts`, > so the variable `PRIV_PORT_MAX` and `DEF_EPH_LOW` unused too. > > Removing unused parameter `cname` in `SocketPermission.authorizedIPv4` and > `SocketPermission.authorizedIPv6`. > > Parameter 'action' must be not e

Re: RFR: 8312444: Delete unused parameters and variables in SocketPermission

2024-03-02 Thread Andrey Turbanov
On Fri, 1 Mar 2024 17:35:35 GMT, Korov wrote: > Removing unused parameter `defval` in `SocketPermission.initEphemeralPorts`, > so the variable `PRIV_PORT_MAX` and `DEF_EPH_LOW` unused too. > > Removing unused parameter `cname` in `SocketPermission.authorizedIPv4` and > `SocketPermission.author

Re: RFR: 8312444: Delete unused parameters and variables in SocketPermission

2024-03-02 Thread Korov
On Sat, 2 Mar 2024 11:35:29 GMT, Guoxiong Li wrote: > > Hello @lgxbslgx , the title has been changed, Can you check if it's > > suitable? > > Seems good. If nobody disagrees such mixed patch, I will help you change the > title and content of the issue. Thanks so much. - PR Comme

Re: RFR: 8312444: Delete unused parameters and variables in SocketPermission

2024-03-02 Thread Guoxiong Li
On Sat, 2 Mar 2024 08:54:44 GMT, Guoxiong Li wrote: >> Removing unused parameter `defval` in `SocketPermission.initEphemeralPorts`, >> so the variable `PRIV_PORT_MAX` and `DEF_EPH_LOW` unused too. >> >> Removing unused parameter `cname` in `SocketPermission.authorizedIPv4` and >> `SocketPermis

Re: RFR: 8312444: Delete unused parameters and variables in SocketPermission

2024-03-02 Thread Korov
On Sat, 2 Mar 2024 08:54:44 GMT, Guoxiong Li wrote: > The patch looks good. But the title of this issue may need to be adjusted, > because you not only change the `SocketPermission.initEphemeralPorts` but > also change other code. Or you can separate the unrelated code to another > issue. Hel

Re: RFR: 8312444: Unused parameter 'defval' in SocketPermission.initEphemeralPorts could be removed

2024-03-02 Thread Guoxiong Li
On Fri, 1 Mar 2024 17:35:35 GMT, Korov wrote: > Removing unused parameter `defval` in `SocketPermission.initEphemeralPorts`, > so the variable `PRIV_PORT_MAX` and `DEF_EPH_LOW` unused too. > > Removing unused parameter `cname` in `SocketPermission.authorizedIPv4` and > `SocketPermission.author