On Mon, 26 Feb 2024 22:33:03 GMT, Weijun Wang wrote:
> Add a `memset` after memory is successfully allocated.
>
> No regression test, hard to write without a KDC.
This pull request has now been integrated.
Changeset: 419191c6
Author:Weijun Wang
URL:
https://git.openjdk.org/jdk/comm
> Add a `memset` after memory is successfully allocated.
>
> No regression test, hard to write without a KDC.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
add back 2 lines
-
Changes:
- all: https://git.openjdk.org/j
On Tue, 27 Feb 2024 21:09:04 GMT, Weijun Wang wrote:
>> Add a `memset` after memory is successfully allocated.
>>
>> No regression test, hard to write without a KDC.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> no need t
On Tue, 27 Feb 2024 19:17:37 GMT, Rajan Halade wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use calloc
>
> src/java.security.jgss/share/native/libj2gss/GSSLibStub.c line 199:
>
>> 197: }
>> 198:
>> 199: cb
> Add a `memset` after memory is successfully allocated.
>
> No regression test, hard to write without a KDC.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
no need to zero again for some fields
-
Changes:
- all: http
On Tue, 27 Feb 2024 17:08:54 GMT, Weijun Wang wrote:
>> Add a `memset` after memory is successfully allocated.
>>
>> No regression test, hard to write without a KDC.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> use callo
On Tue, 27 Feb 2024 17:08:54 GMT, Weijun Wang wrote:
>> Add a `memset` after memory is successfully allocated.
>>
>> No regression test, hard to write without a KDC.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> use callo
On Tue, 27 Feb 2024 17:08:54 GMT, Weijun Wang wrote:
>> Add a `memset` after memory is successfully allocated.
>>
>> No regression test, hard to write without a KDC.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> use callo
On Tue, 27 Feb 2024 17:08:54 GMT, Weijun Wang wrote:
>> Add a `memset` after memory is successfully allocated.
>>
>> No regression test, hard to write without a KDC.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> use callo
> Add a `memset` after memory is successfully allocated.
>
> No regression test, hard to write without a KDC.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
use calloc
-
Changes:
- all: https://git.openjdk.org/jdk/pul
On Tue, 27 Feb 2024 16:36:42 GMT, Mark Powers wrote:
> Why do you have to set memory to zero? If you really need to, `calloc()` sets
> memory to zero.
Inside `newGSSCB`, if there is anything wrong before `cb->application_data` is
initialized, `deleteGSSCB` will be called and it has
if (cb->
On Mon, 26 Feb 2024 22:33:03 GMT, Weijun Wang wrote:
> Add a `memset` after memory is successfully allocated.
>
> No regression test, hard to write without a KDC.
Why do you have to set memory to zero?
If you really need to, `calloc()` sets memory to zero.
-
PR Comment: https://gi
On Tue, 27 Feb 2024 15:08:11 GMT, Eirik Bjørsnøs wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address initial feedback for JDK-8326687
>
> src/java.base/share/classes/java/util/zip/ZipOutputStream.java line 54
> This PR updates the javadoc and comments within java.util.zip/jar and zipfs
> module summary so that it is consistent with the use of "ZIP".
>
> In addition, open/src/java.base/share/classes/java/util/zip/package-info.java
> has been updated to point to the higher level location of the PKWARE
On Tue, 27 Feb 2024 16:12:03 GMT, Lance Andersen wrote:
>> This PR updates the javadoc and comments within java.util.zip/jar and zipfs
>> module summary so that it is consistent with the use of "ZIP".
>>
>> In addition,
>> open/src/java.base/share/classes/java/util/zip/package-info.java has be
On Mon, 26 Feb 2024 19:55:47 GMT, Lance Andersen wrote:
> This PR updates the javadoc and comments within java.util.zip/jar and zipfs
> module summary so that it is consistent with the use of "ZIP".
>
> In addition, open/src/java.base/share/classes/java/util/zip/package-info.java
> has been up
On Mon, 26 Feb 2024 19:55:47 GMT, Lance Andersen wrote:
> This PR updates the javadoc and comments within java.util.zip/jar and zipfs
> module summary so that it is consistent with the use of "ZIP".
>
> In addition, open/src/java.base/share/classes/java/util/zip/package-info.java
> has been up
Add a `memset` after memory is successfully allocated.
No regression test, hard to write without a KDC.
-
Commit messages:
- the fix
Changes: https://git.openjdk.org/jdk/pull/18015/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18015&range=00
Issue: https://bugs.openjdk.
On Mon, 26 Feb 2024 18:04:18 GMT, Hai-May Chao wrote:
> Nit: Copyright year of IterationCount.java would need to be changed.
That is a Red Hat copyright; should I add an Oracle copyright? The file isn't
significantly changed.
-
PR Comment: https://git.openjdk.org/jdk/pull/17877#is
On Mon, 26 Feb 2024 19:55:47 GMT, Lance Andersen wrote:
> This PR updates the javadoc and comments within java.util.zip/jar and zipfs
> module summary so that it is consistent with the use of "ZIP".
>
> In addition, open/src/java.base/share/classes/java/util/zip/package-info.java
> has been up
20 matches
Mail list logo
