On Thu, 15 Feb 2024 22:32:58 GMT, Christoph Langer wrote:
> The experimental SunJSSE FIPS compliant mode was removed in JDK13 with
> [JDK-8217835](https://bugs.openjdk.org/browse/JDK-8217835).
> It seems the removal of some comments had been missed at that time. This
> could be irritating to re
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
> chan
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
> chan
The experimental SunJSSE FIPS compliant mode was removed in JDK13 with
[JDK-8217835](https://bugs.openjdk.org/browse/JDK-8217835).
It seems the removal of some comments had been missed at that time. This could
be irritating to readers of the code.
-
Commit messages:
- JDK-8326000
On Thu, 15 Feb 2024 18:19:25 GMT, Rajan Halade wrote:
> This PR is to add two new TLS root certificates from Certainly. This CA has
> gone through
> https://www.oracle.com/java/technologies/javase/carootcertsprogram.html
> process.
>
>
> The release-note is at
> [JDK-8325903](https://bugs.o
On Thu, 15 Feb 2024 18:28:08 GMT, Matthew Donovan wrote:
>> In this PR I updated the tests to use the newer
>> ProcessTools.createTestJavaProcessBuilder() methods to launch child
>> processes. This method ensures that VM options are passed to subprocesses.
>
> Matthew Donovan has updated the pu
On Thu, 15 Feb 2024 18:19:25 GMT, Rajan Halade wrote:
> This PR is to add two new TLS root certificates from Certainly. This CA has
> gone through
> https://www.oracle.com/java/technologies/javase/carootcertsprogram.html
> process.
>
>
> The release-note is at
> [JDK-8325903](https://bugs.o
> In this PR I updated the tests to use the newer
> ProcessTools.createTestJavaProcessBuilder() methods to launch child
> processes. This method ensures that VM options are passed to subprocesses.
Matthew Donovan has updated the pull request incrementally with one additional
commit since the la
This PR is to add two new TLS root certificates from Certainly. This CA has
gone through
https://www.oracle.com/java/technologies/javase/carootcertsprogram.html process.
The release-note is at
[JDK-8325903](https://bugs.openjdk.org/browse/JDK-8325903)
-
Commit messages:
- 832140
On Thu, 15 Feb 2024 17:28:52 GMT, Andy Goryachev wrote:
>> Please do not replace those tabs with spaces as they are intentional for
>> testing the runtime to safely ignore them. I suggest replacing them with
>> Unicode escapes (`\u000b`)
>
> `\u000b` is VT (vertical tab)
> `\u0009` or `\t`
On Thu, 15 Feb 2024 17:09:17 GMT, Naoto Sato wrote:
>> All the java/util/Currency tests pass. I also searched the code for "ZZ" but
>> could not find any references in the test.
>
> Please do not replace those tabs with spaces as they are intentional for
> testing the runtime to safely ignore t
On Thu, 15 Feb 2024 15:48:38 GMT, Magnus Ihse Bursie wrote:
>> This looks weird indeed. Luckily it's just test code. Did you run the test
>> after this change?
>
> All the java/util/Currency tests pass. I also searched the code for "ZZ" but
> could not find any references in the test.
Please d
In this PR I updated the tests to use the newer
ProcessTools.createTestJavaProcessBuilder() methods to launch child processes.
This method ensures that VM options are passed to subprocesses.
-
Commit messages:
- 8319673: Few security tests ignore VM flags
Changes: https://git.open
On Thu, 15 Feb 2024 14:01:46 GMT, Erik Joelsson wrote:
>> test/jdk/java/util/Currency/currency.properties line 18:
>>
>>> 16: SB=EUR,111,2, 2099-01-01T00:00:00
>>> 17: US=euR,978,2,2001-01-01T00:00:00
>>> 18: ZZ = ZZZ , 999 , 3
>>
>> This looks weird, but so did t
On Thu, 15 Feb 2024 12:26:11 GMT, Magnus Ihse Bursie wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us
>> getting files in the repository that would not be accepted by jcheck. This
>> can happen when extending the set of files checked by jcheck, or if jcheck
>>
On Thu, 15 Feb 2024 12:44:10 GMT, Daniel Fuchs wrote:
>> Hello Darragh, Daniel,
>>
>> As for introducing a new method on `ProcessTools` class, I don't know if
>> it's needed - I feel that the `ProcessTools` class is already getting too
>> complex because of the various similarly named methods.
On Thu, 15 Feb 2024 12:04:27 GMT, Jaikiran Pai wrote:
>> That's not a bad idea. What I would recommend in that case would be to not
>> do anything here - but rather log another issue against
>> `ProcessTools.createTestJavaProcessBuilder`.
>> Then proceed with this PR without changing anything.
Since jcheck only checks file in a commit, there is a possibility of us getting
files in the repository that would not be accepted by jcheck. This can happen
when extending the set of files checked by jcheck, or if jcheck changes how it
checks files (perhaps due to bug fixes).
I have now run jc
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
> chan
On Mon, 12 Feb 2024 12:51:50 GMT, Daniel Fuchs wrote:
>> Would it be possible to change the `createJavaProcessBuilder` method in
>> ProcessTools to include something to check if -cp is already an argument
>> being passed?
>>
>> maybe something like this?
>>
>>
>> if (!noCP && !args.contains(
On Fri, 9 Feb 2024 11:38:07 GMT, Darragh Clarke wrote:
> Currently these tests ignore vm flags, In most cases I've updated them to use
> `ProcessTools.createTestJavaProcessBuilder` this usually required some
> cleanup also.
>
> `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java
The reported leak was caused by the death of the `Cleanup-SunPKCS11` thread.
The cleanup thread in turn died because of an exception thrown from
`removeNativeKey` that resulted from 2 threads executing that method at the
same time.
This PR adds a reachabilityFence to ensure that the key will on
On Tue, 13 Feb 2024 20:58:17 GMT, Daniel Jeliński wrote:
>> Currently we have 2 GCMParameters classes in java.base, one in
>> sun.security.util package, the other in com.sun.crypto.provider.
>>
>> This PR merges the changes from the sun.security.util copy into
>> com.sun.crypto.provider, and r
On Mon, 12 Feb 2024 08:34:24 GMT, Daniel Jeliński wrote:
> Currently we have 2 GCMParameters classes in java.base, one in
> sun.security.util package, the other in com.sun.crypto.provider.
>
> This PR merges the changes from the sun.security.util copy into
> com.sun.crypto.provider, and remove
On 14 Feb 2024, at 14:43, Alexey Bakhtin wrote:
> This functionality is under review now at
> https://github.com/openjdk/jdk/pull/16722
> This patch proposes access to the MacOS trust store using new java
> KeychainStore-Root keystore.
> Feel free to review and comment.
This is excellent news.
25 matches
Mail list logo
