Re: RFR: 8325162: Remove duplicate GCMParameters class [v2]

2024-02-14 Thread Valerie Peng
On Tue, 13 Feb 2024 20:58:17 GMT, Daniel Jeliński wrote: >> Currently we have 2 GCMParameters classes in java.base, one in >> sun.security.util package, the other in com.sun.crypto.provider. >> >> This PR merges the changes from the sun.security.util copy into >> com.sun.crypto.provider, and r

Re: RFR: 8325162: Remove duplicate GCMParameters class [v2]

2024-02-14 Thread Valerie Peng
On Tue, 13 Feb 2024 20:58:17 GMT, Daniel Jeliński wrote: >> Currently we have 2 GCMParameters classes in java.base, one in >> sun.security.util package, the other in com.sun.crypto.provider. >> >> This PR merges the changes from the sun.security.util copy into >> com.sun.crypto.provider, and r

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-14 Thread Daniel Fuchs
On Fri, 9 Feb 2024 11:38:07 GMT, Darragh Clarke wrote: > Currently these tests ignore vm flags, In most cases I've updated them to use > `ProcessTools.createTestJavaProcessBuilder` this usually required some > cleanup also. > > `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java

Re: Apple KeychainStore: Can it be used to access the MacOS trust store?

2024-02-14 Thread Alexey Bakhtin
Hello Graham, This functionality is under review now at https://github.com/openjdk/jdk/pull/16722 This patch proposes access to the MacOS trust store using new java KeychainStore-Root keystore. Feel free to review and comment. Regards Aleksei > On 14 Feb 2024, at 02:16, Graham Leggett wrote:

Apple KeychainStore: Can it be used to access the MacOS trust store?

2024-02-14 Thread Graham Leggett
Hi all, I am trying to make life easier for Apple and Windows users by providing functionality to use Window-MY and Windows-ROOT, however I got stuck with KeychainStore. keyStore = KeyStore.getInstance("KeychainStore", "Apple"); keyStore.load(null, null); keyManagerFactory = KeyManagerFactory .

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-14 Thread Andrey Turbanov
On Fri, 9 Feb 2024 11:38:07 GMT, Darragh Clarke wrote: > Currently these tests ignore vm flags, In most cases I've updated them to use > `ProcessTools.createTestJavaProcessBuilder` this usually required some > cleanup also. > > `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java