Re: RFR: JDK-8311644 Server should not send bad_certificate alert when the client does not send any certificates

2024-02-12 Thread Daniel Jeliński
On Tue, 6 Feb 2024 01:23:00 GMT, Anthony Scarpino wrote: > Hi, > > I need a code review of what is really a text change. This changes the alert > type returned during some TLS CertificateMessage failures to what is > recommended in [RFC 8446](https://tools.ietf.org/html/rfc8446). An > addit

Re: RFR: JDK-8311644 Server should not send bad_certificate alert when the client does not send any certificates

2024-02-12 Thread Sibabrata Sahoo
On Tue, 6 Feb 2024 01:23:00 GMT, Anthony Scarpino wrote: > Hi, > > I need a code review of what is really a text change. This changes the alert > type returned during some TLS CertificateMessage failures to what is > recommended in [RFC 8446](https://tools.ietf.org/html/rfc8446). An > addit

RFR: 8325164: Named groups and signature schemes unavailable with SunPKCS11 in FIPS mode

2024-02-12 Thread Daniel Jeliński
Currently the SunPKCS11 provider requires other providers in order to offer ECDHE, FFDHE and RSA-PSS in TLS handshakes: - FFDHE requires DiffieHellman AlgorithmParameters from SunJCE - ECDHE requires the SunEC provider to be installed - RSA-PSS requires RSASSA-PSS AlgorithmParameters from SunRsaSi

RFR: JDK-8311644 Server should not send bad_certificate alert when the client does not send any certificates

2024-02-12 Thread Anthony Scarpino
Hi, I need a code review of what is really a text change. This changes the alert type returned during some TLS CertificateMessage failures to what is recommended in [RFC 8446](https://tools.ietf.org/html/rfc8446). An additional change was to add the alert description to the thrown exception.

Re: RFR: 8325558: Add jcheck whitespace checking for properties files

2024-02-12 Thread Joe Wang
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote: > This is an attempt to finally implement the idea brought forward in > JDK-8295729: Properties files is essentially source code. It should have the > same whitespace checks as all other source code, so we don't get spurious > trailin

Re: RFR: 8325558: Add jcheck whitespace checking for properties files

2024-02-12 Thread Joe Wang
On Fri, 9 Feb 2024 13:46:06 GMT, Magnus Ihse Bursie wrote: >> This is an attempt to finally implement the idea brought forward in >> JDK-8295729: Properties files is essentially source code. It should have >> the same whitespace checks as all other source code, so we don't get >> spurious tra

Re: RFR: 8325558: Add jcheck whitespace checking for properties files

2024-02-12 Thread Daniel Fuchs
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote: > This is an attempt to finally implement the idea brought forward in > JDK-8295729: Properties files is essentially source code. It should have the > same whitespace checks as all other source code, so we don't get spurious > trailin

Re: RFR: 8325558: Add jcheck whitespace checking for properties files

2024-02-12 Thread Naoto Sato
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote: > This is an attempt to finally implement the idea brought forward in > JDK-8295729: Properties files is essentially source code. It should have the > same whitespace checks as all other source code, so we don't get spurious > trailin

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-12 Thread Daniel Fuchs
On Mon, 12 Feb 2024 10:58:45 GMT, Darragh Clarke wrote: >> test/jdk/java/net/URLClassLoader/getresourceasstream/TestDriver.java line 63: >> >>> 61: ), >>> 62: ProcessTools.createTestJavaProcessBuilder( >>> 63: "-cp", ".", >> >> If I'm not

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-12 Thread Darragh Clarke
On Fri, 9 Feb 2024 12:48:48 GMT, Daniel Fuchs wrote: >> Currently these tests ignore vm flags, In most cases I've updated them to >> use `ProcessTools.createTestJavaProcessBuilder` this usually required some >> cleanup also. >> >> `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.j

RFR: 8325162: Remove duplicate GCMParameters class

2024-02-12 Thread Daniel Jeliński
Currently we have 2 GCMParameters classes in java.base, one in sun.security.util package, the other in com.sun.crypto.provider. This PR merges the changes from the sun.security.util copy into com.sun.crypto.provider, and removes the sun.security.util class. As far as I could tell, the sun.secur

Re: RFR: 8325558: Add jcheck whitespace checking for properties files

2024-02-12 Thread Magnus Ihse Bursie
On Fri, 9 Feb 2024 18:09:11 GMT, Naoto Sato wrote: >> This is an attempt to finally implement the idea brought forward in >> JDK-8295729: Properties files is essentially source code. It should have >> the same whitespace checks as all other source code, so we don't get >> spurious trailing wh