Re: RFR: 8265372: Simplify PKCS9Attribute [v8]

2024-02-09 Thread Weijun Wang
On Wed, 31 Jan 2024 20:47:20 GMT, Ben Perez wrote: >> Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The >> key for the hash map is an `ObjectIdentifier` and the values are a record >> `AttributeInfo` that stores the information previously contained in the >> arrays `P

Re: RFR: 8325558: Add jcheck whitespace checking for properties files

2024-02-09 Thread Naoto Sato
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote: > This is an attempt to finally implement the idea brought forward in > JDK-8295729: Properties files is essentially source code. It should have the > same whitespace checks as all other source code, so we don't get spurious > trailin

Re: RFR: 8325558: Add jcheck whitespace checking for properties files

2024-02-09 Thread Erik Joelsson
On Fri, 9 Feb 2024 13:42:02 GMT, Magnus Ihse Bursie wrote: >> This is an attempt to finally implement the idea brought forward in >> JDK-8295729: Properties files is essentially source code. It should have >> the same whitespace checks as all other source code, so we don't get >> spurious tra

Integrated: 8324646: Avoid Class.forName in SecureRandom constructor

2024-02-09 Thread Oli Gillespie
On Wed, 24 Jan 2024 15:25:28 GMT, Oli Gillespie wrote: > Avoid expensive `Class.forName` call when constructing Providers such as > `SecureRandom` which take constructor parameters. This can easily be cached > in EngineDescription (this cache already existed before, it was removed in > [JDK-82

Integrated: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG

2024-02-09 Thread Oli Gillespie
On Wed, 24 Jan 2024 15:42:05 GMT, Oli Gillespie wrote: > A typical call to `new SecureRandom()` is slowed down by looking for a > constructor in NativePRNG which takes `java.security.SecureRandomParameters`. > NativePRNG does not have such a constructor, so the search fails > [here](https://gi

Re: RFR: 8324646: Avoid Class.forName in SecureRandom constructor [v4]

2024-02-09 Thread Oli Gillespie
On Tue, 6 Feb 2024 13:52:09 GMT, Oli Gillespie wrote: >> Avoid expensive `Class.forName` call when constructing Providers such as >> `SecureRandom` which take constructor parameters. This can easily be cached >> in EngineDescription (this cache already existed before, it was removed in >> [JDK

Re: RFR: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG [v4]

2024-02-09 Thread Oli Gillespie
On Wed, 7 Feb 2024 09:49:10 GMT, Oli Gillespie wrote: >> A typical call to `new SecureRandom()` is slowed down by looking for a >> constructor in NativePRNG which takes >> `java.security.SecureRandomParameters`. NativePRNG does not have such a >> constructor, so the search fails >> [here](htt

Re: RFR: 8325558: Add jcheck whitespace checking for properties files

2024-02-09 Thread Daniel Fuchs
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote: > This is an attempt to finally implement the idea brought forward in > JDK-8295729: Properties files is essentially source code. It should have the > same whitespace checks as all other source code, so we don't get spurious > trailin

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-09 Thread Daniel Fuchs
On Fri, 9 Feb 2024 11:38:07 GMT, Darragh Clarke wrote: > Currently these tests ignore vm flags, In most cases I've updated them to use > `ProcessTools.createTestJavaProcessBuilder` this usually required some > cleanup also. > > `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java

Re: RFR: 8325558: Add jcheck whitespace checking for properties files

2024-02-09 Thread Magnus Ihse Bursie
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote: > This is an attempt to finally implement the idea brought forward in > JDK-8295729: Properties files is essentially source code. It should have the > same whitespace checks as all other source code, so we don't get spurious > trailin

Re: RFR: 8325558: Add jcheck whitespace checking for properties files

2024-02-09 Thread Magnus Ihse Bursie
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote: > This is an attempt to finally implement the idea brought forward in > JDK-8295729: Properties files is essentially source code. It should have the > same whitespace checks as all other source code, so we don't get spurious > trailin

RFR: 8325558: Add jcheck whitespace checking for properties files

2024-02-09 Thread Magnus Ihse Bursie
This is an attempt to finally implement the idea brought forward in JDK-8295729: Properties files is essentially source code. It should have the same whitespace checks as all other source code, so we don't get spurious trailing whitespace changes or leading tabs instead of spaces. With Skara

RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-09 Thread Darragh Clarke
Currently these tests ignore vm flags, In most cases I've updated them to use `ProcessTools.createTestJavaProcessBuilder` this usually required some cleanup also. `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java` and `test/jdk/java/net/URLConnection/6212146/TestDriver.java` ha