During the time of server certificate validation, users have the flexibility to
use a custom X509 Key Manager implementation by extending
"X509ExtendedKeyManager.".
In such cases, printing the class name in X509Authentication.java will be
helpful to trace any failure of the SSL connection due to
On Wed, 7 Feb 2024 01:52:06 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which updates the javadoc
>> of several classes in `java.util.jar` and `java.util.zip` to specify their
>> behaviour when `null` arguments are passed to the constructor or methods of
>> th
> Can I please get a review of this doc-only change which updates the javadoc
> of several classes in `java.util.jar` and `java.util.zip` to specify their
> behaviour when `null` arguments are passed to the constructor or methods of
> those classes?
>
> For these updated classes, I have individ
> Can I please get a review of this doc-only change which updates the javadoc
> of several classes in `java.util.jar` and `java.util.zip` to specify their
> behaviour when `null` arguments are passed to the constructor or methods of
> those classes?
>
> For these updated classes, I have individ
On Mon, 5 Feb 2024 18:23:30 GMT, Martin Balao wrote:
> Hi,
>
> May I have a review for this fix to
> [JDK-8325254](https://bugs.openjdk.org/browse/JDK-8325254)?
>
> With this change, CKA_TOKEN = true is used as an indicator of a sensitive
> private key (opaque) only if the token is NSS. The b
On Tue, 6 Feb 2024 18:32:58 GMT, Valerie Peng wrote:
>> Hi,
>>
>> May I have a review for this fix to
>> [JDK-8325254](https://bugs.openjdk.org/browse/JDK-8325254)?
>>
>> With this change, CKA_TOKEN = true is used as an indicator of a sensitive
>> private key (opaque) only if the token is NSS
On Tue, 6 Feb 2024 13:54:10 GMT, Oli Gillespie wrote:
>> A typical call to `new SecureRandom()` is slowed down by looking for a
>> constructor in NativePRNG which takes
>> `java.security.SecureRandomParameters`. NativePRNG does not have such a
>> constructor, so the search fails
>> [here](htt
On Mon, 5 Feb 2024 18:23:30 GMT, Martin Balao wrote:
> Hi,
>
> May I have a review for this fix to
> [JDK-8325254](https://bugs.openjdk.org/browse/JDK-8325254)?
>
> With this change, CKA_TOKEN = true is used as an indicator of a sensitive
> private key (opaque) only if the token is NSS. The b
On Tue, 6 Feb 2024 13:54:10 GMT, Oli Gillespie wrote:
>> A typical call to `new SecureRandom()` is slowed down by looking for a
>> constructor in NativePRNG which takes
>> `java.security.SecureRandomParameters`. NativePRNG does not have such a
>> constructor, so the search fails
>> [here](htt
On Tue, 6 Feb 2024 17:09:26 GMT, Mark Powers wrote:
>> Hi,
>>
>> May I have a review for this fix to
>> [JDK-8325254](https://bugs.openjdk.org/browse/JDK-8325254)?
>>
>> With this change, CKA_TOKEN = true is used as an indicator of a sensitive
>> private key (opaque) only if the token is NSS.
On Tue, 6 Feb 2024 17:29:25 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/sun/net/www/MessageHeader.java line 53:
>>
>>> 51: }
>>> 52:
>>> 53: @SuppressWarnings("this-escape")
>>
>> An alternative here could be to make the class final. AFAICS it's not
>> subclassed anywhere. If
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the warni
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the warni
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the warni
On Tue, 6 Feb 2024 14:35:52 GMT, Daniel Fuchs wrote:
>> After the "this-escape" lint warning was added to javac (JDK-8015831), the
>> base module was not updated to be able to compile with this warning enabled.
>> This PR makes the necessary changes to allow the base module to build with
>> th
On Mon, 5 Feb 2024 18:23:30 GMT, Martin Balao wrote:
> Hi,
>
> May I have a review for this fix to
> [JDK-8325254](https://bugs.openjdk.org/browse/JDK-8325254)?
>
> With this change, CKA_TOKEN = true is used as an indicator of a sensitive
> private key (opaque) only if the token is NSS. The b
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the warni
> A typical call to `new SecureRandom()` is slowed down by looking for a
> constructor in NativePRNG which takes `java.security.SecureRandomParameters`.
> NativePRNG does not have such a constructor, so the search fails
> [here](https://github.com/openjdk/jdk/blob/master/src/java.base/share/clas
> Avoid expensive `Class.forName` call when constructing Providers such as
> `SecureRandom` which take constructor parameters. This can easily be cached
> in EngineDescription (this cache already existed before, it was removed in
> [JDK-8280970](https://bugs.openjdk.org/browse/JDK-8280970) as un
On Tue, 6 Feb 2024 10:41:55 GMT, Oli Gillespie wrote:
>> A typical call to `new SecureRandom()` is slowed down by looking for a
>> constructor in NativePRNG which takes
>> `java.security.SecureRandomParameters`. NativePRNG does not have such a
>> constructor, so the search fails
>> [here](htt
On Thu, 1 Feb 2024 10:39:27 GMT, Oli Gillespie wrote:
>> Avoid expensive `Class.forName` call when constructing Providers such as
>> `SecureRandom` which take constructor parameters. This can easily be cached
>> in EngineDescription (this cache already existed before, it was removed in
>> [JDK
On Thu, 1 Feb 2024 10:39:27 GMT, Oli Gillespie wrote:
>> Avoid expensive `Class.forName` call when constructing Providers such as
>> `SecureRandom` which take constructor parameters. This can easily be cached
>> in EngineDescription (this cache already existed before, it was removed in
>> [JDK
On Tue, 6 Feb 2024 12:30:10 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which updates the javadoc
>> of several classes in `java.util.jar` and `java.util.zip` to specify their
>> behaviour when `null` arguments are passed to the constructor or methods of
>> th
On Tue, 6 Feb 2024 12:30:10 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which updates the javadoc
>> of several classes in `java.util.jar` and `java.util.zip` to specify their
>> behaviour when `null` arguments are passed to the constructor or methods of
>> th
> Can I please get a review of this doc-only change which updates the javadoc
> of several classes in `java.util.jar` and `java.util.zip` to specify their
> behaviour when `null` arguments are passed to the constructor or methods of
> those classes?
>
> For these updated classes, I have individ
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the warni
On Thu, 1 Feb 2024 10:39:27 GMT, Oli Gillespie wrote:
>> Avoid expensive `Class.forName` call when constructing Providers such as
>> `SecureRandom` which take constructor parameters. This can easily be cached
>> in EngineDescription (this cache already existed before, it was removed in
>> [JDK
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
> bin/blessed-modifier-order.sh on the entire code base, and manually checked
> the result. I have reverted all but these trivial and
On Tue, 6 Feb 2024 10:31:06 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which updates the javadoc
>> of several classes in `java.util.jar` and `java.util.zip` to specify their
>> behaviour when `null` arguments are passed to the constructor or methods of
>> th
On Wed, 24 Jan 2024 15:42:05 GMT, Oli Gillespie wrote:
> A typical call to `new SecureRandom()` is slowed down by looking for a
> constructor in NativePRNG which takes `java.security.SecureRandomParameters`.
> NativePRNG does not have such a constructor, so the search fails
> [here](https://gi
> A typical call to `new SecureRandom()` is slowed down by looking for a
> constructor in NativePRNG which takes `java.security.SecureRandomParameters`.
> NativePRNG does not have such a constructor, so the search fails
> [here](https://github.com/openjdk/jdk/blob/master/src/java.base/share/clas
> Can I please get a review of this doc-only change which updates the javadoc
> of several classes in `java.util.jar` and `java.util.zip` to specify their
> behaviour when `null` arguments are passed to the constructor or methods of
> those classes?
>
> For these updated classes, I have individ
On Tue, 6 Feb 2024 10:05:52 GMT, Jaikiran Pai wrote:
> Can I please get a review of this doc-only change which updates the javadoc
> of several classes in `java.util.jar` and `java.util.zip` to specify their
> behaviour when `null` arguments are passed to the constructor or methods of
> those
Can I please get a review of this doc-only change which updates the javadoc of
several classes in `java.util.jar` and `java.util.zip` to specify their
behaviour when `null` arguments are passed to the constructor or methods of
those classes?
For these updated classes, I have individually checke
34 matches
Mail list logo