Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v9]

2024-01-19 Thread Daniel JeliƄski
On Fri, 19 Jan 2024 01:57:40 GMT, Julian Waters wrote: >> I regret not actually addressing the issues with the goto labels in >> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in >> sspi were jumped over by gotos to a certain label. I changed the >> initializations i

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v9]

2024-01-19 Thread Weijun Wang
On Fri, 19 Jan 2024 01:57:40 GMT, Julian Waters wrote: >> I regret not actually addressing the issues with the goto labels in >> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in >> sspi were jumped over by gotos to a certain label. I changed the >> initializations i

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v7]

2024-01-19 Thread Weijun Wang
On Fri, 19 Jan 2024 01:37:18 GMT, Julian Waters wrote: >> src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp line 422: >> >>> 420: gss_name_struct* name = new gss_name_struct; >>> 421: if (name == nullptr) { >>> 422: goto err; >> >> Go back? This looks more evil to me

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v9]

2024-01-19 Thread Julian Waters
On Fri, 19 Jan 2024 17:31:27 GMT, Weijun Wang wrote: > The code change looks better. Can you show me where I can add this compiler > switch so that I can try it myself a little? Hm? I'm not too sure what compiler switch you are referring to - PR Comment: https://git.openjdk.org/jd

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v9]

2024-01-19 Thread Weijun Wang
On Fri, 19 Jan 2024 01:57:40 GMT, Julian Waters wrote: >> I regret not actually addressing the issues with the goto labels in >> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in >> sspi were jumped over by gotos to a certain label. I changed the >> initializations i