Re: RFR: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" [v3]

2024-01-17 Thread Rajan Halade
On Wed, 17 Jan 2024 19:51:39 GMT, Matthew Donovan wrote: >> I was unable to recreate the error but it looks like the problem could >> happen if two instances of the test are run on the same machine. Also, if >> the deleteEntry() calls in the finally block throw an exception, they can >> hide

Re: RFR: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" [v3]

2024-01-17 Thread Matthew Donovan
> I was unable to recreate the error but it looks like the problem could happen > if two instances of the test are run on the same machine. Also, if the > deleteEntry() calls in the finally block throw an exception, they can hide > any exceptions thrown earlier in the test. > > I updated the t

Integrated: JDK-8322100: Fix GCMIncrementByte4 & GCMIncrementDirect4, and increase overlap testing

2024-01-17 Thread Anthony Scarpino
On Thu, 11 Jan 2024 03:26:03 GMT, Anthony Scarpino wrote: > Hi, > > I need a review of a few simple test changes. This fixes a failure with two > manually run AES/GCM tests that depended on another test that changed with > [JDK-8318756](https://bugs.openjdk.org/browse/JDK-8318756). It also

Re: RFR: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" [v2]

2024-01-17 Thread Rajan Halade
On Thu, 11 Jan 2024 18:15:43 GMT, Matthew Donovan wrote: >> I was unable to recreate the error but it looks like the problem could >> happen if two instances of the test are run on the same machine. Also, if >> the deleteEntry() calls in the finally block throw an exception, they can >> hide

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation

2024-01-17 Thread Weijun Wang
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote: > This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367 > > If the process does not have write permissions, the store is opened as > read-only (instead of failing). > > Please note that permissions to use a cert

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation

2024-01-17 Thread rebarbora-mckvak
On Tue, 19 Dec 2023 11:52:01 GMT, rebarbora-mckvak wrote: >> This fixes the defect described at >> https://bugs.openjdk.org/browse/JDK-8313367 >> >> If the process does not have write permissions, the store is opened as >> read-only (instead of failing). >> >> Please note that permissions to

Withdrawn: 4936767: Parameters for MessageDigest

2024-01-17 Thread duke
On Tue, 14 Nov 2023 17:21:53 GMT, Weijun Wang wrote: > Add parameters to `MessageDigest` and introduce new `MessageDigest` > algorithms 'SHAKE128-LEN` and `SHAKE256-LEN` with an integer parameter. This pull request has been closed without being integrated. - PR: https://git.openjd

Re: RFR: 8275338: Add JFR events for notable serialization situations [v15]

2024-01-17 Thread Raffaello Giulietti
On Mon, 15 Jan 2024 14:17:40 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Removed useless event settings in test. I plan to int