[jdk22] Integrated: Merge c7f1c97312f94b6dd6398a5e98dd0c8b63db4c9b

2024-01-16 Thread Henry Jen
On Tue, 16 Jan 2024 16:31:32 GMT, Henry Jen wrote: > CPU24_01 fixes. This pull request has now been integrated. Changeset: b2cc1890 Author:Henry Jen URL: https://git.openjdk.org/jdk22/commit/b2cc1890ff4d2e5404e153ecba5e83f1bcdd6fa7 Stats: 736 lines in 16 files changed: 476 ins;

Re: [jdk22] RFR: Merge c7f1c97312f94b6dd6398a5e98dd0c8b63db4c9b [v2]

2024-01-16 Thread Henry Jen
> CPU24_01 fixes. Henry Jen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. - Changes: - all: https://git.openjdk.org/jdk22/pull/83/files - new: https://git.ope

Integrated: Merge bf7bd9a16c172bcb5ea6b24717a0429e12e2e3d1

2024-01-16 Thread Henry Jen
On Tue, 16 Jan 2024 16:32:27 GMT, Henry Jen wrote: > CPU24_01 fixes. This pull request has now been integrated. Changeset: 2063bb8f Author:Henry Jen URL: https://git.openjdk.org/jdk/commit/2063bb8ffabd6096f547ec6da979cfcf68a56ba3 Stats: 736 lines in 16 files changed: 476 ins; 65

Re: RFR: JDK-8322100: Fix GCMIncrementByte4 & GCMIncrementDirect4, and increase overlap testing

2024-01-16 Thread Jamil Nimeh
On Thu, 11 Jan 2024 03:26:03 GMT, Anthony Scarpino wrote: > Hi, > > I need a review of a few simple test changes. This fixes a failure with two > manually run AES/GCM tests that depended on another test that changed with > [JDK-8318756](https://bugs.openjdk.org/browse/JDK-8318756). It also

Re: [jdk22] RFR: Merge c7f1c97312f94b6dd6398a5e98dd0c8b63db4c9b

2024-01-16 Thread Erik Joelsson
On Tue, 16 Jan 2024 16:31:32 GMT, Henry Jen wrote: > CPU24_01 fixes. Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/83#pullrequestreview-1826185706

Re: RFR: Merge bf7bd9a16c172bcb5ea6b24717a0429e12e2e3d1 [v2]

2024-01-16 Thread Erik Joelsson
On Tue, 16 Jan 2024 19:05:44 GMT, Henry Jen wrote: >> CPU24_01 fixes. > > Henry Jen has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains eight additiona

Integrated: 8320449: ECDHKeyAgreement should validate parameters before using them

2024-01-16 Thread John Jiang
On Thu, 11 Jan 2024 13:33:54 GMT, John Jiang wrote: > ECDHKeyAgreement should validate the parameters before assigning them to the > fields. This pull request has now been integrated. Changeset: 43d2d68d Author:John Jiang URL: https://git.openjdk.org/jdk/commit/43d2d68da5f60cc45c5f

Re: RFR: 8320449: ECDHKeyAgreement should validate parameters before using them [v4]

2024-01-16 Thread John Jiang
On Tue, 16 Jan 2024 18:44:36 GMT, Sean Mullan wrote: >> John Jiang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more check on generateSecret > > Marked as reviewed by mullan (Reviewer). @seanjmullan Thanks for your approval! --

Re: RFR: Merge bf7bd9a16c172bcb5ea6b24717a0429e12e2e3d1 [v2]

2024-01-16 Thread Henry Jen
> CPU24_01 fixes. Henry Jen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision: - Merge branch 'openjdk

Re: RFR: 8320449: ECDHKeyAgreement should validate parameters before using them [v4]

2024-01-16 Thread Sean Mullan
On Tue, 16 Jan 2024 16:42:37 GMT, John Jiang wrote: >> ECDHKeyAgreement should validate the parameters before assigning them to the >> fields. > > John Jiang has updated the pull request incrementally with one additional > commit since the last revision: > > more check on generateSecret Mar

[jdk22] RFR: Merge c7f1c97312f94b6dd6398a5e98dd0c8b63db4c9b

2024-01-16 Thread Henry Jen
CPU24_01 fixes. - Commit messages: - 8317547: Enhance TLS connection support - 8314307: Improve loop handling - 8318588: Windows build failure after JDK-8314468 due to ambiguous call - 8314468: Improve Compiler loops - 8317331: Solaris build failed with "declaration can not follo

RFR: Merge bf7bd9a16c172bcb5ea6b24717a0429e12e2e3d1

2024-01-16 Thread Henry Jen
CPU24_01 fixes. - Commit messages: - 8317547: Enhance TLS connection support - 8314307: Improve loop handling - 8318588: Windows build failure after JDK-8314468 due to ambiguous call - 8314468: Improve Compiler loops - 8317331: Solaris build failed with "declaration can not follo

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v7]

2024-01-16 Thread Weijun Wang
On Wed, 10 Jan 2024 12:53:48 GMT, Julian Waters wrote: >> I regret not actually addressing the issues with the goto labels in >> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in >> sspi were jumped over by gotos to a certain label. I changed the >> initializations i

Re: RFR: 8320449: ECDHKeyAgreement should validate parameters before using them [v4]

2024-01-16 Thread John Jiang
> ECDHKeyAgreement should validate the parameters before assigning them to the > fields. John Jiang has updated the pull request incrementally with one additional commit since the last revision: more check on generateSecret - Changes: - all: https://git.openjdk.org/jdk/pull/17

Re: RFR: 8320449: ECDHKeyAgreement should validate parameters before using them [v3]

2024-01-16 Thread Sean Mullan
On Mon, 15 Jan 2024 03:37:45 GMT, John Jiang wrote: >> ECDHKeyAgreement should validate the parameters before assigning them to the >> fields. > > John Jiang has updated the pull request incrementally with one additional > commit since the last revision: > > Not use JUnit test/jdk/sun/secur