Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v7]

2024-01-15 Thread Julian Waters
On Wed, 10 Jan 2024 12:53:48 GMT, Julian Waters wrote: >> I regret not actually addressing the issues with the goto labels in >> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in >> sspi were jumped over by gotos to a certain label. I changed the >> initializations i

Re: RFR: 8275338: Add JFR events for notable serialization situations [v15]

2024-01-15 Thread Erik Gahlin
On Mon, 15 Jan 2024 14:17:40 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Removed useless event settings in test. Marked as rev

Re: RFR: 8275338: Add JFR events for notable serialization situations [v15]

2024-01-15 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Removed useless event settings in test. - Changes: - all: https://git.openjdk.org/jdk/pull/17129/files - new:

Re: RFR: 8275338: Add JFR events for notable serialization situations [v5]

2024-01-15 Thread Erik Gahlin
On Tue, 19 Dec 2023 17:53:49 GMT, Erik Gahlin wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changes according to reviewer's comments. > >> You mean, in the @description annotation? > > Yes. > @egahlin Ar

Re: RFR: 8275338: Add JFR events for notable serialization situations [v14]

2024-01-15 Thread Raffaello Giulietti
On Wed, 10 Jan 2024 18:56:45 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Small space optimization. Anybody from security wants

Re: RFR: 8275338: Add JFR events for notable serialization situations [v5]

2024-01-15 Thread Raffaello Giulietti
On Tue, 19 Dec 2023 17:53:49 GMT, Erik Gahlin wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changes according to reviewer's comments. > >> You mean, in the @description annotation? > > Yes. @egahlin Are