Hi,
I need a review of a few simple test changes. This fixes a failure with two
manually run AES/GCM tests that depended on another test that changed with
[JDK-8318756](https://bugs.openjdk.org/browse/JDK-8318756). It also adds
testing for overlapping buffers that AES/GCM has, but CC20P1305 n
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote:
> Currently there is a number of functionality that would be interesting to
> have for shared lib load operations in the JDK C code.
> Some examples :
> Events::log_dll_message for hs-err files reporting
> JFR event NativeLibraryLoad
> Th
I was unable to recreate the error but it looks like the problem could happen
if two instances of the test are run on the same machine. Also, if the
deleteEntry() calls in the finally block throw an exception, they can hide any
exceptions thrown earlier in the test.
I updated the test to use r
> Adds serialization misdeclaration events to JFR.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Small space optimization.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17129/files
- new: https://git.op
On Wed, 10 Jan 2024 17:41:41 GMT, Raffaello Giulietti
wrote:
>> The spec is silent about methods being 'native'; it would generally be
>> impractical to implement native methods for these purposes, but a native
>> method can implement the behavior.
>
> @RogerRiggs The checks are agnostic about
On Wed, 10 Jan 2024 16:58:43 GMT, Roger Riggs wrote:
>> I'm not sure that a `native` method is not considered effective by
>> serialization. I have to check.
>
> The spec is silent about methods being 'native'; it would generally be
> impractical to implement native methods for these purposes,
On Wed, 10 Jan 2024 16:55:58 GMT, Roger Riggs wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changes according to reviewers feedback.
>
> src/java.base/share/classes/java/io/SerializationMisdeclarationCheck
On Wed, 10 Jan 2024 16:49:50 GMT, Roger Riggs wrote:
>> Conceptually, these are independent types. There's no logical relationship
>> between them. Sharing a zero length array would convey a false sense of
>> logical sharing.
>
> true, but its wasted space and IMHO ok as a local and private imp
On Tue, 19 Dec 2023 15:58:10 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java
>> line 185:
>>
>>> 183: commitEvent(PRIV_METH_NON_STATIC,
>>> 184: m + " must be non-static to be effective");
>>> 185:
On Wed, 10 Jan 2024 15:43:46 GMT, Raffaello Giulietti
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Changes according to reviewers feedback.
src/java.bas
On Wed, 3 Jan 2024 16:55:39 GMT, Sean Mullan wrote:
> This enhancement simplifies and improves the performance of the Comparator
> that the PKIX CertPathBuilder uses to sort candidate certificates.
>
> [RFC 5280](https://www.rfc-editor.org/rfc/rfc5280#section-4.2.1.1) requires
> that certifica
On Tue, 9 Jan 2024 10:41:31 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java
>> line 53:
>>
>>> 51: private static final Class[] READ_OBJECT_NO_DATA_PARAM_TYPES =
>>> {};
>>> 52: private static final Class[] WRITE_REPLACE_P
On Tue, 9 Jan 2024 10:46:27 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/io/SerializationMisdeclarationChecker.java
>> line 70:
>>
>>> 68: privilegedCheckAccessibleMethod(cl, WRITE_REPLACE_NAME,
>>> 69: WRITE_REPLACE_PARAM_TYPES, Object.cl
> Adds serialization misdeclaration events to JFR.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Changes according to reviewers feedback.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17129/files
- new:
On Wed, 10 Jan 2024 14:58:37 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/math/BigInteger.java line 3998:
>>
>>> 3996: int i = ArraysSupport.mismatch(m1, m2, len1);
>>> 3997: if (i != -1)
>>> 3998: return Integer.compareUnsigned(m1[i], m2[i]) <
On Wed, 10 Jan 2024 14:48:21 GMT, Roger Riggs wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 20 commits:
>>
>> - Use Integer.compareUnsigned
>> - Update copyright years and headers
>> - Merge branch 'mast
On Wed, 10 Jan 2024 11:27:53 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> equals, hashCode, and compareTo for BigInteger. If you have any performance
>> concerns, please raise them.
>>
>> This PR is cherry-picked from a bigger, not-ye
On Wed, 3 Jan 2024 16:55:39 GMT, Sean Mullan wrote:
> This enhancement simplifies and improves the performance of the Comparator
> that the PKIX CertPathBuilder uses to sort candidate certificates.
>
> [RFC 5280](https://www.rfc-editor.org/rfc/rfc5280#section-4.2.1.1) requires
> that certifica
On Tue, 9 Jan 2024 18:31:49 GMT, Daniel Fuchs wrote:
>> Yes, that's perhaps clearer, will do.
>
> Typically in other places in the JDK we use `priviledgedXxx` for naming
> methods that are simple wrappers that call `xxx` from within a
> `doPrivileged`. The method is called privileged because it
> I regret not actually addressing the issues with the goto labels in
> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
> sspi were jumped over by gotos to a certain label. I changed the
> initializations into split declarations and assignments in
> https://github.c
> I regret not actually addressing the issues with the goto labels in
> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
> sspi were jumped over by gotos to a certain label. I changed the
> initializations into split declarations and assignments in
> https://github.c
> I regret not actually addressing the issues with the goto labels in
> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
> sspi were jumped over by gotos to a certain label. I changed the
> initializations into split declarations and assignments in
> https://github.c
> Please review this PR to use modern APIs and language features to simplify
> equals, hashCode, and compareTo for BigInteger. If you have any performance
> concerns, please raise them.
>
> This PR is cherry-picked from a bigger, not-yet-published PR, to test the
> waters. That latter PR will b
23 matches
Mail list logo
