Withdrawn: 8318486: Rename JavaLangAccess.xxNoRepl to xxReportError

2023-12-21 Thread duke
On Thu, 19 Oct 2023 07:04:50 GMT, Chen Liang wrote: > Please review a patch that renames `JavaLangAccess::xxNoRepl` to > `xxReportError` to explicitly indicate these APIs report encoding errors. > > The old "NoRepl" suffix presumably means "No Replacement", but it has been > misunderstood as "

Re: RFR: 8275338: Add JFR events for notable serialization situations [v11]

2023-12-21 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Simplified event messages. Remove ckecker allocation. - Changes: - all: https://git.openjdk.org/jdk/pull/17129

Re: RFR: 8275338: Add JFR events for notable serialization situations [v10]

2023-12-21 Thread Raffaello Giulietti
On Thu, 21 Dec 2023 21:24:43 GMT, Roger Riggs wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Corrected @Label of event and of field. > > src/java.base/share/classes/java/io/ObjectStreamClass.java line 466:

Re: RFR: 8275338: Add JFR events for notable serialization situations [v10]

2023-12-21 Thread Roger Riggs
On Thu, 21 Dec 2023 09:53:10 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Corrected @Label of event and of field. src/java.base

Re: RFR: 8265372: Simplify PKCS9Attribute

2023-12-21 Thread Weijun Wang
On Fri, 15 Dec 2023 20:34:21 GMT, Ben Perez wrote: > Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The > key for the hash map is an `ObjectIdentifier` and the values are a record > `AttributeInfo` that stores the information previously contained in the > arrays `PKCS9

Re: RFR: 8265372: Simplify PKCS9Attribute

2023-12-21 Thread Weijun Wang
On Fri, 15 Dec 2023 20:34:21 GMT, Ben Perez wrote: > Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The > key for the hash map is an `ObjectIdentifier` and the values are a record > `AttributeInfo` that stores the information previously contained in the > arrays `PKCS9

Re: RFR: 8265372: Simplify PKCS9Attribute

2023-12-21 Thread Weijun Wang
On Fri, 15 Dec 2023 20:34:21 GMT, Ben Perez wrote: > Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The > key for the hash map is an `ObjectIdentifier` and the values are a record > `AttributeInfo` that stores the information previously contained in the > arrays `PKCS9

Re: RFR: 8275338: Add JFR events for notable serialization situations [v10]

2023-12-21 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Corrected @Label of event and of field. - Changes: - all: https://git.openjdk.org/jdk/pull/17129/files - new:

Re: RFR: 8275338: Add JFR events for notable serialization situations [v9]

2023-12-21 Thread Erik Gahlin
On Thu, 21 Dec 2023 09:36:06 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Removed @module from test. src/jdk.jfr/share/classes/

Re: RFR: 8275338: Add JFR events for notable serialization situations [v9]

2023-12-21 Thread Raffaello Giulietti
> Adds serialization misdeclaration events to JFR. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Removed @module from test. - Changes: - all: https://git.openjdk.org/jdk/pull/17129/files - new: https://git.o