Integrated: 8322065: Initial nroff manpage generation for JDK 23

2023-12-14 Thread David Holmes
On Thu, 14 Dec 2023 05:46:01 GMT, David Holmes wrote: > Updated the version to 23-ea and year to 2024. > > This initial generation also picks up the unpublished changes from: > > - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool & > jarsigner) > - [JDK-8290702](https://bugs

Re: RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64 [v3]

2023-12-14 Thread Matthew Donovan
> In this PR, I included logic to skip tests on Oracle Linux prior to version > 8. The NSS binaries we are using for testing use a newer version of GLIBC > than is included with OL 7.9. Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The incremen

Integrated: 8296787: Unify debug printing format of X.509 cert serial numbers

2023-12-14 Thread Ben Perez
On Mon, 27 Nov 2023 21:45:23 GMT, Ben Perez wrote: > Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to use > same debug printing format for X.509 serial numbers. The changes are: > - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is > `Serial numbe

Integrated: 8202598: keytool -certreq output contains inconsistent line separators

2023-12-14 Thread Weijun Wang
On Mon, 11 Dec 2023 16:14:24 GMT, Weijun Wang wrote: > When keytool is dumping certificates, certificate requests, and CRLs using > the `-rfc` option, the PEM output contains mixed line endings with LF after > the header and footer and CRLF between the base64 text lines. This code > change upd

Re: RFR: 8202598: keytool -certreq output contains inconsistent line separators

2023-12-14 Thread Sean Mullan
On Mon, 11 Dec 2023 16:14:24 GMT, Weijun Wang wrote: > When keytool is dumping certificates, certificate requests, and CRLs using > the `-rfc` option, the PEM output contains mixed line endings with LF after > the header and footer and CRLF between the base64 text lines. This code > change upd

Re: RFR: 8322065: Initial nroff manpage generation for JDK 23 [v2]

2023-12-14 Thread David Holmes
> Updated the version to 23-ea and year to 2024. > > This initial generation also picks up the unpublished changes from: > > - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool & > jarsigner) > - [JDK-8290702](https://bugs.openjdk.org/browse/JDK-8290702) (javadoc) (JDK > 23 ba

Re: RFR: 8322065: Initial nroff manpage generation for JDK 23

2023-12-14 Thread David Holmes
On Thu, 14 Dec 2023 09:01:17 GMT, Alan Bateman wrote: > Initially I wondered if JDK-8309981 should be separated but include keeps > things in sync so I think okay. Thanks for the review @AlanBateman . Yeah I was in two minds there myself. I started fixing [JDK-8309981](https://bugs.openjdk.or

Re: RFR: 8322065: Initial nroff manpage generation for JDK 23

2023-12-14 Thread David Holmes
On Thu, 14 Dec 2023 09:17:05 GMT, Pavel Rappo wrote: > Thanks for doing this, David. I only note that the changes for JDK-8321384 > were published in [JDK-8308715](https://bugs.openjdk.org/browse/JDK-8308715), > which was integrated in the mainline before JDK 22 RDP 1. So they are already > pr

Re: RFR: 8310813: Simplify and modernize equals, hashCode, and compareTo for BigInteger [v9]

2023-12-14 Thread Pavel Rappo
> Please review this PR to use modern APIs and language features to simplify > equals, hashCode, and compareTo for BigInteger. If you have any performance > concerns, please raise them. > > This PR is cherry-picked from a bigger, not-yet-published PR, to test the > waters. That latter PR will b

Re: RFR: 8310813: Simplify and modernize equals, hashCode, and compareTo for BigInteger [v8]

2023-12-14 Thread Pavel Rappo
On Tue, 7 Nov 2023 07:58:40 GMT, Pavel Rappo wrote: >> Please review this PR to use modern APIs and language features to simplify >> equals, hashCode, and compareTo for BigInteger. If you have any performance >> concerns, please raise them. >> >> This PR is cherry-picked from a bigger, not-yet

Re: RFR: 8322065: Initial nroff manpage generation for JDK 23

2023-12-14 Thread Pavel Rappo
On Thu, 14 Dec 2023 05:46:01 GMT, David Holmes wrote: > Updated the version to 23-ea and year to 2024. > > This initial generation also picks up the unpublished changes from: > > - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool & > jarsigner) > - [JDK-8290702](https://bugs

Re: RFR: 8322065: Initial nroff manpage generation for JDK 23

2023-12-14 Thread Alan Bateman
On Thu, 14 Dec 2023 05:46:01 GMT, David Holmes wrote: > Updated the version to 23-ea and year to 2024. > > This initial generation also picks up the unpublished changes from: > > - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool & > jarsigner) > - [JDK-8290702](https://bugs