Re: RFR: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder [v3]

2023-12-12 Thread Leonid Mesnik
On Mon, 11 Dec 2023 14:06:43 GMT, Stefan Karlsson wrote: >> [JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097): 'Rename >> createJavaProcessBuilder' changed the name of the ProcessTools helper >> functions used to create `ProcessBuilder`s used to spawn new java test >> processes. >> >

Re: RFR: 8202598: [linux] keytool -certreq inconsistent with platform line.separator

2023-12-12 Thread Hai-May Chao
On Mon, 11 Dec 2023 16:14:24 GMT, Weijun Wang wrote: > Always use CRLF in PEM output. Marked as reviewed by hchao (Committer). - PR Review: https://git.openjdk.org/jdk/pull/17060#pullrequestreview-1778545710

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v10]

2023-12-12 Thread Ben Perez
> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to use > same debug printing format for X.509 serial numbers. The changes are: > - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is > `Serial number: 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A` >

Integrated: 8321542: C2: Missing ChaCha20 stub for x86_32 leads to crashes

2023-12-12 Thread Jamil Nimeh
On Tue, 12 Dec 2023 01:02:59 GMT, Jamil Nimeh wrote: > This fix corrects an oversight in the ChaCha20 intrinsics delivered by > JDK-8247645. An ifdef guard is now part of the x86 ChaCha20 intrinsics code > which disables them by default on 32-bit platforms, as this architecture was > not part

Re: RFR: 8321542: C2: Missing ChaCha20 stub for x86_32 leads to crashes [v2]

2023-12-12 Thread Jamil Nimeh
> This fix corrects an oversight in the ChaCha20 intrinsics delivered by > JDK-8247645. An ifdef guard is now part of the x86 ChaCha20 intrinsics code > which disables them by default on 32-bit platforms, as this architecture was > not part of the feature delivery. Jamil Nimeh has updated the

Re: RFR: 8321542: C2: Missing ChaCha20 stub for x86_32 leads to crashes

2023-12-12 Thread Jamil Nimeh
On Tue, 12 Dec 2023 09:24:48 GMT, Aleksey Shipilev wrote: >> src/hotspot/cpu/x86/vm_version_x86.cpp line 1152: >> >>> 1150: // No support currently for ChaCha20 intrinsics on 32-bit platforms >>> 1151: if (UseChaCha20Intrinsics) { >>> 1152: warning("Support for ChaCha20 intrinsics not

Integrated: JDK-8321889: JavaDoc method references with wrong (nested) type

2023-12-12 Thread Hannes Wallnöfer
On Tue, 12 Dec 2023 09:46:29 GMT, Hannes Wallnöfer wrote: > Please review a doc-only change for JavaDoc references using a nested class > instead of the enclosing class containing the target method. Until now this > is accepted by JavaDoc, but with > [JDK-8164094](https://bugs.openjdk.org/brow

Re: RFR: JDK-8321889: JavaDoc method references with wrong (nested) type [v2]

2023-12-12 Thread Alan Bateman
On Tue, 12 Dec 2023 10:42:32 GMT, Hannes Wallnöfer wrote: >> Please review a doc-only change for JavaDoc references using a nested class >> instead of the enclosing class containing the target method. Until now this >> is accepted by JavaDoc, but with >> [JDK-8164094](https://bugs.openjdk.org/

Re: RFR: JDK-8321889: JavaDoc method references with wrong (nested) type [v2]

2023-12-12 Thread Hannes Wallnöfer
> Please review a doc-only change for JavaDoc references using a nested class > instead of the enclosing class containing the target method. Until now this > is accepted by JavaDoc, but with > [JDK-8164094](https://bugs.openjdk.org/browse/JDK-8164094) these references > are reported as errors.

RFR: JDK-8321889: JavaDoc method references with wrong (nested) type

2023-12-12 Thread Hannes Wallnöfer
Please review a change to fix JavaDoc references using a nested class instead of the enclosing class containing the target method. Until now this is accepted by JavaDoc (with the correct link being created). With [JDK-8164094](https://bugs.openjdk.org/browse/JDK-8164094) these references are re

Re: RFR: 8321542: C2: Missing ChaCha20 stub for x86_32 leads to crashes

2023-12-12 Thread Aleksey Shipilev
On Tue, 12 Dec 2023 08:53:35 GMT, Christian Hagedorn wrote: >> This fix corrects an oversight in the ChaCha20 intrinsics delivered by >> JDK-8247645. An ifdef guard is now part of the x86 ChaCha20 intrinsics code >> which disables them by default on 32-bit platforms, as this architecture was

Re: RFR: 8321542: C2: Missing ChaCha20 stub for x86_32 leads to crashes

2023-12-12 Thread Aleksey Shipilev
On Tue, 12 Dec 2023 01:02:59 GMT, Jamil Nimeh wrote: > This fix corrects an oversight in the ChaCha20 intrinsics delivered by > JDK-8247645. An ifdef guard is now part of the x86 ChaCha20 intrinsics code > which disables them by default on 32-bit platforms, as this architecture was > not part

Re: RFR: 8321542: C2: Missing ChaCha20 stub for x86_32 leads to crashes

2023-12-12 Thread Christian Hagedorn
On Tue, 12 Dec 2023 01:02:59 GMT, Jamil Nimeh wrote: > This fix corrects an oversight in the ChaCha20 intrinsics delivered by > JDK-8247645. An ifdef guard is now part of the x86 ChaCha20 intrinsics code > which disables them by default on 32-bit platforms, as this architecture was > not part