Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v4]

2023-12-04 Thread Julian Waters
On Mon, 4 Dec 2023 14:49:24 GMT, Weijun Wang wrote: > I don't like all those duplicated lines. Why do you think the previous fix is > a hack? I would guess the C++ designers are also not happy of this > restriction so they provide us a way to avoid it. Maybe they will enhance it > again someti

Withdrawn: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available

2023-12-04 Thread duke
On Fri, 21 Jul 2023 22:40:00 GMT, Brian Burkhalter wrote: > Limit native memory allocation and move write loop from the native layer into > Java. This change should make the OOME reported in the issue much less likely. This pull request has been closed without being integrated. -

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v5]

2023-12-04 Thread Ben Perez
> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to use > same debug printing format for X.509 serial numbers. The changes are: > - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is > `Serial number: 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A` >

Re: RFR: 8321274: Rename ZipEntry.extraAttributes to ZipEntry.externalAttributes

2023-12-04 Thread Lance Andersen
On Mon, 4 Dec 2023 15:34:34 GMT, Eirik Bjorsnos wrote: > Please consider this PR which suggests we rename `ZipEntry.extraAttributes` > to `ZipEntry.externalAttributes`. > > This field was introduced in > [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under > the name `

Re: RFR: 8306688: Support Windows serialized keystores (SST files)

2023-12-04 Thread Mat Carter
On Fri, 26 May 2023 21:09:35 GMT, Mat Carter wrote: > Added ability to load keystores from SST files on Windows. Example usage: > > KeyStore keyStore = KeyStore.getInstance("Windows-SST"); > try (FileInputStream fis = new FileInputStream("mykeystore.sst")) { >keyStore.load(fis, null); > } >

AW: [External] : Re: PEM KeyStore Implementation

2023-12-04 Thread Karl Scheibelhofer
Hi Tony! I read the darft https://openjdk.org/jeps/8300911. It looks quite good to me. To get a beffer feeling, I would like to use it. Is there a draft implememtation of this API? I could give it a go with the draft version of PEM Keystore I did in KarlScheibelhofer/jdk at pem-keystore (gith

RFR: 8321274: Rename ZipEntry.extraAttributes to ZipEntry.externalAttributes

2023-12-04 Thread Eirik Bjorsnos
Please consider this PR which suggests we rename `ZipEntry.extraAttributes` to `ZipEntry.externalAttributes`. This field was introduced in [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under the name `ZipEntry.posixPerms`. [JDK-8250968](https://bugs.openjdk.org/browse/

Re: RFR: 8306688: Support Windows serialized keystores (SST files)

2023-12-04 Thread Weijun Wang
On Thu, 1 Jun 2023 17:11:01 GMT, Mat Carter wrote: >> Added ability to load keystores from SST files on Windows. Example usage: >> >> KeyStore keyStore = KeyStore.getInstance("Windows-SST"); >> try (FileInputStream fis = new FileInputStream("mykeystore.sst")) { >>keyStore.load(fis, null); >

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v4]

2023-12-04 Thread Weijun Wang
On Mon, 4 Dec 2023 09:26:57 GMT, Julian Waters wrote: >> I regret not actually addressing the issues with the goto labels in >> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in >> sspi were jumped over by gotos to a certain label. I changed the >> initializations in

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v4]

2023-12-04 Thread Julian Waters
> I regret not actually addressing the issues with the goto labels in > https://github.com/openjdk/jdk/pull/15996, where initialization of locals in > sspi were jumped over by gotos to a certain label. I changed the > initializations into split declarations and assignments in > https://github.c

Re: RFR: 8318756 Create better internal buffer for AEADs [v2]

2023-12-04 Thread Daniel Jeliński
On Tue, 28 Nov 2023 00:49:49 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/com/sun/crypto/provider/AEADBufferedStream.java >> line 94: >> >>> 92: } else { >>> 93: if (buf.length < (count + len)) { >>> 94: buf = Arrays.copyOf(buf, count + len);

Re: RFR: 8318756 Create better internal buffer for AEADs [v2]

2023-12-04 Thread Daniel Jeliński
On Fri, 1 Dec 2023 22:42:47 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review for a new internal buffer class called AEADBufferStream. >> AEADBufferStream extends ByteArrayOutputStream, but eliminates some data >> checking and copying that are not necessary for what GaloisCounterMode.