Re: RFR: 8320362: Load anchor certificates from Keychain keystore [v2]

2023-12-01 Thread 1keep2keepFaith
On Fri, 1 Dec 2023 23:39:55 GMT, Alexey Bakhtin wrote: >> Please review the proposed fix. >> >> The patch loads system root certificates from the MacOS Keychain with >> TrustSettings. >> It allows to build a trusted certificate path using the MacOS Keychain store >> only. > > Alexey Bakhtin ha

Re: RFR: 8320362: Load anchor certificates from Keychain keystore [v2]

2023-12-01 Thread Alexey Bakhtin
> Please review the proposed fix. > > The patch loads system root certificates from the MacOS Keychain with > TrustSettings. > It allows to build a trusted certificate path using the MacOS Keychain store > only. Alexey Bakhtin has updated the pull request incrementally with one additional comm

Re: RFR: 8318756 Create better internal buffer for AEADs [v2]

2023-12-01 Thread Anthony Scarpino
On Tue, 28 Nov 2023 08:34:21 GMT, Daniel JeliƄski wrote: >> The second sentence says what the optimizations is. > > well I was under the impression that the bulk of the optimization comes from > using modified `engineGetOutputSize` that does not allocate when isUpdate== > true and decrypting. T

Re: RFR: 8318756 Create better internal buffer for AEADs [v2]

2023-12-01 Thread Anthony Scarpino
> Hi, > > I need a review for a new internal buffer class called AEADBufferStream. > AEADBufferStream extends ByteArrayOutputStream, but eliminates some data > checking and copying that are not necessary for what GaloisCounterMode.java > and ChaCha20Cipher.java need. > > The changes greates

Re: [External] : Re: PEM KeyStore Implementation

2023-12-01 Thread Karl Scheibelhofer
Hi Tony, here is some thoughts about the PEM API Draft https://openjdk.org/jeps/8300911 considdering its use for implementing a PEM KeyStore: * Decoder reads from a Reader. Encoder should also support writing to a Writer for consistency. * Consider supporting byte[] or InputStream/OutputStream t