On Thu, 16 Nov 2023 04:40:53 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations i
> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to use
> same debug printing format for X.509 serial numbers. The changes are:
> - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is
> `Serial number: 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A`
>
On Wed, 29 Nov 2023 19:12:20 GMT, Ben Perez wrote:
>> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to
>> use same debug printing format for X.509 serial numbers. The changes are:
>> - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is
>> `Serial n
On Tue, 28 Nov 2023 08:35:29 GMT, Daniel Jeliński wrote:
>> Hi,
>>
>> I need a review for a new internal buffer class called AEADBufferStream.
>> AEADBufferStream extends ByteArrayOutputStream, but eliminates some data
>> checking and copying that are not necessary for what GaloisCounterMode.
> Updated `X509CertSelector.java` and `SerialNumber.java` to use same debug
> printing format for X.509 serial numbers. The format in `SSLLogger.java` is
> slightly different but now uses the `toString` method in `SerialNumber.java`
> for better readability.
Ben Perez has updated the pull reque
On Tue, 28 Nov 2023 20:07:22 GMT, Ben Perez wrote:
>> Updated `X509CertSelector.java` and `SerialNumber.java` to use same debug
>> printing format for X.509 serial numbers. The format in `SSLLogger.java` is
>> slightly different but now uses the `toString` method in `SerialNumber.java`
>> for
On Tue, 28 Nov 2023 10:53:51 GMT, Sean Coffey wrote:
> for clarity - can you include before and after examples of the serial numbers
> printed from each change ?
Yes, I think that would be useful. Also you will need to add a `noreg` label to
the bug since you are not including a test (which I
