Re: RFR: 8308144: HttpClient - uncontrolled memory consumption in SSLFlowDelegate.Reader

2023-11-20 Thread Jaikiran Pai
On Thu, 25 May 2023 20:17:39 GMT, zhurs wrote: > When using HttpClient to make requests to HTTPS resources, there is an issue > where the entire file is being downloaded into memory without the ability to > limit the buffer size. > If the SSLEngine cannot decode the entire buffer due to the alg

Re: RFR: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer [v4]

2023-11-20 Thread Valerie Peng
On Tue, 24 Oct 2023 19:58:58 GMT, Matthew Donovan wrote: >> Hello, >> >> In this PR I removed NSS tests from the ProblemList and updated NssTest to >> use Sqlite databases. I also removed code in PKCS11Test.java that falls back >> to NSS libraries installed on the test system. The tests can st

Re: RFR: 4936767: Parameters for MessageDigest [v7]

2023-11-20 Thread Weijun Wang
> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an > integer parameter. Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contai

RFR: 8313367: Local Computer store is opened with max. allowed permissions

2023-11-20 Thread rebarbora-mckvak
This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367 If the process does not have write permissions, the store is opened as read-only (instead of failing). Please note that permissions to use a certificate in a local machine store must be granted - in a management cons

Integrated: 8320192: SHAKE256 does not work correctly if n >= 137

2023-11-20 Thread Weijun Wang
On Thu, 16 Nov 2023 20:45:29 GMT, Weijun Wang wrote: > When blocksize is less than digest output length, call `keccak` more. This pull request has now been integrated. Changeset: fcb4df26 Author:Weijun Wang URL: https://git.openjdk.org/jdk/commit/fcb4df26f18c7a10e4511f4be948c887f14e

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v5]

2023-11-20 Thread Valerie Peng
On Mon, 20 Nov 2023 23:26:44 GMT, Weijun Wang wrote: >> When blocksize is less than digest output length, call `keccak` more. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > update comment Looks good to me. Thanks~ ---

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v5]

2023-11-20 Thread Weijun Wang
> When blocksize is less than digest output length, call `keccak` more. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: update comment - Changes: - all: https://git.openjdk.org/jdk/pull/16698/files - new: https://git.

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v4]

2023-11-20 Thread Weijun Wang
On Mon, 20 Nov 2023 13:57:58 GMT, Weijun Wang wrote: >> When blocksize is less than digest output length, call `keccak` more. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > minimize code changes OK, I will remove the ` = (

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v4]

2023-11-20 Thread Valerie Peng
On Mon, 20 Nov 2023 13:57:58 GMT, Weijun Wang wrote: >> When blocksize is less than digest output length, call `keccak` more. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > minimize code changes Changes look fine. The syno

Integrated: 8320208: Update Public Suffix List to b5bf572

2023-11-20 Thread Weijun Wang
On Thu, 16 Nov 2023 14:50:23 GMT, Weijun Wang wrote: > Update `public_suffix_list.dat` to the latest. This pull request has now been integrated. Changeset: 2b4e9914 Author:Weijun Wang URL: https://git.openjdk.org/jdk/commit/2b4e99140a315d3da765b2edb031b38725a05f1c Stats: 3002 li

Integrated: JDK-8320372: test/jdk/sun/security/x509/DNSName/LeadingPeriod.java validity check failed

2023-11-20 Thread Sean Mullan
On Mon, 20 Nov 2023 16:43:08 GMT, Sean Mullan wrote: > Set the validity date to the notBefore date of the EE certs so that > validation won't fail when the certs expire - there is only one cert in the > path so this should be sufficient. I also removed the trust anchor from the > CertPath as i

Re: RFR: JDK-8320372: test/jdk/sun/security/x509/DNSName/LeadingPeriod.java validity check failed [v2]

2023-11-20 Thread Alan Bateman
On Mon, 20 Nov 2023 17:21:00 GMT, Sean Mullan wrote: >> Set the validity date to the notBefore date of the EE certs so that >> validation won't fail when the certs expire - there is only one cert in the >> path so this should be sufficient. I also removed the trust anchor from the >> CertPath

Re: RFR: JDK-8320372: test/jdk/sun/security/x509/DNSName/LeadingPeriod.java validity check failed [v2]

2023-11-20 Thread Sean Mullan
> Set the validity date to the notBefore date of the EE certs so that > validation won't fail when the certs expire - there is only one cert in the > path so this should be sufficient. I also removed the trust anchor from the > CertPath as it isn't necessary to include that in the path. > > Not

Re: RFR: 4936767: Parameters for MessageDigest [v6]

2023-11-20 Thread Weijun Wang
On Mon, 20 Nov 2023 17:07:12 GMT, Weijun Wang wrote: >> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an >> integer parameter. > > Weijun Wang has updated the pull request incrementally with two additional > commits since the last revision: > > - more spec change, restru

Re: RFR: JDK-8320372: test/jdk/sun/security/x509/DNSName/LeadingPeriod.java validity check failed

2023-11-20 Thread Alan Bateman
On Mon, 20 Nov 2023 16:43:08 GMT, Sean Mullan wrote: > Set the validity date to the notBefore date of the EE certs so that > validation won't fail when the certs expire - there is only one cert in the > path so this should be sufficient. I also removed the trust anchor from the > CertPath as i

Re: RFR: 4936767: Parameters for MessageDigest [v6]

2023-11-20 Thread Weijun Wang
> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an > integer parameter. Weijun Wang has updated the pull request incrementally with two additional commits since the last revision: - more spec change, restruct SHAKE256.java - Revert "throw iape" This reverts commit

RFR: JDK-8320372: test/jdk/sun/security/x509/DNSName/LeadingPeriod.java validity check failed

2023-11-20 Thread Sean Mullan
Set the validity date to the notBefore date of the EE certs so that validation won't fail when the certs expire - there is only one cert in the path so this should be sufficient. I also removed the trust anchor from the CertPath as it isn't necessary to include that in the path. Not sure if it

Re: RFR: 8310901: Convert String::newStringNoRepl with Latin-1 to String::newStringLatin1NoRepl [v8]

2023-11-20 Thread Glavo
> Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`. > > Reasons: > > * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset, > creating a new shortcut can make writing shorter; > * Since all possible values of `byte` are legal Latin-1 characters, > `newStringLat

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v4]

2023-11-20 Thread Mark Powers
On Mon, 20 Nov 2023 13:57:58 GMT, Weijun Wang wrote: >> When blocksize is less than digest output length, call `keccak` more. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > minimize code changes Nice! - PR Co

Re: RFR: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer [v2]

2023-11-20 Thread Magnus Ihse Bursie
On Mon, 23 Oct 2023 11:43:06 GMT, Matthew Donovan wrote: >> I am not sure, but shouldn`t the change also adopt the documentation in >> test/jdk/sun/security/pkcs11/README > >> I am not sure, but shouldn`t the change also adopt the documentation in >> test/jdk/sun/security/pkcs11/README > > Goo

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v3]

2023-11-20 Thread Weijun Wang
On Fri, 17 Nov 2023 00:05:59 GMT, Weijun Wang wrote: >> When blocksize is less than digest output length, call `keccak` more. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > add comment for squeezeOffset New commit pushed.

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v4]

2023-11-20 Thread Weijun Wang
> When blocksize is less than digest output length, call `keccak` more. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: minimize code changes - Changes: - all: https://git.openjdk.org/jdk/pull/16698/files - new: https

Re: RFR: 8320362: Load anchor certificates from Keychain keystore

2023-11-20 Thread Weijun Wang
On Sat, 18 Nov 2023 02:41:05 GMT, Alexey Bakhtin wrote: > Please review the proposed fix. > > The patch loads system root certificates from the MacOS Keychain with > TrustSettings. > It allows to build a trusted certificate path using the MacOS Keychain store > only. How about putting these c