Re: RFR: 4936767: Parameters for MessageDigest [v5]

2023-11-17 Thread Weijun Wang
> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an > integer parameter. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: no len no params - Changes: - all: https://git.openjdk.org/jdk/pull/16660/fi

Re: JEP draft: PEM API (Preview)

2023-11-17 Thread Anthony Scarpino
On 11/16/23 5:36 PM, Bernd Eckenfels wrote: I wonder if you should also allow to set comment or generally text headers when encoding and for decoding if you need access to the comment. I neglected to ask what you meant by setting or accessing a "comment". Are you talking about non-PEM data in

Re: RFR: 4936767: Parameters for MessageDigest [v3]

2023-11-17 Thread Weijun Wang
On Fri, 17 Nov 2023 20:22:49 GMT, Kevin Driver wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> cite resources > > src/java.base/share/classes/sun/security/provider/SHAKE256.java line 27: > >> 25: package sun.securi

Re: RFR: 4936767: Parameters for MessageDigest [v4]

2023-11-17 Thread Weijun Wang
> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an > integer parameter. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: full imports - Changes: - all: https://git.openjdk.org/jdk/pull/16660/files

Re: RFR: 4936767: Parameters for MessageDigest [v3]

2023-11-17 Thread Kevin Driver
On Fri, 17 Nov 2023 15:49:56 GMT, Weijun Wang wrote: >> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an >> integer parameter. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > cite resources src/java.b

Re: [External] : Re: PEM KeyStore Implementation

2023-11-17 Thread Anthony Scarpino
As you may have seen, the PEM API draft is out: https://openjdk.org/jeps/8300911 Tony On 10/18/23 3:00 AM, Karl Scheibelhofer wrote: Hi Sean, Yes, I can help with this new PEM API. Let me know, when there is something to review. Best regards, Karl On Tue, Oct 17, 2023, 19:12 Sean Mulla

Re: JEP draft: PEM API (Preview)

2023-11-17 Thread Anthony Scarpino
On 11/16/23 5:36 PM, Bernd Eckenfels wrote: Anthony Scarpino wrote on 16. Nov 2023 23:47 (GMT +01:00): Hi all, We are proposing to add an API for PEM and a foundation for other crypto encoding. I like the modularity and that you do not try to squeeze it into the existing services. I wonde

Re: RFR: JDK-8318105 [jmh] the test java.security.HSS failed with 2 active threads

2023-11-17 Thread Mark Powers
On Fri, 17 Nov 2023 17:28:40 GMT, Kevin Driver wrote: >> https://bugs.openjdk.org/browse/JDK-8318105 > > test/micro/org/openjdk/bench/java/security/HSS.java line 83: > >> 81: @Setup >> 82: public void setup() throws Exception { >> 83: p = Security.getProvider("SUN"); > > I assum

Re: RFR: JDK-8318105 [jmh] the test java.security.HSS failed with 2 active threads

2023-11-17 Thread Kevin Driver
On Tue, 31 Oct 2023 18:16:11 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8318105 test/micro/org/openjdk/bench/java/security/HSS.java line 83: > 81: @Setup > 82: public void setup() throws Exception { > 83: p = Security.getProvider("SUN"); I assume this was jus

Re: RFR: 8320208: Update Public Suffix List to b5bf572

2023-11-17 Thread Sean Mullan
On Thu, 16 Nov 2023 14:50:23 GMT, Weijun Wang wrote: > Update `public_suffix_list.dat` to the latest. Marked as reviewed by mullan (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16692#pullrequestreview-1737519720

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v3]

2023-11-17 Thread Julian Waters
On Fri, 17 Nov 2023 15:44:52 GMT, Thomas Stuefe wrote: > > > > > Can you please describe the problem you are trying to solve, and why > > > > > you think it is worth solving. You describe the thought process you > > > > > went through while doing the patch and possibly some other, older > > >

Re: RFR: 4936767: Parameters for MessageDigest [v2]

2023-11-17 Thread Weijun Wang
On Fri, 17 Nov 2023 15:28:53 GMT, Weijun Wang wrote: >> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an >> integer parameter. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > throw iape New commits pu

Re: RFR: 4936767: Parameters for MessageDigest [v3]

2023-11-17 Thread Weijun Wang
> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an > integer parameter. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: cite resources - Changes: - all: https://git.openjdk.org/jdk/pull/16660/file

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v3]

2023-11-17 Thread Thomas Stuefe
On Thu, 16 Nov 2023 04:40:53 GMT, Julian Waters wrote: >> I regret not actually addressing the issues with the goto labels in >> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in >> sspi were jumped over by gotos to a certain label. I changed the >> initializations i

Re: RFR: 4936767: Parameters for MessageDigest [v2]

2023-11-17 Thread Weijun Wang
> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an > integer parameter. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: throw iape - Changes: - all: https://git.openjdk.org/jdk/pull/16660/files

Re: RFR: 4936767: Parameters for MessageDigest

2023-11-17 Thread Weijun Wang
On Wed, 15 Nov 2023 21:40:10 GMT, Kevin Driver wrote: >> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an >> integer parameter. > > src/java.base/share/classes/sun/security/ec/ed/EdDSASignature.java line 31: > >> 29: >> 30: import java.io.ByteArrayOutputStream; >> 31: imp

Re: RFR: 4936767: Parameters for MessageDigest

2023-11-17 Thread Weijun Wang
On Wed, 15 Nov 2023 22:24:00 GMT, Sean Mullan wrote: >> This is following the `SecureRandom` style where there are both >> `getInstance` methods that has or has not the parameters argument. If you >> think IAPE is better I can also throw it. `CertStore` does this way and it >> has a dedicated

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v3]

2023-11-17 Thread Julian Waters
On Fri, 17 Nov 2023 14:13:58 GMT, Thomas Stuefe wrote: > > > Can you please describe the problem you are trying to solve, and why you > > > think it is worth solving. You describe the thought process you went > > > through while doing the patch and possibly some other, older patch. As it > > >

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v3]

2023-11-17 Thread Thomas Stuefe
On Fri, 17 Nov 2023 14:04:07 GMT, Julian Waters wrote: > > Can you please describe the problem you are trying to solve, and why you > > think it is worth solving. You describe the thought process you went > > through while doing the patch and possibly some other, older patch. As it > > is, rea

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v3]

2023-11-17 Thread Julian Waters
On Fri, 17 Nov 2023 13:49:22 GMT, Thomas Stuefe wrote: > Can you please describe the problem you are trying to solve, and why you > think it is worth solving. You describe the thought process you went through > while doing the patch and possibly some other, older patch. As it is, reading > the

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v3]

2023-11-17 Thread Thomas Stuefe
On Thu, 16 Nov 2023 04:40:53 GMT, Julian Waters wrote: >> I regret not actually addressing the issues with the goto labels in >> https://github.com/openjdk/jdk/pull/15996, I've as such fixed the issues >> with them properly this time, by simply deleting the labels and duplicating >> the code w

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v3]

2023-11-17 Thread Julian Waters
On Thu, 16 Nov 2023 04:40:53 GMT, Julian Waters wrote: >> I regret not actually addressing the issues with the goto labels in >> https://github.com/openjdk/jdk/pull/15996, I've as such fixed the issues >> with them properly this time, by simply deleting the labels and duplicating >> the code w