Re: RFR: 8319332: Security properties files inclusion [v2]

2023-11-13 Thread Francisco Ferrari Bihurriet
On Fri, 10 Nov 2023 16:46:15 GMT, Andrew John Hughes wrote: >> My major concern is that this does not look like a properties file anymore, >> that the same key have multiple values and you use an undocumented (?) >> format "key value". That said, this is a clever hack and I wonder why we >> ha

Re: RFR: 8319332: Security properties files inclusion [v3]

2023-11-13 Thread Francisco Ferrari Bihurriet
> The implementation of this proposal is based on the requirements, > specification and design choices described in the [JDK-8319332] ticket and > its respective CSR [JDK-8319333]. What follows are implementation notes > organized per functional component, with the purpose of assisting to naviga

Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs [v2]

2023-11-13 Thread Alan Bateman
On Mon, 13 Nov 2023 16:00:05 GMT, Yakov Shafranovich wrote: > That would probably also involve taking existing documentation such as the > note about not opening entries with "."/"..", and the POSIX permissions > mappings? Would it make sense to split the rest of the changes in this PR > from

Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs [v2]

2023-11-13 Thread Yakov Shafranovich
On Sat, 11 Nov 2023 14:04:11 GMT, Alan Bateman wrote: >> Yakov Shafranovich has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fixed more line breaks >> - fixed line breaks > > src/jdk.zipfs/share/classes/module-info.java line 310: > >>

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v8]

2023-11-13 Thread Sean Mullan
On Fri, 10 Nov 2023 06:49:04 GMT, Xue-Lei Andrew Fan wrote: >> Good point - the CSR and RN could have been a bit more specific about the >> compatibility effect of changing the default from 10 to 8, so we will update >> that. Note that the CertPathBuilder default max path length [is 5 >> non-s

Re: RFR: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64

2023-11-13 Thread Matthew Donovan
On Thu, 9 Nov 2023 20:39:54 GMT, Kevin Driver wrote: >> In this PR, I included logic to skip tests on Oracle Linux prior to version >> 8. The NSS binaries we are using for testing use a newer version of GLIBC >> than is included with OL 7.9. > > test/jdk/ProblemList.txt line 632: > >> 630: su