Re: RFR: 8319332: Security properties files inclusion [v2]

2023-11-10 Thread Martin Balao
On Fri, 10 Nov 2023 17:33:33 GMT, Weijun Wang wrote: > > By "the same key has multiple values", I assume you mean the key "import"? > > The implementation overrides `put` and swallows these `include` lines so > > they are never actually added as keys and values. > > Yes, I understand this, and

Re: RFR: 8309330: Allow java.security to be extended via a properties directory [v3]

2023-11-10 Thread Andrew John Hughes
On Tue, 29 Aug 2023 21:59:37 GMT, Andrew John Hughes wrote: >> Currently, security properties are held within the `java.security` file in >> the JDK tree for each installed JDK. The system property >> `java.security.properties` can be used to point to a file containing >> additional properties

Re: RFR: 8319332: Security properties files inclusion [v2]

2023-11-10 Thread Weijun Wang
On Fri, 10 Nov 2023 16:46:15 GMT, Andrew John Hughes wrote: > By "the same key has multiple values", I assume you mean the key "import"? > The implementation overrides `put` and swallows these `include` lines so they > are never actually added as keys and values. Yes, I understand this, and th

Re: RFR: 8310813: Simplify and modernize equals, hashCode, and compareTo for BigInteger [v8]

2023-11-10 Thread Pavel Rappo
On Tue, 7 Nov 2023 07:58:40 GMT, Pavel Rappo wrote: >> Please review this PR to use modern APIs and language features to simplify >> equals, hashCode, and compareTo for BigInteger. If you have any performance >> concerns, please raise them. >> >> This PR is cherry-picked from a bigger, not-yet

Re: RFR: 8319332: Security properties files inclusion [v2]

2023-11-10 Thread Andrew John Hughes
On Thu, 9 Nov 2023 21:36:44 GMT, Weijun Wang wrote: > My major concern is that this does not look like a properties file anymore, > that the same key have multiple values and you use an undocumented (?) format > "key value". That said, this is a clever hack and I wonder why we hadn't used > it

Re: RFR: 8319332: Security properties files inclusion [v2]

2023-11-10 Thread Andrew John Hughes
On Fri, 3 Nov 2023 22:18:22 GMT, Francisco Ferrari Bihurriet wrote: >> The implementation of this proposal is based on the requirements, >> specification and design choices described in the [JDK-8319332] ticket and >> its respective CSR [JDK-8319333]. What follows are implementation notes >>

Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs [v2]

2023-11-10 Thread Yakov Shafranovich
> The various Zip/Jar-file related Java APIs have some long-standing > differences or peculiarities with respect to the ZIP-file specification or > compared to other implementations which should be documented in the API-doc. > This documents the following: > - Cache of JAR files in JarURLConnect

Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs [v2]

2023-11-10 Thread Yakov Shafranovich
On Thu, 9 Nov 2023 20:43:25 GMT, Kevin Driver wrote: >> Yakov Shafranovich has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fixed more line breaks >> - fixed line breaks > > src/jdk.zipfs/share/classes/module-info.java line 303: > >>

Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs

2023-11-10 Thread Yakov Shafranovich
On Thu, 9 Nov 2023 20:42:52 GMT, Kevin Driver wrote: >> The various Zip/Jar-file related Java APIs have some long-standing >> differences or peculiarities with respect to the ZIP-file specification or >> compared to other implementations which should be documented in the API-doc. >> This docum

Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs

2023-11-10 Thread Yakov Shafranovich
On Thu, 9 Nov 2023 20:41:22 GMT, Kevin Driver wrote: >> The various Zip/Jar-file related Java APIs have some long-standing >> differences or peculiarities with respect to the ZIP-file specification or >> compared to other implementations which should be documented in the API-doc. >> This docum

Re: RFR: 8318479: [jmh] the test security.CacheBench failed for multiple threads run

2023-11-10 Thread Daniel Jeliński
On Mon, 23 Oct 2023 16:23:55 GMT, Daniel Jeliński wrote: > Remove the hardcoded maximum heap size. > > Verified that the benchmark now passes with 100 threads given sufficient heap: > > make test TEST=micro:CacheBench MICRO="OPTIONS=-t 100;JAVA_OPTIONS=-Xmx16g" I introduced the limit originall

Re: RFR: 8319332: Security properties files inclusion [v2]

2023-11-10 Thread Francisco Ferrari Bihurriet
On Thu, 9 Nov 2023 21:36:44 GMT, Weijun Wang wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> 8319332: use Path::of(URI) to deal with file URLs >> >> Instead of the previously introduced FileURLC