RFR: 8319670: Improve comments describing system properties for TLS server and client for max chain length

2023-11-08 Thread Hai-May Chao
Please review the comment change in SSLConfiguration class that describes TLS related system properties used to enforce certificate chain length. Thanks. - Commit messages: - Improve comments describing system properties for TLS server and client for max chain length Changes: http

RFR: 8318759: Add four DigiCert root certificates

2023-11-08 Thread Rajan Halade
This PR is to add 4 new TLS root certificates from Digicert, Inc. This CA has gone through https://www.oracle.com/java/technologies/javase/carootcertsprogram.html process. The release-note is at [JDK-8319243](https://bugs.openjdk.org/browse/JDK-8319243) - Commit messages: - 8318

Re: RFR: 8315487: Security Providers Filter

2023-11-08 Thread Sean Mullan
Hi Martin and Francisco, Thank you for your work on proposing this feature. This is a significant change to the JCA/JCE provider mechanism and consists of (roughly) over a thousand lines of code changes. Based on that and after spending some time understanding and reviewing the proposal, we fee

Re: RFR: 8319374: JFR: Remove instrumentation for exception events [v3]

2023-11-08 Thread Erik Gahlin
On Wed, 8 Nov 2023 13:39:10 GMT, Daniel Fuchs wrote: >> I agree, and I have looked into it, but I think it's better to do that >> refactorization separately as it will impact other events. > > Just for my own understanding: in this particular case the time stamp is > meaningless because the dur

Re: RFR: 8319374: JFR: Remove instrumentation for exception events [v3]

2023-11-08 Thread Daniel Fuchs
On Wed, 8 Nov 2023 05:34:47 GMT, Erik Gahlin wrote: >> src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 62: >> >>> 60: if (ExceptionThrownEvent.enabled()) { >>> 61: long timestamp = ExceptionThrownEvent.timestamp(); >>> 62: ExceptionThrownE

Integrated: 8319374: JFR: Remove instrumentation for exception events

2023-11-08 Thread Erik Gahlin
On Fri, 3 Nov 2023 12:19:07 GMT, Erik Gahlin wrote: > Could I have a review of a PR that removes the bytecode instrumentation for > the exception events. > > Testing: jdk/jdk/jfr + tier1 + tier2 This pull request has now been integrated. Changeset: e8418972 Author:Erik Gahlin URL: