On Mon, 6 Nov 2023 20:48:59 GMT, Hai-May Chao wrote:
>> I think the wording of the comment is somewhat confusing because it is
>> trying to explain the behavior of both properties together and the words
>> "either" and "neither" may be hard to parse. I recommend separate comment
>> blocks for
On Mon, 6 Nov 2023 22:41:17 GMT, Erik Gahlin wrote:
>> src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 44:
>>
>>> 42:
>>> 43: public static void traceError(Class clazz, String message) {
>>> 44: if (OutOfMemoryError.class.isAssignableFrom(clazz)) {
>>
>> St
> Could I have a review of a PR that removes the bytecode instrumentation for
> the exception events.
>
> Testing: jdk/jdk/jfr + tier1 + tier2
Erik Gahlin has updated the pull request incrementally with one additional
commit since the last revision:
Remove SecurityException and IllegalArgume
On Mon, 6 Nov 2023 15:49:02 GMT, Alan Bateman wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 37:
>
>> 35:
> Limit native memory allocation and move write loop from the native layer into
> Java. This change should make the OOME reported in the issue much less likely.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the un
On Wed, 1 Nov 2023 14:13:32 GMT, Sean Mullan wrote:
>> When no system property is set, previously max inbound length is 10, now
>> it's 8.
>
> I think the wording of the comment is somewhat confusing because it is trying
> to explain the behavior of both properties together and the words "eithe
On Fri, 3 Nov 2023 12:19:07 GMT, Erik Gahlin wrote:
> Could I have a review of a PR that removes the bytecode instrumentation for
> the exception events.
>
> Testing: jdk/jdk/jfr + tier1 + tier2
src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 37:
> 35: private sta
Could I have a review of a PR that removes the bytecode instrumentation for the
exception events.
Testing: jdk/jdk/jfr + tier1 + tier2
-
Commit messages:
- Remove Throwable and Error from instrumentation list
- Initial
Changes: https://git.openjdk.org/jdk/pull/16493/files
Webrev
On Wed, 11 Oct 2023 21:24:30 GMT, Kevin Driver wrote:
> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12
This pull request has now been integrated.
Changeset: 1696603c
Author:Kevin Driver
URL:
https://git.openjdk.org/jdk/commit/1696603ccd43a279efa35d9f6617ce66
On Mon, 30 Oct 2023 17:26:53 GMT, Yakov Shafranovich wrote:
> The various Zip/Jar-file related Java APIs have some long-standing
> differences or peculiarities with respect to the ZIP-file specification or
> compared to other implementations which should be documented in the API-doc.
> This do
10 matches
Mail list logo
