> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12
Kevin Driver has updated the pull request incrementally with one additional
commit since the last revision:
Security Manager won't let you explicitly set the type here for some
reason
-
Changes:
- all:
On Tue, 17 Oct 2023 15:30:03 GMT, Weijun Wang wrote:
> Create a parent interface `AsymmetricKey` for `PublicKey` and `PrivateKey`
> and add a `getParams` method there. This makes it available to all current
> and future public and private keys.
>
> No test. Might add one.
This pull request ha
On Thu, 26 Oct 2023 17:37:01 GMT, Weijun Wang wrote:
>> Create a parent interface `AsymmetricKey` for `PublicKey` and `PrivateKey`
>> and add a `getParams` method there. This makes it available to all current
>> and future public and private keys.
>>
>> No test. Might add one.
>
> Weijun Wang
> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12
Kevin Driver has updated the pull request incrementally with one additional
commit since the last revision:
additional updates to explicitly use PKCS12
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1
> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank
> you.
Hai-May Chao has updated the pull request incrementally with one additional
commit since the last revision:
Change property names to clearly indicate client side and server side
-
Changes:
-
On Thu, 26 Oct 2023 17:37:01 GMT, Weijun Wang wrote:
>> Create a parent interface `AsymmetricKey` for `PublicKey` and `PrivateKey`
>> and add a `getParams` method there. This makes it available to all current
>> and future public and private keys.
>>
>> No test. Might add one.
>
> Weijun Wang
> Create a parent interface `AsymmetricKey` for `PublicKey` and `PrivateKey`
> and add a `getParams` method there. This makes it available to all current
> and future public and private keys.
>
> No test. Might add one.
Weijun Wang has updated the pull request incrementally with one additional
On Thu, 26 Oct 2023 17:08:27 GMT, Sean Mullan wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use @inheritDoc
>
> src/java.base/share/classes/java/security/interfaces/RSAPrivateKey.java line
> 74:
>
>> 72: */
On Thu, 26 Oct 2023 17:23:26 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/java/security/interfaces/RSAPrivateKey.java line
>> 74:
>>
>>> 72: */
>>> 73: @Override
>>> 74: default AlgorithmParameterSpec getParams() {
>>
>> What is the benefit of overriding this method if i
On Thu, 26 Oct 2023 02:43:14 GMT, Weijun Wang wrote:
>> Create a parent interface `AsymmetricKey` for `PublicKey` and `PrivateKey`
>> and add a `getParams` method there. This makes it available to all current
>> and future public and private keys.
>>
>> No test. Might add one.
>
> Weijun Wang
On Mon, 23 Oct 2023 21:07:09 GMT, Weijun Wang wrote:
> Rename the test.
This pull request has now been integrated.
Changeset: a9b31b58
Author:Weijun Wang
URL:
https://git.openjdk.org/jdk/commit/a9b31b587c7487b773debde1ce2227884959
Stats: 2 lines in 1 file changed: 0 ins; 0 d
On Mon, 23 Oct 2023 21:07:09 GMT, Weijun Wang wrote:
> Rename the test.
Marked as reviewed by mullan (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16323#pullrequestreview-1700078879
On Wed, 25 Oct 2023 08:44:29 GMT, Leo Korinth wrote:
>> This pull request renames `createJavaProcessBuilder` to
>> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to
>> `createTestJavaProcessBuilder`. Both are implemented through a private
>> `createJavaProcessBuilder`. It al
On Wed, 25 Oct 2023 08:44:29 GMT, Leo Korinth wrote:
>> This pull request renames `createJavaProcessBuilder` to
>> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to
>> `createTestJavaProcessBuilder`. Both are implemented through a private
>> `createJavaProcessBuilder`. It al
On Thu, 26 Oct 2023 14:19:32 GMT, Andrew John Hughes wrote:
>>> > Hi @gnu-andrew,
>>> > in your last example, why does it look for both arm and x64 packages? And
>>> > why for kFreeBsd? I see you have both hardcoded, why?
>>> > I would expect it only to attempt and pick up the architecture and O
On Wed, 30 Aug 2023 06:25:44 GMT, Thomas Stuefe wrote:
>>> Changes look fine. I submitted a mach5 test job just in case. Will approve
>>> once the test job passes. BTW, I added a noreg-other label since there is
>>> no regression test for this change.
>>
>> Thanks. Yes, I don't see how we can
On Fri, 20 Oct 2023 02:29:15 GMT, Chen Liang wrote:
>> Please review a patch that renames `JavaLangAccess::xxNoRepl` to
>> `xxReportError` to explicitly indicate these APIs report encoding errors.
>>
>> The old "NoRepl" suffix presumably means "No Replacement", but it has been
>> misunderstood
17 matches
Mail list logo
