Re: RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12 [v3]

2023-10-24 Thread Sean Mullan
On Thu, 12 Oct 2023 17:36:49 GMT, Kevin Driver wrote: >> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8308453: JSSE regression test keystore mig

Re: RFR: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12 [v4]

2023-10-24 Thread Kevin Driver
> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12 Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional com

Re: RFR: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer [v4]

2023-10-24 Thread Erik Joelsson
On Tue, 24 Oct 2023 19:58:58 GMT, Matthew Donovan wrote: >> Hello, >> >> In this PR I removed NSS tests from the ProblemList and updated NssTest to >> use Sqlite databases. I also removed code in PKCS11Test.java that falls back >> to NSS libraries installed on the test system. The tests can st

Re: RFR: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer [v4]

2023-10-24 Thread Matthew Donovan
> Hello, > > In this PR I removed NSS tests from the ProblemList and updated NssTest to > use Sqlite databases. I also removed code in PKCS11Test.java that falls back > to NSS libraries installed on the test system. The tests can still be run > with different NSS libraries but they have to be s

Re: RFR: 8315097: Rename createJavaProcessBuilder [v6]

2023-10-24 Thread Roger Riggs
On Tue, 24 Oct 2023 07:49:30 GMT, Leo Korinth wrote: >> This pull request renames `createJavaProcessBuilder` to >> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to >> `createTestJavaProcessBuilder`. Both are implemented through a private >> `createJavaProcessBuilder`. It al

Integrated: 8316964: Security tools should not call System.exit

2023-10-24 Thread Weijun Wang
On Wed, 27 Sep 2023 20:33:49 GMT, Weijun Wang wrote: > Remove most `System.exit()` calls in various security tools and only leave > one in the `main` method. This paves the way to convert them to JSR 199 tools. > > Note: before this change, the behavior of a successful `main()` method > execut

Re: RFR: 8316964: Security tools should not call System.exit [v6]

2023-10-24 Thread Valerie Peng
On Tue, 24 Oct 2023 16:37:12 GMT, Weijun Wang wrote: >> Remove most `System.exit()` calls in various security tools and only leave >> one in the `main` method. This paves the way to convert them to JSR 199 >> tools. >> >> Note: before this change, the behavior of a successful `main()` method

Re: RFR: 8315097: Rename createJavaProcessBuilder [v6]

2023-10-24 Thread Leonid Mesnik
On Tue, 24 Oct 2023 07:49:30 GMT, Leo Korinth wrote: >> This pull request renames `createJavaProcessBuilder` to >> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to >> `createTestJavaProcessBuilder`. Both are implemented through a private >> `createJavaProcessBuilder`. It al

Re: RFR: 8316964: Security tools should not call System.exit [v6]

2023-10-24 Thread Weijun Wang
> Remove most `System.exit()` calls in various security tools and only leave > one in the `main` method. This paves the way to convert them to JSR 199 tools. > > Note: before this change, the behavior of a successful `main()` method > execution is not consistent. Sometimes the method returns sil

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v6]

2023-10-24 Thread Hai-May Chao
On Fri, 20 Oct 2023 17:19:52 GMT, Xue-Lei Andrew Fan wrote: >> Hai-May Chao has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> co

Re: RFR: 8316964: Security tools should not call System.exit [v5]

2023-10-24 Thread Valerie Peng
On Wed, 18 Oct 2023 17:22:31 GMT, Andrey Turbanov wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> inline some throw statements, remove duplicated whitespaces > > src/java.security.jgss/windows/classes/sun/security/k

Integrated: 8318240: [AIX] Cleaners.java test failure

2023-10-24 Thread Varada M
On Tue, 17 Oct 2023 07:31:07 GMT, Varada M wrote: > When the test sets the sun.security.jgss.native and > sun.security.nativegss.debug as true, the test fails on AIX due to missing > Kerberos GSS API dynamic library` libgssapi_krb5.so` > > JBS Issue : [JDK-8318240](https://bugs.openjdk.org/br

Re: RFR: 8315097: Rename createJavaProcessBuilder [v6]

2023-10-24 Thread Stefan Karlsson
On Tue, 24 Oct 2023 07:49:30 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: RFR: 8315097: Rename createJavaProcessBuilder [v6]

2023-10-24 Thread Leo Korinth
On Tue, 24 Oct 2023 07:49:30 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: RFR: 8315097: Rename createJavaProcessBuilder [v6]

2023-10-24 Thread Leo Korinth
> Rename createJavaProcessBuilder so that it is not used by mistake instead of > createTestJvm. > > I have used the following sed script: `find -name "*.java" | xargs -n 1 sed > -i -e > "s/createJavaProcessBuilder(/createJavaProcessBuilderIgnoreTestJavaOpts(/g"` > > Then I have manually modifi