> A few classes in `com.sun.crypto.provider` package have non-final fields
> which could easily be marked `final`.
Andrey Turbanov has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains four commits:
- Merge remote-tracking branch 'origin/
On Mon, 16 Oct 2023 15:04:51 GMT, Matthias Baesken wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> windows aarch64 build issues
>
> Hello, any comments about the idea of calling into 'os::dll_load' instead ?
>
On Tue, 17 Oct 2023 19:48:26 GMT, Weijun Wang wrote:
>> Add `getParams` to `PublicKey` and `PrivateKey` so it's available to all
>> current and future public and private keys.
>>
>> No test. Might add one.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit
> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank
> you.
Hai-May Chao has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains six
> Add `getParams` to `PublicKey` and `PrivateKey` so it's available to all
> current and future public and private keys.
>
> No test. Might add one.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
add spaces and code tags, and a test
On Tue, 17 Oct 2023 18:03:33 GMT, Weijun Wang wrote:
> The comparison should have been done in case-insensitive mode.
>
> The new test confirms the change inside `DHKEM.java`. The one in
> `XDHPrivateKeyImpl.java` is not easy to confirm. The SUN provider's
> implementation always got the name
On Tue, 17 Oct 2023 18:03:33 GMT, Weijun Wang wrote:
> The comparison should have been done in case-insensitive mode.
>
> The new test confirms the change inside `DHKEM.java`. The one in
> `XDHPrivateKeyImpl.java` is not easy to confirm. The SUN provider's
> implementation always got the name
On Tue, 17 Oct 2023 18:03:33 GMT, Weijun Wang wrote:
> The comparison should have been done in case-insensitive mode.
>
> The new test confirms the change inside `DHKEM.java`. The one in
> `XDHPrivateKeyImpl.java` is not easy to confirm. The SUN provider's
> implementation always got the name
On Tue, 17 Oct 2023 15:30:03 GMT, Weijun Wang wrote:
> Add `getParams` to `PublicKey` and `PrivateKey` so it's available to all
> current and future public and private keys.
>
> No test. Might add one.
src/java.base/share/classes/java/security/PrivateKey.java line 86:
> 84: * The default
On Tue, 17 Oct 2023 18:03:33 GMT, Weijun Wang wrote:
> The comparison should have been done in case-insensitive mode.
>
> The new test confirms the change inside `DHKEM.java`. The one in
> `XDHPrivateKeyImpl.java` is not easy to confirm. The SUN provider's
> implementation always got the name
The comparison should have been done in case-insensitive mode.
The new test confirms the change inside `DHKEM.java`. The one in
`XDHPrivateKeyImpl.java` is not easy to confirm. The SUN provider's
implementation always got the name "correct".
-
Commit messages:
- the fix
Changes:
On Tue, 17 Oct 2023 14:22:10 GMT, Shaojin Wen wrote:
>> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
>> use try...catch to handle CharacterCodingException and throw
>> IllegalArgumentException instead of CharacterCodingException to make the
>> calling code cleane
On Wed, 11 Oct 2023 22:05:08 GMT, Smita Kamath wrote:
>> Hi All,
>> I would like to submit AES-GCM optimization for x86_64 architectures using
>> AVX2 instructions. This optimization interleaves AES and GHASH operations.
>>
>> Below are the performance numbers on my desktop system with -XX:Use
Hi Karl,
I discussed your proposal with some other colleagues.
We generally feel a PEM KeyStore would be a useful addition to the JDK. This
would alleviate usability issues that many users encounter when configuring and
deploying applications that store keys or certificates in PEM files.
Howev
Add `getParams` to `PublicKey` and `PrivateKey` so it's available to all
current and future public and private keys.
No test. Might add one.
-
Commit messages:
- 8318096: Add getParams method in PublicKey and PrivateKey
Changes: https://git.openjdk.org/jdk/pull/16222/files
Webrev
On Tue, 17 Oct 2023 14:30:26 GMT, Shaojin Wen wrote:
> @wenshao The proposal changes the exception types for seemingly no reason.
> What concrete problem does this enhancement PR address?
@rgiulietti The API was exposed to create a String without duplicating an array
in compatible encoding. Ini
On Tue, 17 Oct 2023 14:09:08 GMT, Raffaello Giulietti
wrote:
> @wenshao The proposal changes the exception types for seemingly no reason.
> What concrete problem does this enhancement PR address?
@lianch 's suggestion in PR #14812 :
"Make the NoRepl methods throw IllegalArgument (like NoRepl1
> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
> use try...catch to handle CharacterCodingException and throw
> IllegalArgumentException instead of CharacterCodingException to make the
> calling code cleaner.
Shaojin Wen has updated the pull request incrementally
On Tue, 17 Oct 2023 11:11:52 GMT, Shaojin Wen wrote:
>> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
>> use try...catch to handle CharacterCodingException and throw
>> IllegalArgumentException instead of CharacterCodingException to make the
>> calling code cleane
> Rename createJavaProcessBuilder so that it is not used by mistake instead of
> createTestJvm.
>
> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
> -i -e
> "s/createJavaProcessBuilder(/createJavaProcessBuilderIgnoreTestJavaOpts(/g"`
>
> Then I have manually modifi
On Tue, 17 Oct 2023 11:11:52 GMT, Shaojin Wen wrote:
>> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
>> use try...catch to handle CharacterCodingException and throw
>> IllegalArgumentException instead of CharacterCodingException to make the
>> calling code cleane
On Tue, 17 Oct 2023 11:11:52 GMT, Shaojin Wen wrote:
>> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
>> use try...catch to handle CharacterCodingException and throw
>> IllegalArgumentException instead of CharacterCodingException to make the
>> calling code cleane
> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
> use try...catch to handle CharacterCodingException and throw
> IllegalArgumentException instead of CharacterCodingException to make the
> calling code cleaner.
Shaojin Wen has updated the pull request incrementally
On Tue, 17 Oct 2023 10:42:59 GMT, Shaojin Wen wrote:
>> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
>> use try...catch to handle CharacterCodingException and throw
>> IllegalArgumentException instead of CharacterCodingException to make the
>> calling code cleane
> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
> use try...catch to handle CharacterCodingException and throw
> IllegalArgumentException instead of CharacterCodingException to make the
> calling code cleaner.
Shaojin Wen has updated the pull request incrementally
On Tue, 17 Oct 2023 03:09:09 GMT, Chen Liang wrote:
> The thrown CCE was intended for `Files.readString` and `Files.writeString`,
> and is in reality, only used by those 2 sites. However, you missed updating
> those sites, so they now throw IAE instead of CCE, which should be fixed.
Right, the
On Tue, 17 Oct 2023 03:09:09 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix from @liach 's review
>
> The thrown CCE was intended for `Files.readString` and `Files.writeString`,
> and is in rea
When the test sets the sun.security.jgss.native and
sun.security.nativegss.debug as true, the test fails on AIX due to missing
Kerberos GSS API dynamic library` libgssapi_krb5.so`
JBS Issue : [JDK-8318240](https://bugs.openjdk.org/browse/JDK-8318240)
-
Commit messages:
- fix for
28 matches
Mail list logo
