Re: RFR: 8316964: Security tools should not call System.exit [v3]

2023-10-13 Thread Valerie Peng
On Tue, 10 Oct 2023 21:11:21 GMT, Weijun Wang wrote: >> Remove most `System.exit()` calls in various security tools and only leave >> one in the `main` method. This paves the way to convert them to JSR 199 >> tools. >> >> Note: before this change, the behavior of a successful `main()` method

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v4]

2023-10-13 Thread Weijun Wang
On Fri, 13 Oct 2023 22:57:25 GMT, Hai-May Chao wrote: >> If I understand correctly, "jdk.tls.maxClientCertificateChainLength" is >> meant to override "jdk.tls.maxClientCertificateChainLength" if both are >> defined. Then what would happen if user has specified >> `-Djdk.tls.maxClientCertificat

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v4]

2023-10-13 Thread Hai-May Chao
On Fri, 13 Oct 2023 21:43:58 GMT, Weijun Wang wrote: >> Since 8 is the default for "jdk.tls.maxClientCertificateChainLength", it is >> going to be overridden when "jdk.tls.maxCertificateChainLength" is set. >> Setting "jdk.tls.maxClientCertificateChainLength" to 8 is treated as keeping >> the

Re: RFR: 8316964: Security tools should not call System.exit [v3]

2023-10-13 Thread Weijun Wang
On Fri, 13 Oct 2023 19:31:21 GMT, Valerie Peng wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> typo > > src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Klist.java > line 155: > >> 153:

Re: RFR: 8316964: Security tools should not call System.exit [v4]

2023-10-13 Thread Weijun Wang
> Remove most `System.exit()` calls in various security tools and only leave > one in the `main` method. This paves the way to convert them to JSR 199 tools. > > Note: before this change, the behavior of a successful `main()` method > execution is not consistent. Sometimes the method returns sil

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v4]

2023-10-13 Thread Weijun Wang
On Fri, 13 Oct 2023 19:29:54 GMT, Hai-May Chao wrote: >> src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java line 173: >> >>> 171: */ >>> 172: if (maxCertificateChainLength > 0) { >>> 173: if (clientLen == 8) { >> >> If the user sets "jdk.tls.maxClien

Re: RFR: 8316964: Security tools should not call System.exit [v3]

2023-10-13 Thread Valerie Peng
On Tue, 10 Oct 2023 21:11:21 GMT, Weijun Wang wrote: >> Remove most `System.exit()` calls in various security tools and only leave >> one in the `main` method. This paves the way to convert them to JSR 199 >> tools. >> >> Note: before this change, the behavior of a successful `main()` method

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v4]

2023-10-13 Thread Hai-May Chao
On Fri, 13 Oct 2023 18:59:44 GMT, Weijun Wang wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change made to configure max allowed cert chain lengths based on updated >> CSR > > src/java.base/share/classes/sun/sec

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v4]

2023-10-13 Thread Hai-May Chao
On Fri, 13 Oct 2023 18:02:34 GMT, Mark Powers wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change made to configure max allowed cert chain lengths based on updated >> CSR > > src/java.base/share/classes/sun/sec

RFR: 8268916: Tests for AffirmTrust roots

2023-10-13 Thread Rajan Halade
Test is updated to include interoperability testing for 4 AffirmTrust root CAs. - Commit messages: - 8268916: Tests for AffirmTrust roots Changes: https://git.openjdk.org/jdk/pull/16190/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16190&range=00 Issue: https://bugs.open

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v4]

2023-10-13 Thread Weijun Wang
On Fri, 13 Oct 2023 16:04:48 GMT, Hai-May Chao wrote: >> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank >> you. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Change made to configure max all

Re: RFR: JDK-8314901: AES-GCM interleaved implementation using AVX2 instructions [v8]

2023-10-13 Thread Smita Kamath
On Wed, 11 Oct 2023 22:05:08 GMT, Smita Kamath wrote: >> Hi All, >> I would like to submit AES-GCM optimization for x86_64 architectures using >> AVX2 instructions. This optimization interleaves AES and GHASH operations. >> >> Below are the performance numbers on my desktop system with -XX:Use

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v4]

2023-10-13 Thread Mark Powers
On Fri, 13 Oct 2023 16:04:48 GMT, Hai-May Chao wrote: >> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank >> you. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Change made to configure max all

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v4]

2023-10-13 Thread Hai-May Chao
> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank > you. Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision: Change made to configure max allowed cert chain lengths based on updated CSR - Change