Re: RFR: JDK-8314901: AES-GCM interleaved implementation using AVX2 instructions [v7]

2023-10-10 Thread Sandhya Viswanathan
On Tue, 10 Oct 2023 23:49:18 GMT, Smita Kamath wrote: >> Hi All, >> I would like to submit AES-GCM optimization for x86_64 architectures using >> AVX2 instructions. This optimization interleaves AES and GHASH operations. >> >> Below are the performance numbers on my desktop system with -XX:Use

Re: RFR: JDK-8314901: AES-GCM interleaved implementation using AVX2 instructions [v7]

2023-10-10 Thread Smita Kamath
> Hi All, > I would like to submit AES-GCM optimization for x86_64 architectures using > AVX2 instructions. This optimization interleaves AES and GHASH operations. > > Below are the performance numbers on my desktop system with -XX:UseAVX=2 > option: > > |Benchmark | Data Size | Base version (

Re: RFR: JDK-8314901: AES-GCM interleaved implementation using AVX2 instructions [v6]

2023-10-10 Thread Smita Kamath
> Hi All, > I would like to submit AES-GCM optimization for x86_64 architectures using > AVX2 instructions. This optimization interleaves AES and GHASH operations. > > Below are the performance numbers on my desktop system with -XX:UseAVX=2 > option: > > |Benchmark | Data Size | Base version (

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

2023-10-10 Thread Valerie Peng
On Thu, 24 Aug 2023 08:53:53 GMT, Andrey Turbanov wrote: > A few classes in `com.sun.crypto.provider` package have non-final fields > which could easily be marked `final`. src/java.base/share/classes/com/sun/crypto/provider/TlsMasterSecretGenerator.java line 165: > 163: private static

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

2023-10-10 Thread Valerie Peng
On Thu, 24 Aug 2023 08:53:53 GMT, Andrey Turbanov wrote: > A few classes in `com.sun.crypto.provider` package have non-final fields > which could easily be marked `final`. src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java line 127: > 125: // Use the cleaner to zero

Re: RFR: 8316964: Security tools should not call System.exit [v3]

2023-10-10 Thread Weijun Wang
> Remove most `System.exit()` calls in various security tools and only leave > one in the `main` method. This paves the way to convert them to JSR 199 tools. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: typo - Changes

Re: RFR: 8316964: Security tools should not call System.exit [v2]

2023-10-10 Thread Weijun Wang
> Remove most `System.exit()` calls in various security tools and only leave > one in the `main` method. This paves the way to convert them to JSR 199 tools. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: let run return int

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

2023-10-10 Thread Valerie Peng
On Thu, 24 Aug 2023 08:53:53 GMT, Andrey Turbanov wrote: > A few classes in `com.sun.crypto.provider` package have non-final fields > which could easily be marked `final`. src/java.base/share/classes/com/sun/crypto/provider/JceKeyStore.java line 102: > 100: * Hash entries are keyed by ali

Re: RFR: 8314283: Support for NSS tests on aarch64 platforms [v3]

2023-10-10 Thread Rajan Halade
On Tue, 10 Oct 2023 17:17:45 GMT, Matthew Donovan wrote: >> This PR updates the version of NSS to 3.91 and includes aarch64 platforms. >> >> There is a related bug in PR (https://github.com/openjdk/jdk/pull/15217) so >> we may want to wait for that to merge before merging this one. > > Matthew

Re: RFR: 8314283: Support for NSS tests on aarch64 platforms [v3]

2023-10-10 Thread Matthew Donovan
> This PR updates the version of NSS to 3.91 and includes aarch64 platforms. > > There is a related bug in PR (https://github.com/openjdk/jdk/pull/15217) so > we may want to wait for that to merge before merging this one. Matthew Donovan has updated the pull request with a new target base due to