RFR: 8317332: Prepare security for permissive-

2023-09-29 Thread Julian Waters
Prepares java.security.jgss for the permissive- compiler switch by - Adding scopes so goto doesn't jump over unitialized locals in sspi.cpp - Adding a static modifier to a mismatched method declaration in NativeCreds.c, as the definition is static - Commit messages: - Prepare secur

Re: RFR: 8309356: Read files in includedir in alphanumeric order

2023-09-29 Thread Weijun Wang
On Fri, 29 Sep 2023 19:03:35 GMT, Sean Mullan wrote: > > @seanjmullan I've created a release-note at > > https://bugs.openjdk.org/browse/JDK-8317325. Please take a look. TIA. > > I would note the previous behavior, ex: "Prior to this change, the files were > read in no specific order." Thanks

Re: RFR: 8309356: Read files in includedir in alphanumeric order

2023-09-29 Thread Sean Mullan
On Thu, 28 Sep 2023 19:19:36 GMT, Sean Mullan wrote: >>> Is there any potential compatibility issue by reading the files in a >>> different order? >> >> There is a behavior change, but I doubt if anyone is using this feature. I'm >> following what MIT krb5 has fixed. I can add a release note i

Integrated: 8295919: java.security.MessageDigest.isEqual does not adhere to @implNote

2023-09-29 Thread Kevin Driver
On Tue, 26 Sep 2023 19:37:23 GMT, Kevin Driver wrote: > Fix JDK-8295919 by updating the javadoc to explain that a null or zero-length > `digestb` will also result in a short-circuit response This pull request has now been integrated. Changeset: 47569a25 Author:Kevin Driver URL: htt

Re: RFR: 8295919: java.security.MessageDigest.isEqual does not adhere to @implNote [v3]

2023-09-29 Thread Sean Mullan
On Fri, 29 Sep 2023 16:34:28 GMT, Kevin Driver wrote: >> Fix JDK-8295919 by updating the javadoc to explain that a null or >> zero-length `digestb` will also result in a short-circuit response > > Kevin Driver has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests [v2]

2023-09-29 Thread Valerie Peng
On Fri, 29 Sep 2023 07:41:08 GMT, Aleksey Shipilev wrote: >> Michal Sobierski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Better approach to parallelize sun/security/rsa/SignedObjectChain.java >> >> time make test TEST=jdk/sun/s

Re: RFR: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests [v2]

2023-09-29 Thread Valerie Peng
On Thu, 21 Sep 2023 13:26:14 GMT, Michal Sobierski wrote: >> sun/security/rsa/SignedObjectChain.java is very slow when run with C1, I >> suspect because some crypto intrinsics are only implemented in C2. Commit >> contains changes made to parallelize it. >> >> Comparison of before and after pa

Re: RFR: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests [v2]

2023-09-29 Thread Rajan Halade
On Thu, 21 Sep 2023 13:26:14 GMT, Michal Sobierski wrote: >> sun/security/rsa/SignedObjectChain.java is very slow when run with C1, I >> suspect because some crypto intrinsics are only implemented in C2. Commit >> contains changes made to parallelize it. >> >> Comparison of before and after pa

Re: RFR: 8309356: Read files in includedir in alphanumeric order

2023-09-29 Thread Weijun Wang
On Thu, 28 Sep 2023 19:19:36 GMT, Sean Mullan wrote: >>> Is there any potential compatibility issue by reading the files in a >>> different order? >> >> There is a behavior change, but I doubt if anyone is using this feature. I'm >> following what MIT krb5 has fixed. I can add a release note i

Re: RFR: 8295919: java.security.MessageDigest.isEqual does not adhere to @implNote [v3]

2023-09-29 Thread Kevin Driver
> Fix JDK-8295919 by updating the javadoc to explain that a null or zero-length > `digestb` will also result in a short-circuit response Kevin Driver has updated the pull request incrementally with one additional commit since the last revision: rephrased per code review - Change

Re: RFR: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests [v2]

2023-09-29 Thread Aleksey Shipilev
On Thu, 21 Sep 2023 13:26:14 GMT, Michal Sobierski wrote: >> sun/security/rsa/SignedObjectChain.java is very slow when run with C1, I >> suspect because some crypto intrinsics are only implemented in C2. Commit >> contains changes made to parallelize it. >> >> Comparison of before and after pa