Re: RFR: 8314283: Support for NSS tests on aarch64 platforms

2023-09-26 Thread Matthew Donovan
On Fri, 25 Aug 2023 13:02:39 GMT, Matthew Donovan wrote: > This PR updates the version of NSS to 3.91 and includes aarch64 platforms. > > There is a related bug in PR (https://github.com/openjdk/jdk/pull/15217) so > we may want to wait for that to merge before merging this one. Waiting for htt

RFR: 8295919: java.security.MessageDigest.isEqual does not adhere to @implNote

2023-09-26 Thread Kevin Driver
Fix JDK-8295919 by updating the javadoc to explain that a null or zero-length `digestb` will also result in a short-circuit response - Commit messages: - update copyright year - Fix JDK-8295919 by updating the javadoc to explain that a null or zero-length will also result in a sh

Re: RFR: 8293176: SSLEngine handshaker does not send an alert after a bad parameters [v2]

2023-09-26 Thread Jamil Nimeh
On Fri, 11 Aug 2023 21:38:04 GMT, Daniel Jeliński wrote: >> Please review this patch that ensures that all exceptions thrown by >> SSLEngine delegated tasks are translated to alerts. >> >> All exceptions should already be translated to SSLExceptions and alerts by >> the time we exit from conte

Re: RFR: 8309667: TLS handshake fails because of ConcurrentModificationException in PKCS12KeyStore.engineGetEntry

2023-09-26 Thread Daniel Fuchs
On Tue, 26 Sep 2023 15:04:44 GMT, Daniel Jeliński wrote: >> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line >> 1270: >> >>> 1268: } >>> 1269: Entry entry = entries.get(alias.toLowerCase(Locale.ENGLISH)); >>> 1270: return Collections.unmodifiableS

Re: RFR: 8309667: TLS handshake fails because of ConcurrentModificationException in PKCS12KeyStore.engineGetEntry

2023-09-26 Thread Daniel Jeliński
On Tue, 26 Sep 2023 14:46:46 GMT, Daniel Fuchs wrote: >> A different fix after https://github.com/openjdk/jdk/pull/14506 was closed. >> >> Still haven't made the attributes set immutable but at least it is populated >> before an entry is added to `entries` and it will never be modified later. >

Re: RFR: 8309667: TLS handshake fails because of ConcurrentModificationException in PKCS12KeyStore.engineGetEntry

2023-09-26 Thread Daniel Fuchs
On Mon, 25 Sep 2023 18:12:32 GMT, Weijun Wang wrote: > A different fix after https://github.com/openjdk/jdk/pull/14506 was closed. > > Still haven't made the attributes set immutable but at least it is populated > before an entry is added to `entries` and it will never be modified later. > > I

Re: RFR: JDK-8316671: sun/security/ssl/SSLSocketImpl/SSLSocketCloseHang.java test fails intermittent with Read timed out

2023-09-26 Thread Matthias Baesken
On Tue, 26 Sep 2023 07:23:20 GMT, Matthias Baesken wrote: > We sometimes run into the following error. This especially occurs when > running with fastdebug binaries and on Linux ppc64le machines. > Current timeout set in the test is 1 second. > > Server accepting: 315357614990101 > Server accep

Integrated: JDK-8316671: sun/security/ssl/SSLSocketImpl/SSLSocketCloseHang.java test fails intermittent with Read timed out

2023-09-26 Thread Matthias Baesken
On Tue, 26 Sep 2023 07:23:20 GMT, Matthias Baesken wrote: > We sometimes run into the following error. This especially occurs when > running with fastdebug binaries and on Linux ppc64le machines. > Current timeout set in the test is 1 second. > > Server accepting: 315357614990101 > Server accep

Re: Question on JDK-8058778 (New APIs for creating certificates and certificate requests)

2023-09-26 Thread Robert Sherwood
Ah, if I understand correctly, it’s more a question of whether full PKI functionality is something better provided by a third party e.g. BouncyCastle vs. maintaining it in the mainline JDK. That makes sense. Thanks for the response! Rob From: Sean Mullan Date: Tuesday, September 26, 2023 at 9

Re: RFR: JDK-8316671: sun/security/ssl/SSLSocketImpl/SSLSocketCloseHang.java test fails intermittent with Read timed out

2023-09-26 Thread Lutz Schmidt
On Tue, 26 Sep 2023 07:23:20 GMT, Matthias Baesken wrote: > We sometimes run into the following error. This especially occurs when > running with fastdebug binaries and on Linux ppc64le machines. > Current timeout set in the test is 1 second. > > Server accepting: 315357614990101 > Server accep

Re: Question on JDK-8058778 (New APIs for creating certificates and certificate requests)

2023-09-26 Thread Sean Mullan
Hi, On Sep 26, 2023, at 6:19 AM, Robert Sherwood mailto:robert.sherw...@credentive.com>> wrote: Hello everyone – I hope this is not too silly a question. I am doing some Java based PKI work for a client and have discovered the long outstanding JDK-8058778. I am curious about the difficulty of

Question on JDK-8058778 (New APIs for creating certificates and certificate requests)

2023-09-26 Thread Robert Sherwood
Hello everyone – I hope this is not too silly a question. I am doing some Java based PKI work for a client and have discovered the long outstanding JDK-8058778. I am curious about the difficulty of this request. I assume that it must be a very complicated problem to be open for so long. It seem

RFR: JDK-8316671: sun/security/ssl/SSLSocketImpl/SSLSocketCloseHang.java test fails intermittent with Read timed out

2023-09-26 Thread Matthias Baesken
We sometimes run into the following error. This especially occurs when running with fastdebug binaries and on Linux ppc64le machines. Current timeout set in the test is 1 second. Server accepting: 315357614990101 Server accepted: 315359219006041 Client starting handshake: 315359228098300 java.net