Re: RFR: 8309667: TLS handshake fails because of ConcurrentModificationException in PKCS12KeyStore.engineGetEntry

2023-09-25 Thread Daniel Jeliński
On Mon, 25 Sep 2023 18:12:32 GMT, Weijun Wang wrote: > A different fix after https://github.com/openjdk/jdk/pull/14506 was closed. > > Still haven't made the attributes set immutable but at least it is populated > before an entry is added to `entries` and it will never be modified later. > > I

Re: RFR: 4964430: (spec) missing IllegalStateException exception requirement for javax.crypto.Cipher.doFinal [v2]

2023-09-25 Thread Valerie Peng
On Thu, 14 Sep 2023 18:43:10 GMT, Ben Perez wrote: >> Updated IllegalStateException exception requirements for `update`, >> `doFinal`, `wrap`, and `unwrap` > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > Removed periods at en

Re: RFR: JDK-8314901: AES-GCM interleaved implementation using AVX2 instructions [v2]

2023-09-25 Thread Sandhya Viswanathan
On Wed, 13 Sep 2023 20:25:22 GMT, Smita Kamath wrote: >> Hi All, >> I would like to submit AES-GCM optimization for x86_64 architectures using >> AVX2 instructions. This optimization interleaves AES and GHASH operations. >> >> Below are the performance numbers on my desktop system with -XX:Use

RFR: 8309667: TLS handshake fails because of ConcurrentModificationException in PKCS12KeyStore.engineGetEntry

2023-09-25 Thread Weijun Wang
A different fix after https://github.com/openjdk/jdk/pull/14506 was closed. Still haven't made the attributes set immutable but at least it is populated before an entry is added to `entries` and it will never be modified later. I tried the newly added `AttributesMultiThread.java` test hundreds o

RFR: 8316771: Krb5.java has not defined messages for all error codes

2023-09-25 Thread Weijun Wang
Added 4 missing error codes and removed 2 wrong ones. KRB_AP_ERR_NOREALM claims itself to be "used in setDefaultCreds() in sun.security.krb5.Credentials" but it's no more. KRB_AP_ERR_GEN_CRED is used in one place but it's a local error and not meant to be embedded in a message. Therefore safe t

RFR: 8309356: Read files in includedir in alphanumeric order

2023-09-25 Thread Weijun Wang
Read files in `includedir` in alphanumerical order. - Commit messages: - remove x bits - the fix Changes: https://git.openjdk.org/jdk/pull/15889/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15889&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309356 Stats: 77 l

Re: RFR: 8309667: TLS handshake fails because of ConcurrentModificationException in PKCS12KeyStore.engineGetEntry [v3]

2023-09-25 Thread Weijun Wang
On Fri, 16 Jun 2023 12:52:00 GMT, Weijun Wang wrote: >> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be >> modified and retrieved at the same time. Make it concurrent. >> >> The test uses some reflection to get this field and try updating it in >> multiple threads. > >

Re: RFR: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests [v2]

2023-09-25 Thread Aleksey Shipilev
On Thu, 21 Sep 2023 13:26:14 GMT, Michal Sobierski wrote: >> sun/security/rsa/SignedObjectChain.java is very slow when run with C1, I >> suspect because some crypto intrinsics are only implemented in C2. Commit >> contains changes made to parallelize it. >> >> Comparison of before and after pa

Re: RFR: JDK-8315042 NPE in PKCS7.parseOldSignedData [v3]

2023-09-25 Thread Weijun Wang
On Mon, 25 Sep 2023 03:40:47 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8315042 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > comment from Weijun test/jdk/sun/security/x509/X509CRLImpl/UnexpectedNPE.ja

Integrated: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java

2023-09-25 Thread Ian Myers
On Thu, 7 Sep 2023 13:23:01 GMT, Ian Myers wrote: > sun/security/util/math/TestIntegerModuloP.java runs in tier2 and takes about > 600 seconds to run. Thus, it drags the execution time of tier2 on large > machines. We can split the run configurations a bit so that test is more > parallel. >

Re: RFR: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java

2023-09-25 Thread Ian Myers
On Mon, 18 Sep 2023 05:55:20 GMT, Aleksey Shipilev wrote: >> Thanks for bringing this to my attention. If you believe the test change >> will make it run smoother, just do it. > >> Thanks for bringing this to my attention. If you believe the test change >> will make it run smoother, just do it.