Re: RFR: JDK-8314901: AES-GCM interleaved implementation using AVX2 instructions

2023-09-07 Thread Smita Kamath
On Thu, 7 Sep 2023 23:23:13 GMT, Smita Kamath wrote: >> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java >> line 590: >> >>> 588: private static int implGCMCrypt(byte[] in, int inOfs, int inLen, >>> byte[] ct, >>> 589: int ctOfs

Re: RFR: JDK-8314901: AES-GCM interleaved implementation using AVX2 instructions

2023-09-07 Thread Smita Kamath
On Mon, 4 Sep 2023 15:00:23 GMT, Ferenc Rakoczi wrote: >> Hi All, >> I would like to submit AES-GCM optimization for x86_64 architectures using >> AVX2 instructions. This optimization interleaves AES and GHASH operations. >> >> Below are the performance numbers on my desktop system with -XX:Us

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v3]

2023-09-07 Thread Tim Prinzing
On Tue, 22 Aug 2023 07:18:21 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/net/Socket.java line 1133: >> >>> 1131: return parent.getSoTimeout(); >>> 1132: } catch (Throwable t) { >>> 1133: // ignored - avoiding exceptions in jfr event da

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v5]

2023-09-07 Thread Tim Prinzing
> The socket read/write JFR events currently use instrumentation of java.base > code using templates in the jdk.jfr modules. This results in some java.base > code residing in the jdk.jfr module which is undesirable. > > JDK19 added static support for event classes. The old instrumentor classes

Re: RFR: 8304956: Update KeyStore.getDefaultType​() specification to return pkcs12 as fallback

2023-09-07 Thread Sean Coffey
On Thu, 7 Sep 2023 18:12:28 GMT, Ben Perez wrote: > Replaced "jks" with "pkcs12" in both the spec and fallback for > `KeyStore.getDefaultType()` looks like this comment in the same file could be updated also: (jks -> pkcs12) /* * Constant to lookup in the Security properties file to d

Re: RFR: 8304956: Update KeyStore.getDefaultType​() specification to return pkcs12 as fallback

2023-09-07 Thread Sean Mullan
On Thu, 7 Sep 2023 18:12:28 GMT, Ben Perez wrote: > Replaced "jks" with "pkcs12" in both the spec and fallback for > `KeyStore.getDefaultType()` > looks fine. Could you add some test code (perhaps to an existing test) for > this ? It should be trivial to test. > > I think you'll need a CSR al

Re: RFR: 8304956: Update KeyStore.getDefaultType​() specification to return pkcs12 as fallback

2023-09-07 Thread Sean Coffey
On Thu, 7 Sep 2023 18:12:28 GMT, Ben Perez wrote: > Replaced "jks" with "pkcs12" in both the spec and fallback for > `KeyStore.getDefaultType()` looks fine. Could you add some test code (perhaps to an existing test) for this ? It should be trivial to test. I think you'll need a CSR also

Re: RFR: 8304956: Update KeyStore.getDefaultType​() specification to return pkcs12 as fallback

2023-09-07 Thread Findoboutme32
On Thu, 7 Sep 2023 18:12:28 GMT, Ben Perez wrote: > Replaced "jks" with "pkcs12" in both the spec and fallback for > `KeyStore.getDefaultType()` Marked as reviewed by findoboutm...@github.com (no known OpenJDK username). - PR Review: https://git.openjdk.org/jdk/pull/15625#pullrequ

RFR: 8304956: Update KeyStore.getDefaultType​() specification to return pkcs12 as fallback

2023-09-07 Thread Ben Perez
Replaced "jks" with "pkcs12" in both the spec and fallback for `KeyStore.getDefaultType()` - Commit messages: - removed jks as fallback keystore and replaced with pkcs12 Changes: https://git.openjdk.org/jdk/pull/15625/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15625&ra