Re: RFR: 8293176: SSLEngine handshaker does not send an alert after a bad parameters [v2]

2023-09-06 Thread Daniel Jeliński
On Fri, 11 Aug 2023 21:38:04 GMT, Daniel Jeliński wrote: >> Please review this patch that ensures that all exceptions thrown by >> SSLEngine delegated tasks are translated to alerts. >> >> All exceptions should already be translated to SSLExceptions and alerts by >> the time we exit from conte

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v4]

2023-09-06 Thread Alan Bateman
On Wed, 6 Sep 2023 15:55:21 GMT, Tim Prinzing wrote: > I think it's useful if trying to trace the calls (i.e. set to 0ms). > Apparently the security manager was being used for that by some. The SM isn't called once connected so I don't think anyone could have every done that. Yes, you could se

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v2]

2023-09-06 Thread Jamil Nimeh
On Wed, 6 Sep 2023 20:02:10 GMT, Hai-May Chao wrote: >> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank >> you. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Set to default if a negative valu

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v2]

2023-09-06 Thread Hai-May Chao
> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank > you. Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision: Set to default if a negative value is set - Changes: - all: https://git.openjdk.org

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v2]

2023-09-06 Thread Hai-May Chao
On Mon, 7 Aug 2023 17:23:11 GMT, Jamil Nimeh wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Set to default if a negative value is set > > src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java line 159

Re: RFR: 8311596: Add separate system properties for TLS server and client for maximum chain length [v2]

2023-09-06 Thread Hai-May Chao
On Mon, 7 Aug 2023 15:36:54 GMT, Mark Powers wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Set to default if a negative value is set > > src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java line 115

RFR: 8315810: Reimplement ReflectionFactory::newConstructorForSerialization with method handles

2023-09-06 Thread Mandy Chung
This reimplements `sun.reflect.ReflectionFactory::newConstructorForSerialization` with method handles. This API currently generates the bytecode which fails the verification because `new C; invokespecial A()` where the given class `C` and invoke a no-arg constructor of `C`'s first non-`Seriali

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Alan Bateman
On Wed, 6 Sep 2023 16:49:39 GMT, Chris Plummer wrote: > > I wonder if this is the right thing to do for the hprof files. I believe > > they originated from some hprof tools that we no longer ship. 3rd parties > > might choose to integrate them into their own tools. > > Do you think I should re

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Chris Plummer
On Wed, 6 Sep 2023 16:06:29 GMT, Erik Joelsson wrote: > > I wonder if this is the right thing to do for the hprof files. I believe > > they originated from some hprof tools that we no longer ship. 3rd parties > > might choose to integrate them into their own tools. > > Do you think I should re

Re: RFR: 8315097: Rename createJavaProcessBuilder [v3]

2023-09-06 Thread Leo Korinth
On Wed, 30 Aug 2023 09:23:55 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Erik Joelsson
On Tue, 5 Sep 2023 23:12:51 GMT, Chris Plummer wrote: > I wonder if this is the right thing to do for the hprof files. I believe they > originated from some hprof tools that we no longer ship. 3rd parties might > choose to integrate them into their own tools. Do you think I should revert them?

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Iris Clark
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v4]

2023-09-06 Thread Tim Prinzing
On Tue, 22 Aug 2023 07:31:36 GMT, Alan Bateman wrote: > > https://bugs.openjdk.org/browse/JDK-8310979 - better exception handling > > https://bugs.openjdk.org/browse/JDK-8310978 - missing code paths for event > > generation https://bugs.openjdk.org/browse/JDK-8310994 - non-blocking, > > event

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Alexey Ivanov
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Daniel Fuchs
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Alan Bateman
On Tue, 5 Sep 2023 23:15:53 GMT, Jonathan Gibbons wrote: > One has to wonder about the `**/*_OLD.java` files, but that would be a > different cleanup The IBM double byte charsets were re-implemented in JDK 7. I think the old implementations moved to the test tree so it could be used to test th