Re: RFR: 8315097: Rename createJavaProcessBuilder [v3]

2023-08-30 Thread Alan Bateman
On Wed, 30 Aug 2023 17:38:01 GMT, Stefan Karlsson wrote: > I wouldn't be opposed to a change that: > > * Keeps the `createJavaProcessBuilder` name > * Renames `createTestJvm` to `createJavaProcessBuilderPrependTestOpts` > * Renames `executeTestJvm` to `executeJavaPrependTestOpts` > * Removes `cr

Re: RFR: 8315097: Rename createJavaProcessBuilder [v3]

2023-08-30 Thread David Holmes
On Wed, 30 Aug 2023 11:31:20 GMT, Mark Sheppard wrote: > So you could create a single createJavaProcessBuilder with add an additional > parameter boolean addTestOpts e.g. createJavaProcessBuilder(List command, boolean addTestOpts) { ... } @msheppar that is actually where we started, and it was

Re: RFR: JDK-8315422: getSoTimeout() would be in try block in SSLSocketImpl

2023-08-30 Thread Jamil Nimeh
On Thu, 31 Aug 2023 02:34:58 GMT, John Jiang wrote: > The method `SSLSocketImpl::closeSocket` has the below code snippet, > > > if (appInput.readLock.tryLock()) { > int soTimeout = getSoTimeout(); > try { > // deplete could hang on the skip operation > // in case of infi

RFR: JDK-8315422: getSoTimeout() would be in try block in SSLSocketImpl

2023-08-30 Thread John Jiang
The method `SSLSocketImpl::closeSocket` has the below code snippet, if (appInput.readLock.tryLock()) { int soTimeout = getSoTimeout(); try { // deplete could hang on the skip operation // in case of infinite socket read timeout. // Change read timeout to avoid dead

RFR: 8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with ProviderException

2023-08-30 Thread Rajan Halade
This test is removed from ProblemList. I ran test locally and on CI with hundred iteration. Failure is not seen as [JDK-8240256](https://bugs.openjdk.org/browse/JDK-8240256) is fixed. - Commit messages: - 8161536: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails with Pro

Re: RFR: 8315097: Rename createJavaProcessBuilder [v3]

2023-08-30 Thread Stefan Karlsson
On Wed, 30 Aug 2023 09:23:55 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: RFR: 8315097: Rename createJavaProcessBuilder [v3]

2023-08-30 Thread Leo Korinth
On Wed, 30 Aug 2023 09:23:55 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: RFR: 8315097: Rename createJavaProcessBuilder [v3]

2023-08-30 Thread Roger Riggs
On Wed, 30 Aug 2023 09:23:55 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: RFR: 8315097: Rename createJavaProcessBuilder [v3]

2023-08-30 Thread Mark Sheppard
On Wed, 30 Aug 2023 09:23:55 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: RFR: 8315097: Rename createJavaProcessBuilder [v3]

2023-08-30 Thread Leo Korinth
> Rename createJavaProcessBuilder so that it is not used by mistake instead of > createTestJvm. > > I have used the following sed script: `find -name "*.java" | xargs -n 1 sed > -i -e > "s/createJavaProcessBuilder(/createJavaProcessBuilderIgnoreTestJavaOpts(/g"` > > Then I have manually modifi

Re: RFR: 8315097: Rename createJavaProcessBuilder [v2]

2023-08-30 Thread David Holmes
On Tue, 29 Aug 2023 16:45:12 GMT, Roger Riggs wrote: >> I don't think this is the best change across so many files. >> It gives a very ugly name to a common test function and affects a very large >> number of tests. > >> @RogerRiggs If it is only the name you want changed, maybe you can offer a