Re: RFR: 8009550: PlatformPCSC should load versioned so

2023-08-29 Thread Thomas Stuefe
On Wed, 30 Aug 2023 01:06:01 GMT, Andrew John Hughes wrote: >> Changes look fine. I submitted a mach5 test job just in case. Will approve >> once the test job passes. >> BTW, I added a noreg-other label since there is no regression test for this >> change. > >> Changes look fine. I submitted a

Re: RFR: 8009550: PlatformPCSC should load versioned so

2023-08-29 Thread Thomas Stuefe
On Thu, 24 Aug 2023 00:53:03 GMT, Andrew John Hughes wrote: > There is a long standing limitation in the UNIX smartcardio implementation > which means it will only look for the `pcsclite` library in two locations; > `/usr/lib` and `/usr/local/lib`. It also only searches for an unversioned > li

Re: RFR: 8009550: PlatformPCSC should load versioned so

2023-08-29 Thread Andrew John Hughes
On Fri, 25 Aug 2023 00:39:14 GMT, Valerie Peng wrote: > Changes look fine. I submitted a mach5 test job just in case. Will approve > once the test job passes. BTW, I added a noreg-other label since there is no > regression test for this change. Thanks. Yes, I don't see how we can have a regres

Re: RFR: 8009550: PlatformPCSC should load versioned so

2023-08-29 Thread Andrew John Hughes
On Fri, 25 Aug 2023 05:39:39 GMT, Thomas Stuefe wrote: > Hi @gnu-andrew, > > in your last example, why does it look for both arm and x64 packages? And why > for kFreeBsd? I see you have both hardcoded, why? > > I would expect it only to attempt and pick up the architecture and OS the VM > was

Re: RFR: 8309330: Allow java.security to be extended via a properties directory [v2]

2023-08-29 Thread Andrew John Hughes
On Thu, 24 Aug 2023 01:27:55 GMT, Martin Balao wrote: > As commented here [1], @franferrax and I have been working on a different > approach to this problem. We suggest to put this PR on hold until we have our > proposal ready to compare and discuss further. > > -- [1] - > https://bugs.openjd

Integrated: 8312428: PKCS11 tests fail with NSS 3.91

2023-08-29 Thread Valerie Peng
On Thu, 10 Aug 2023 00:56:56 GMT, Valerie Peng wrote: > Starting NSS v3.91, SHA-3 support is added for MessageDigest but not for PSS > Signature. This breaks existing test assumptions made by PSS regression > tests. In addition, the NSS SHA-3 message digests do not support cloning > which caus

Re: RFR: 8309330: Allow java.security to be extended via a properties directory [v3]

2023-08-29 Thread Andrew John Hughes
> Currently, security properties are held within the `java.security` file in > the JDK tree for each installed JDK. The system property > `java.security.properties` can be used to point to a file containing > additional properties. These can be appended to the existing set or override > all exi

Re: RFR: 8312306: Add more Reference.reachabilityFence() calls to the security classes using Cleaner

2023-08-29 Thread Anthony Scarpino
On Tue, 22 Aug 2023 18:06:59 GMT, Valerie Peng wrote: > This PR updates the various security classes using Cleaner with the > try/finally pattern. Also noticed that SunJCE's PBEKey impl class overrides > the destroy() method but not the isDestroyed() method, fixed this > inconsistency as well.

Re: RFR: 8315097: Rename createJavaProcessBuilder [v2]

2023-08-29 Thread Chris Plummer
On Tue, 29 Aug 2023 09:12:51 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: RFR: 8314283: Support for NSS tests on aarch64 platforms

2023-08-29 Thread Rajan Halade
On Fri, 25 Aug 2023 13:02:39 GMT, Matthew Donovan wrote: > This PR updates the version of NSS to 3.91 and includes aarch64 platforms. > > There is a related bug in PR (https://github.com/openjdk/jdk/pull/15217) so > we may want to wait for that to merge before merging this one. Please check li

Re: RFR: 8315097: Rename createJavaProcessBuilder [v2]

2023-08-29 Thread Roger Riggs
On Tue, 29 Aug 2023 14:06:01 GMT, Roger Riggs wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> copyright > > I don't think this is the best change across so many files. > It gives a very ugly name to a common test fu

Re: RFR: 8312428: PKCS11 tests fail with NSS 3.91 [v4]

2023-08-29 Thread Rajan Halade
On Fri, 25 Aug 2023 22:42:05 GMT, Valerie Peng wrote: >> Starting NSS v3.91, SHA-3 support is added for MessageDigest but not for PSS >> Signature. This breaks existing test assumptions made by PSS regression >> tests. In addition, the NSS SHA-3 message digests do not support cloning >> which

Re: RFR: 8315097: Rename createJavaProcessBuilder [v2]

2023-08-29 Thread Leo Korinth
On Tue, 29 Aug 2023 14:06:01 GMT, Roger Riggs wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> copyright > > I don't think this is the best change across so many files. > It gives a very ugly name to a common test fu

Re: RFR: 8315097: Rename createJavaProcessBuilder [v2]

2023-08-29 Thread Roger Riggs
On Tue, 29 Aug 2023 09:12:51 GMT, Leo Korinth wrote: >> Rename createJavaProcessBuilder so that it is not used by mistake instead of >> createTestJvm. >> >> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed >> -i -e >> "s/createJavaProcessBuilder(/createJavaProcessBu

Re: RFR: 8314283: Support for NSS tests on aarch64 platforms

2023-08-29 Thread Matthew Donovan
On Fri, 25 Aug 2023 13:02:39 GMT, Matthew Donovan wrote: > This PR updates the version of NSS to 3.91 and includes aarch64 platforms. > > There is a related bug in PR (https://github.com/openjdk/jdk/pull/15217) so > we may want to wait for that to merge before merging this one. If you have a l

Re: RFR: 8315097: Rename createJavaProcessBuilder [v2]

2023-08-29 Thread Leo Korinth
> Rename createJavaProcessBuilder so that it is not used by mistake instead of > createTestJvm. > > I have used the following sed script: `find -name "*.java" | xargs -n 1 sed > -i -e > "s/createJavaProcessBuilder(/createJavaProcessBuilderIgnoreTestJavaOpts(/g"` > > Then I have manually modifi