On Mon, 14 Aug 2023 20:57:24 GMT, Phil Race wrote:
> I have no time to look at the client changes for quite some time so do not
> push it. No matter how many other people approve it. And in the meantime you
> can (1) explain how many client tests you ran - and it had better be all of
> them :-
On Thu, 10 Aug 2023 19:36:28 GMT, Rajan Halade wrote:
>> Do you mean throw SkippedException if no digest algorithms are actually
>> tested with Clone functionality testing? Existing NSS impl seems to support
>> clone for non-SHA-3 digest impls.
>
> Yes, test should throw SkippedException when n
On Thu, 10 Aug 2023 20:05:21 GMT, Rajan Halade wrote:
> >
>
> Ok, lets address this update in a separate bug after validating all platforms.
Sounds good to me.
Do you have any comment that I have yet address?
-
PR Comment: https://git.openjdk.org/jdk/pull/15217#issuecomment-16782
On Mon, 14 Aug 2023 21:18:14 GMT, Sean Mullan wrote:
> I looked around, and I don't think there is an existing test that actually
> tests this behavior. So, I think we should add one. I think you can probably
> extend the existing `test/jdk/java/security/Provider/ChangeProviders.java`
> regres
On Fri, 11 Aug 2023 18:41:35 GMT, Ben Perez wrote:
>> Fixing the bug as stated would cause compatibility issues. E.g. the
>> `addProvider` function always adds new providers at position 0 and therefore
>> would always throw an error. Instead of changing how the function handles
>> indices, we
On Fri, 11 Aug 2023 20:15:59 GMT, Daniel Jeliński wrote:
>> Please review this patch that fixes the scope of 2 local variables to make
>> sure they are in scope when they are used.
>>
>> The patch additionally fixes one `c++11-narrowing` Clang warning by
>> explicitly casting string size (`siz
On Mon, 14 Aug 2023 21:20:42 GMT, Dean Long wrote:
> I had the same confusion, reading "-permissive-" the same as /permissive, but
> the trailing "-" means disable.
Ah, my brain just saw that trailing - as somebody's idea of hyphenation.
That's questionable syntax by the compiler IMO.
On Fri, 11 Aug 2023 23:08:56 GMT, Alexey Bakhtin wrote:
> JGSS is implemented in the JVM in 2 levels: the standard Java security
> provider for Kerberos in sun.security.jgss.krb5.Krb5MechFactory and the JAAS
> login module for Kerberos in com.sun.security.auth.module.Krb5LoginModule.
> The pro
On Thu, 10 Aug 2023 04:04:58 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signifi
On Fri, 11 Aug 2023 18:41:35 GMT, Ben Perez wrote:
>> Fixing the bug as stated would cause compatibility issues. E.g. the
>> `addProvider` function always adds new providers at position 0 and therefore
>> would always throw an error. Instead of changing how the function handles
>> indices, we
On Fri, 11 Aug 2023 18:41:35 GMT, Ben Perez wrote:
>> Fixing the bug as stated would cause compatibility issues. E.g. the
>> `addProvider` function always adds new providers at position 0 and therefore
>> would always throw an error. Instead of changing how the function handles
>> indices, we
On Thu, 10 Aug 2023 04:04:58 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signifi
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote:
> Currently there is a number of functionality that would be interesting to
> have for shared lib load operations in the JDK C code.
> Some examples :
> Events::log_dll_message for hs-err files reporting
> JFR event NativeLibraryLoad
> Th
On Fri, 11 Aug 2023 23:08:56 GMT, Alexey Bakhtin wrote:
> JGSS is implemented in the JVM in 2 levels: the standard Java security
> provider for Kerberos in sun.security.jgss.krb5.Krb5MechFactory and the JAAS
> login module for Kerberos in com.sun.security.auth.module.Krb5LoginModule.
> The pro
On Fri, 11 Aug 2023 23:08:56 GMT, Alexey Bakhtin wrote:
> JGSS is implemented in the JVM in 2 levels: the standard Java security
> provider for Kerberos in sun.security.jgss.krb5.Krb5MechFactory and the JAAS
> login module for Kerberos in com.sun.security.auth.module.Krb5LoginModule.
> The pro
On Mon, 14 Aug 2023 19:36:41 GMT, Alexey Bakhtin wrote:
> Naming, of course, can be discussed and changed.
Yes, naming is hard :-)
> I've tried to make different naming for the System property and configuration
> option, so they are not messed up.
I would think having two different names for
On Mon, 14 Aug 2023 16:28:24 GMT, Eirik Bjorsnos wrote:
>> JGSS is implemented in the JVM in 2 levels: the standard Java security
>> provider for Kerberos in sun.security.jgss.krb5.Krb5MechFactory and the JAAS
>> login module for Kerberos in com.sun.security.auth.module.Krb5LoginModule.
>> The
On Fri, 11 Aug 2023 17:23:52 GMT, Ben Perez wrote:
> Removed PKCS7.verify() since no other code in JDK calls it.
This pull request has now been integrated.
Changeset: 595fdd36
Author:Ben Perez
Committer: Sean Mullan
URL:
https://git.openjdk.org/jdk/commit/595fdd36c5f735b53ed2950c53
On Mon, 14 Aug 2023 17:00:58 GMT, Ben Perez wrote:
>> Removed PKCS7.verify() since no other code in JDK calls it.
>
> Ben Perez has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated copyright
Marked as reviewed by mullan (Reviewer).
---
> Removed PKCS7.verify() since no other code in JDK calls it.
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Updated copyright
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15251/files
- new: https://git.openjdk.o
On Fri, 11 Aug 2023 23:08:56 GMT, Alexey Bakhtin wrote:
> JGSS is implemented in the JVM in 2 levels: the standard Java security
> provider for Kerberos in sun.security.jgss.krb5.Krb5MechFactory and the JAAS
> login module for Kerberos in com.sun.security.auth.module.Krb5LoginModule.
> The pro
On Wed, 9 Aug 2023 17:57:30 GMT, Liam Miller-Cushon wrote:
> Please consider this fix for
> [JDK-8314045](https://bugs.openjdk.org/browse/JDK-8314045), which adds a
> missing size check to avoid an `ArithmeticException` in `GaloisCounterMode`.
This pull request has now been integrated.
Change
On Wed, 9 Aug 2023 23:41:29 GMT, Liam Miller-Cushon wrote:
>> Please consider this fix for
>> [JDK-8314045](https://bugs.openjdk.org/browse/JDK-8314045), which adds a
>> missing size check to avoid an `ArithmeticException` in `GaloisCounterMode`.
>
> Liam Miller-Cushon has updated the pull requ
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote:
> Currently there is a number of functionality that would be interesting to
> have for shared lib load operations in the JDK C code.
> Some examples :
> Events::log_dll_message for hs-err files reporting
> JFR event NativeLibraryLoad
> Th
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote:
> Currently there is a number of functionality that would be interesting to
> have for shared lib load operations in the JDK C code.
> Some examples :
> Events::log_dll_message for hs-err files reporting
> JFR event NativeLibraryLoad
> Th
Currently there is a number of functionality that would be interesting to have
for shared lib load operations in the JDK C code.
Some examples :
Events::log_dll_message for hs-err files reporting
JFR event NativeLibraryLoad
There is the need to update the shared lib Cache on AIX ( see
LoadedLibra
26 matches
Mail list logo
