On Thu, 10 Aug 2023 00:56:56 GMT, Valerie Peng wrote:
> Starting NSS v3.91, SHA-3 support is added for MessageDigest but not for PSS
> Signature. This breaks existing test assumptions made by PSS regression
> tests. In addition, the NSS SHA-3 message digests do not support cloning
> which caus
On Tue, 1 Aug 2023 21:08:49 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8312461
Marked as reviewed by djelinski (Reviewer).
Please update the copyright year.
-
PR Review: https://git.openjdk.org/jdk/pull/15113#pullrequestreview-1571072631
PR Comment: https://git.
> We should set the -permissive- flag for the Microsoft Visual C compiler, as
> was requested by the now backed out
> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
> with some effort, given that the significantly stricter gcc can now compile
> an experimental Window
On Wed, 9 Aug 2023 17:56:02 GMT, Valerie Peng wrote:
>> https://bugs.openjdk.org/browse/JDK-8312461
>
> Changes look good.
> BTW, need to add noreg-xxx label to the bug.
@valeriepeng Thanks for the review!
-
PR Comment: https://git.openjdk.org/jdk/pull/15113#issuecomment-167247617
Starting NSS v3.91, SHA-3 support is added for MessageDigest but not for PSS
Signature. This breaks existing test assumptions made by PSS regression tests.
In addition, the NSS SHA-3 message digests do not support cloning which causes
the failure of TestCloning.java.
This PR adds a PSSUtil.java
On Wed, 9 Aug 2023 23:09:37 GMT, Anthony Scarpino wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Check for AEADBadTagException specifically
>
> test/jdk/com/sun/crypto/provider/Cipher/AEAD/GCMShortInput.java
> Please consider this fix for
> [JDK-8314045](https://bugs.openjdk.org/browse/JDK-8314045), which adds a
> missing size check to avoid an `ArithmeticException` in `GaloisCounterMode`.
Liam Miller-Cushon has updated the pull request incrementally with one
additional commit since the last revisi
On Wed, 9 Aug 2023 23:15:59 GMT, Liam Miller-Cushon wrote:
>> Please consider this fix for
>> [JDK-8314045](https://bugs.openjdk.org/browse/JDK-8314045), which adds a
>> missing size check to avoid an `ArithmeticException` in `GaloisCounterMode`.
>
> Liam Miller-Cushon has updated the pull requ
Please consider this fix for
[JDK-8314045](https://bugs.openjdk.org/browse/JDK-8314045), which adds a
missing size check to avoid an `ArithmeticException` in `GaloisCounterMode`.
-
Commit messages:
- 8314045: ArithmeticException in GaloisCounterMode
Changes: https://git.openjdk.or
On Tue, 1 Aug 2023 21:08:49 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8312461
Changes look good.
BTW, need to add noreg-xxx label to the bug.
-
Marked as reviewed by valeriep (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15113#pullrequestreview-15702
On Wed, 9 Aug 2023 07:03:00 GMT, Matthias Baesken wrote:
> > > Hi Valerie, we put the PR into our build/test queue to check if it solves
> > > some errors we currently notice in CertChainRemoval.java .
> >
> >
> > Sure, thanks! What is the errors that you observed? Are you running against
> >
On Fri, 30 Jun 2023 16:16:38 GMT, Pavel Rappo wrote:
> Please review this PR to use modern APIs and language features to simplify
> `equals` and `hashCode` in security area.
>
> I understand that security area is sensitive and a non-expert, such as
> myself, should tread carefully; so below ar
On Tue, 8 Aug 2023 16:17:44 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
On Wed, 9 Aug 2023 06:37:10 GMT, Thomas Stuefe wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 22 additional
>> commits
On Wed, 9 Aug 2023 06:53:49 GMT, David Holmes wrote:
>> I wrote this code ages ago. I'm not sure what's weird or suspicious about
>> it, though. The comment at the file's beginning explains this code's
>> motivation.
>>
>> The buffer was never thought to be used for something different than HA
Hi Matthias,
As I understand it, the problem is that you need to open a new
connection to the same host on a different port, and reuse the TLS
session that was established on the original port. Is that correct?
Normally I'd recommend creating a layered socket using
SSLSocketFactory.html#createSock
On Tue, 8 Aug 2023 23:03:02 GMT, Valerie Peng wrote:
> > Hi Valerie, we put the PR into our build/test queue to check if it solves
> > some errors we currently notice in CertChainRemoval.java .
>
> Sure, thanks! What is the errors that you observed? Are you running against
> NSS and which vers
17 matches
Mail list logo
