On Fri, 4 Aug 2023 22:00:41 GMT, Pavel Rappo wrote:
>> src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBError.java
>> line 523:
>>
>>> 521: if (crealm != null) result = 37 * result + crealm.hashCode();
>>> 522: if (cname != null) result = 37 * result + cname.ha
On Fri, 4 Aug 2023 15:11:47 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/sun/security/provider/certpath/CertId.java line
>> 182:
>>
>>> 180: myhash += Arrays.hashCode(issuerNameHash);
>>> 181: myhash += Arrays.hashCode(issuerKeyHash);
>>> 182: myhas
On Fri, 4 Aug 2023 17:30:06 GMT, Hai-May Chao wrote:
> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank
> you.
src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java line 159:
> 157: maxServerCertificateChainLength = (serverLen != null) ?
> 158:
On Fri, 4 Aug 2023 17:30:06 GMT, Hai-May Chao wrote:
> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank
> you.
All of the other changes look fine to me.
Does this need a test?
src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java line 115:
> 113:
On Mon, 31 Jul 2023 19:09:53 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have the code cleanup update reviewed? With this update, the unused
>> code in StatusResponseManager.java will be removed.
>>
>> Thanks,
>> Xuelei
>
> Xue-Lei Andrew Fan has updated the pull request incrementally w
On Mon, 7 Aug 2023 08:00:12 GMT, David Holmes wrote:
>> Hi David, this throw was removed for this method's declaration in the
>> corresponding hpp file in an earlier commit [8305590: Remove nothrow
>> exception specifications from operator
>> new](https://github.com/openjdk/jdk/commit/0f51e632
On Tue, 1 Aug 2023 08:19:06 GMT, Julian Waters wrote:
>> src/hotspot/os/windows/symbolengine.cpp line 114:
>>
>>> 112: _capacity = (int)(sizeof(_fallback_buffer) / sizeof(T));
>>> 113: }
>>> 114: _p[0] = (T) '\0';
>>
>> I find this use of `'\0'` quite suspicious in itself, but it
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signific
On Tue, 1 Aug 2023 08:16:41 GMT, Julian Waters wrote:
>> src/hotspot/share/memory/allocation.cpp line 114:
>>
>>> 112: //
>>> 113:
>>> 114: void* AnyObj::operator new(size_t size, Arena *arena) {
>>
>> Please remind us what the issue is with `throw()` as this is a change to
>> shared code and
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signific
10 matches
Mail list logo
