On Tue, 1 Aug 2023 08:57:56 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
On Tue, 1 Aug 2023 08:57:56 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
On Tue, 1 Aug 2023 08:57:56 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
This change addresses the scenario where a certificate is first stored as part
of a certificate chain and then stored again as a certificate corresponding to
a PrivateKey entry. Newer version of NSS errors out with CKR_GENERAL_ERROR with
the 2nd store, i.e. C_CreateObject() call.
Proposed fix i
On Thu, 3 Aug 2023 17:09:33 GMT, Rajan Halade wrote:
>> test/jdk/sun/security/pkcs11/PKCS11Test.java line 277:
>>
>>> 275: Provider[] providers = Security.getProviders();
>>> 276: for (Provider p : providers) {
>>> 277: if (p.getName().startsWith("SunPKCS11-")) {
>>
> I have updated PKCS11Test.java to mark test as skipped only when all
> testDefault, testNSS, and testDeimos tests are skipped. This file also
> includes new trace messages, code cleanup and format change. Some other test
> files are updated to mark as skipped as they use TestNG framework to ex
On Thu, 3 Aug 2023 06:40:27 GMT, Sibabrata Sahoo wrote:
>> Rajan Halade has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8313206: revert skipTest update to address with new bug
>
> test/jdk/sun/security/pkcs11/KeyStore/SecretKeysBasic.jav
On Thu, 3 Aug 2023 10:04:17 GMT, Sibabrata Sahoo wrote:
>> test/jdk/sun/security/pkcs11/PKCS11Test.java line 973:
>>
>>> 971: return r;
>>> 972: }
>>> 973:
>>
>> I am not sure if 'NO_DEFAULT' expected to be true in setCommonSystemProps()
>> Line:977 or it need to be explicitly res
On Thu, 3 Aug 2023 09:46:48 GMT, Sibabrata Sahoo wrote:
>> Rajan Halade has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8313206: revert skipTest update to address with new bug
>
> test/jdk/sun/security/pkcs11/PKCS11Test.java line 973:
>
On Wed, 2 Aug 2023 22:27:05 GMT, Rajan Halade wrote:
>> I have updated PKCS11Test.java to mark test as skipped only when all
>> testDefault, testNSS, and testDeimos tests are skipped. This file also
>> includes new trace messages, code cleanup and format change. Some other test
>> files are up
On Wed, 2 Aug 2023 22:27:05 GMT, Rajan Halade wrote:
>> I have updated PKCS11Test.java to mark test as skipped only when all
>> testDefault, testNSS, and testDeimos tests are skipped. This file also
>> includes new trace messages, code cleanup and format change. Some other test
>> files are up
On Wed, 2 Aug 2023 06:42:29 GMT, Christoph Langer wrote:
> Hi all,
>
> This pull request contains a backport of
> [JDK-8309088](https://bugs.openjdk.org/browse/JDK-8309088), commit
> [4c2e54fb](https://github.com/openjdk/jdk/commit/4c2e54fb055bee0af5cd838fdd32a0f7902d51e3)
> from the [openjdk
On Wed, 2 Aug 2023 22:27:05 GMT, Rajan Halade wrote:
>> I have updated PKCS11Test.java to mark test as skipped only when all
>> testDefault, testNSS, and testDeimos tests are skipped. This file also
>> includes new trace messages, code cleanup and format change. Some other test
>> files are up
13 matches
Mail list logo
